[Bug 1263078] Re: Truncate long device description in applet menu

2014-01-07 Thread Mathieu Trudel-Lapierre
I agree it probably should be ellipsized in some way. However, the attached patch would clearly not be acceptable upstream -- there is a better way to do this with GTK functions. Could you see if you could rewrite / adjust the patch, and how well it would work using gtk_label_set_ellipsize() and g

[Bug 1263078] Re: Truncate long device description in applet menu

2014-01-07 Thread Mathieu Trudel-Lapierre
Unsubscribing sponsors team for now since the patch needs work; please re-subscribe sponsors once the patch is ready, and I'll gladly sponsor the change. ** Changed in: network-manager-applet (Ubuntu) Status: New => Triaged ** Changed in: network-manager-applet (Ubuntu) Importance: Unde

[Bug 1263078] Re: Truncate long device description in applet menu

2014-01-07 Thread Amir
Mathieu, I'm well are of the gtk_label_set_ellipsize() function but the reason why I didn't use in the first place is because it only cut off long string after x number of characters then append '...' to it. I didn't like the idea because you'd lose the meaningful portion of info near the end of t

[Bug 1263078] Re: Truncate long device description in applet menu

2017-07-31 Thread TJ
At least since 16.04, and probably earlier, upstream have done work on this. The Vendor and Model/Product strings are processed and common un- needed words are removed (e.g. "Intel Corporation" becomes "Intel") so I think this can be marked as Fixed. ** Changed in: network-manager-applet (Ubuntu)