[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Luca Falavigna
Debdiff for dapper-proposed. ** Attachment added: "plr_0.6.2-1ubuntu0.1.debdiff" http://launchpadlibrarian.net/8977390/plr_0.6.2-1ubuntu0.1.debdiff ** Changed in: plr (Ubuntu Dapper) Status: New => Confirmed ** Summary changed: - R_HOME environmental variable not set + [SRU] R_HOME en

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Luca Falavigna
Debdiff for edgy-proposed. ** Attachment added: "plr_0.6.2-4ubuntu0.1.debdiff" http://launchpadlibrarian.net/8977375/plr_0.6.2-4ubuntu0.1.debdiff ** Changed in: plr (Ubuntu Edgy) Status: New => Confirmed -- [SRU] R_HOME environmental variable not set https://bugs.launchpad.net/bugs/13

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Luca Falavigna
Debdiff for feisty-proposed. ** Attachment added: "plr_0.6.2-4ubuntu1.2.debdiff" http://launchpadlibrarian.net/8976472/plr_0.6.2-4ubuntu1.2.debdiff ** Changed in: plr (Ubuntu Feisty) Status: New => Confirmed -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/1300

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Martin Pitt
Ah, I see. You need to apply the patch in debian/rules then, no problem. -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list u

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Luca Falavigna
I fear I can't just apply this fix inline because source files are into a tarball and they are uncompressed at build time. I'm not aware of a solution without using a patch system, even a homemade one. -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 You received t

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Martin Pitt
Luca, yes I think this would make a fine SRU. I guess the patch will more or less apply to previous versions, too, but there are some different build systems, etc. For SRUs, please do not introduce dpatch, just apply it inline. Please attach debdiffs for dapper and feisty, I will review them and s

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Luca Falavigna
Thanks Martin! What about SRUs? Do you think it's worth to manage them? -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ub

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Martin Pitt
plr (1:8.2.0.1-2) unstable; urgency=low * Move packaging to cdbs. * Add debian/patches/R_HOME_default.patch: Fall back to /usr/lib/R if R_HOME is not defined. This is pretty much a constant in Debian and Ubuntu, and doing it with an implicit default is much more elegant than hacking in

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Martin Pitt
Luca, that looks good. I just fixed the indentation and used simple- patchsys.mk (I like cdbs better than dpatch). I uploaded a new Debian revision with that fix and synced it to Gutsy. Thank you! ** Changed in: plr (Ubuntu) Status: Confirmed => Fix Released -- R_HOME environmental varia

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Luca Falavigna
Attached debdiff implements the above solution. ** Attachment added: "plr_8.2.0.1-1ubuntu1.debdiff" http://launchpadlibrarian.net/8969873/plr_8.2.0.1-1ubuntu1.debdiff -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 You received this bug notification because you

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Bug Watch Updater
** Changed in: plr (Debian) Status: Unknown => New -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@list

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-24 Thread Luca Falavigna
It could be a better solution, lesser code required and no risks to have problems in postgresql. I will try to find a solution this way in the next days. Thank you for pointing this out. -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 You received this bug notifi

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-23 Thread Martin Pitt
Luca, that patch looks good now, thank you! Dirk just made a good point in the corresponding Debian bug. It is probably much easier to hardcode that value as a fallback in the plr source itself than to muck around with the environment file. ** Bug watch added: Debian Bug tracker #439270 http:

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-23 Thread Luca Falavigna
New debdiff should fix some issues. I've also added another switch which creates environment file if not present. Sorry for the delay and thanks for your patience. ** Attachment added: "plr_8.2.0.1-1ubuntu1.debdiff" http://launchpadlibrarian.net/8957120/plr_8.2.0.1-1ubuntu1.debdiff -- R_HOME

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-22 Thread Martin Pitt
OK, seems I still managed to overlook some things, and there are some new issues: * The grep and thus the postinst will fail if 'environment' does not exist. * stylistic: IMHO this would be easier to read: if ! grep -q "^R_HOME" /etc/postgresql/$cluster/environment * The postrm should do clean

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-22 Thread Luca Falavigna
Again, thanks for the feedback and sorry for bothering you more than necessary :) ** Attachment added: "plr_8.2.0.1-1ubuntu1.debdiff" http://launchpadlibrarian.net/8931478/plr_8.2.0.1-1ubuntu1.debdiff -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 You received

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-21 Thread Martin Pitt
Luca, thanks, this already looks better. Still some issues: * The postinst loop does not check whether R_HOME is already set. So every installation or upgrade of plr would add another R_HOME to the file, and this would even override an admin's setting which points to somewhere else. * The post

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-21 Thread Luca Falavigna
Thanks for your feedback, Martin. I attach a new debdiff which should cover your suggestion. ** Attachment added: "plr_8.2.0.1-1ubuntu1.debdiff" http://launchpadlibrarian.net/8926228/plr_8.2.0.1-1ubuntu1.debdiff -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 Y

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-21 Thread Martin Pitt
This is not quite sufficient, I'm afraid. You cannot assume that there is only one 8.2 cluster, and that it is called 'main'. That is the default after a clean installation, but people are free to create arbitrarily many clusters. So you should iterate over "pg_lsclusters -h" to find out valid clu

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-21 Thread Daniel Holbach
Martin: can you check this one out? ** Changed in: plr (Ubuntu) Assignee: (unassigned) => Martin Pitt -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubun

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-11 Thread Barry deFreese
This looks clean enough but you might want to ping Martin Pitt (pitti) since he appears to be the maintainer. Thanks for the patch! -- R_HOME environmental variable not set https://bugs.launchpad.net/bugs/130059 You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-03 Thread Luca Falavigna
Attached debdiff for Gutsy should fix this. NOTE: you will have to install plr build-dependencies to regenerate source package. ** Attachment added: "plr_8.2.0.1-1ubuntu1.debdiff" http://launchpadlibrarian.net/8674774/plr_8.2.0.1-1ubuntu1.debdiff -- R_HOME environmental variable not set http

[Bug 130059] Re: R_HOME environmental variable not set

2007-08-03 Thread Luca Falavigna
Confirmed in Gutsy, Feisty, Edgy, and Dapper. Dapper version requires additional love: [EMAIL PROTECTED]:/# sudo -u postgres psql plr_test < /usr/share/postgresql/8.1/plr.sql SET ERROR: could not load library "/usr/lib/postgresql/8.1/lib/plr.so": libR.so: cannot open shared object file: No such