[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-11-24 Thread Chuck Short
** Changed in: augeas (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to augeas in Ubuntu. https://bugs.launchpad.net/bugs/1302638 Title: augeas-tools fails to parse krb5.conf (solution provided)

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-11-24 Thread Chuck Short
** Changed in: augeas (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1302638 Title: augeas-tools fails to parse krb5.conf (solution provided) To manage

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-09 Thread Jurjen Bokma
I opened a PR on Github as Raphaël requested. One more thing: the Trusty source package depends neither on flex nor on bison. I think it should, but I'm not sure enough to open another bug. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-09 Thread Jurjen Bokma
Err.. s/depends/build-depends/ -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to augeas in Ubuntu. https://bugs.launchpad.net/bugs/1302638 Title: augeas-tools fails to parse krb5.conf (solution provided) To manage notifications about

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-09 Thread Jurjen Bokma
I opened a PR on Github as Raphaël requested. One more thing: the Trusty source package depends neither on flex nor on bison. I think it should, but I'm not sure enough to open another bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-09 Thread Jurjen Bokma
Err.. s/depends/build-depends/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1302638 Title: augeas-tools fails to parse krb5.conf (solution provided) To manage notifications about this bug go to:

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Robie Basak
Thank you for taking the time to report this bug and helping to make Ubuntu better. Have you sent this patch upstream? And does it cause any changes to the structure of the tree? Once you've responded, please change the bug status back to New. Thanks! ** Changed in: augeas (Ubuntu)

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Jurjen Bokma
I'm the one who should do the thanking: I'm using your distro. I have not sent the changes upstream. I'm not very familiar with the jargon of parse tree structure. I'd say it obviously causes changes in the structure of the tree: it adds leaves. But I presume the question is meant: Are there

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Robie Basak
I'd say it obviously causes changes in the structure of the tree: it adds leaves. But I presume the question is meant: Are there any trees that are parseable by both the unpatched and the patched lens, but which do not give identical trees? Just to be clear, I think even just adding leaves could

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Robie Basak
Thank you for your reply! I'm the one who should do the thanking: I'm using your distro. I guess it's a two way thing; you're contributing, too! :) Let me give you an example of why I ask the question. Let's say that in Ubuntu, we take your patch. Upstream later decide to achieve the same

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Raphaël Pinson
hat type=augeas_dev I'll be happy to merge your patch. Please open a PR against https://github.com/hercules-team/augeas and add unit tests for your bug, and I'll merge it. /hat hat type=ubuntu_dev If you think this should be fixed in trusty, I can also get the patch into the package and see if

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Jurjen Bokma
Ok, I cloned the GitHub repository, forked, making changes. As for unit tests, it looks to me like an entire lens is the unit of testing, so I would edit lenses/tests/test_krb5.aug to include some previously unparsed in- and output. Is that what you want me to do? Also, it's not unlikely that

Re: [Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Raphaël Pinson
On Tue, Apr 8, 2014 at 8:40 PM, Jurjen Bokma j.bo...@rug.nl wrote: Ok, I cloned the GitHub repository, forked, making changes. As for unit tests, it looks to me like an entire lens is the unit of testing, so I would edit lenses/tests/test_krb5.aug to include some previously unparsed in- and

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Robie Basak
Thank you for taking the time to report this bug and helping to make Ubuntu better. Have you sent this patch upstream? And does it cause any changes to the structure of the tree? Once you've responded, please change the bug status back to New. Thanks! ** Changed in: augeas (Ubuntu)

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Jurjen Bokma
I'm the one who should do the thanking: I'm using your distro. I have not sent the changes upstream. I'm not very familiar with the jargon of parse tree structure. I'd say it obviously causes changes in the structure of the tree: it adds leaves. But I presume the question is meant: Are there

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Robie Basak
I'd say it obviously causes changes in the structure of the tree: it adds leaves. But I presume the question is meant: Are there any trees that are parseable by both the unpatched and the patched lens, but which do not give identical trees? Just to be clear, I think even just adding leaves could

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Robie Basak
Thank you for your reply! I'm the one who should do the thanking: I'm using your distro. I guess it's a two way thing; you're contributing, too! :) Let me give you an example of why I ask the question. Let's say that in Ubuntu, we take your patch. Upstream later decide to achieve the same

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Raphaël Pinson
hat type=augeas_dev I'll be happy to merge your patch. Please open a PR against https://github.com/hercules-team/augeas and add unit tests for your bug, and I'll merge it. /hat hat type=ubuntu_dev If you think this should be fixed in trusty, I can also get the patch into the package and see if

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Jurjen Bokma
Ok, I cloned the GitHub repository, forked, making changes. As for unit tests, it looks to me like an entire lens is the unit of testing, so I would edit lenses/tests/test_krb5.aug to include some previously unparsed in- and output. Is that what you want me to do? Also, it's not unlikely that

Re: [Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-08 Thread Raphaël Pinson
On Tue, Apr 8, 2014 at 8:40 PM, Jurjen Bokma j.bo...@rug.nl wrote: Ok, I cloned the GitHub repository, forked, making changes. As for unit tests, it looks to me like an entire lens is the unit of testing, so I would edit lenses/tests/test_krb5.aug to include some previously unparsed in- and

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-04 Thread Jurjen Bokma
** Patch added: output of diff -u krb5.aug.old /usr/share/augeas/lenses/dist/krb5.aug https://bugs.launchpad.net/ubuntu/+source/augeas/+bug/1302638/+attachment/4065670/+files/krb5.aug.patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-04 Thread Ubuntu Foundations Team Bug Bot
The attachment output of diff -u krb5.aug.old /usr/share/augeas/lenses/dist/krb5.aug seems to be a patch. If it isn't, please remove the patch flag from the attachment, remove the patch tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-04 Thread Jurjen Bokma
** Patch added: output of diff -u krb5.aug.old /usr/share/augeas/lenses/dist/krb5.aug https://bugs.launchpad.net/ubuntu/+source/augeas/+bug/1302638/+attachment/4065670/+files/krb5.aug.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1302638] Re: augeas-tools fails to parse krb5.conf (solution provided)

2014-04-04 Thread Ubuntu Foundations Team Bug Bot
The attachment output of diff -u krb5.aug.old /usr/share/augeas/lenses/dist/krb5.aug seems to be a patch. If it isn't, please remove the patch flag from the attachment, remove the patch tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message