[Bug 1363015] Re: App icons require shaping at every callsite

let's discuss in the next SDK meeting. It would be a good thing to perhaps have an "appIcon:true/false" property of the Icon component, or an appIcon component - which apply the ubuntuShape on the icon by default. The sharp corners on app icons are something that are not our visual style -- You

[Bug 1363015] Re: App icons require shaping at every callsite

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: notify-osd (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1363015 Title:

[Bug 1363015] Re: App icons require shaping at every callsite

Eighteen months later, new cases have appeared where app icons are incorrectly rendered with unrounded corners: indicator-messages and indicator-sound. Meanwhile, bug 1449295 is another example of the harm of not implementing this: engineers are trying to remember all the places that render app ic

[Bug 1363015] Re: App icons require shaping at every callsite

Okay, so maybe it's impractical to reach the "It's impossible to get wrong" level. But your AppIcon component suggestion would at least get us up to the "The name tells you how to use it" level. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1363015] Re: App icons require shaping at every callsite

Unfortunately that's rather backwards as it means tentatively looking for .desktop files in the same folder, all parent folders, all sub folders and parsing any .desktop that may be found, for every single image opened - when the app had to have done this, more efficiently, wherever the icon paths

[Bug 1363015] Re: App icons require shaping at every callsite

I think you just described how to fix the bug. :-) If the "icon of a particular app comes from its .desktop file from its installation folder", then the way Ubuntu should tell whether it should shape an arbitrary icon is by checking to see if it is one of the icons listed in the .desktop file in it

[Bug 1363015] Re: App icons require shaping at every callsite

The problem is that "app icons" are not a technical concept. "The" icon of a particular app comes from its .desktop file from its installation folder, and at the end of the day will have an arbitrary filename looking like any other image. Click packages can have multiple unrelated images and more t

[Bug 1363015] Re: App icons require shaping at every callsite

Christian, I fully agree that shaping icons shouldn't be part of a list API. It's nothing to do with lists; for example, developers often need to use app icons in splash screens or About screens. But that doesn't address this bug at all. The bug here isn't "List item icons usually have inappropria

[Bug 1363015] Re: App icons require shaping at every callsite

The preliminary conclusion is to leave this out of the new API - the current ListItem is going to be deprecated because it's by design very slow. The built-in shape feature is actually one of the reasons for that. And it looks to be the minority of use cases that require a shape at all. 14:33 kal

[Bug 1363015] Re: App icons require shaping at every callsite

** Package changed: ubuntu-ui-toolkit (Ubuntu) => ubuntu-ui-toolkit -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1363015 Title: App icons require shaping at every callsite To manage notifications

[Bug 1363015] Re: App icons require shaping at every callsite

** Changed in: ubuntu-ui-toolkit (Ubuntu) Assignee: (unassigned) => Christian Dywan (kalikiana) ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bug

[Bug 1363015] Re: App icons require shaping at every callsite

FWIW I was just discussing this with Benjamin Keyser, and he said (paraphrasing), "Why not rename those properties to something like isAppIcon? Then you wouldn't have to remember that app icons get frames and others don't, you're just being asked whether it's an icon for an app." That would raise

[Bug 1363015] Re: App icons require shaping at every callsite

If a usability researcher saw eight users making the same kind of mistake when using an Ubuntu phone, the researcher might make a suggestion for how to fix the design flaw, but finding the best solution would be the platform design team's responsibility. Here, I've given you eight examples of engin

[Bug 1363015] Re: App icons require shaping at every callsite

** Description changed: In list items, showing an app icon in the correct Ubuntu shape requires shaping it when you are using it: ListItem.Standard{IconFrame: True}. - +

[Bug 1363015] Re: App icons require shaping at every callsite

Do we have some code examples? Where do app icons come from? I don't know how consistent the path is… doing magic on arbitrary path names may or may not make it even more confusing when the outcome changes depending on the image. ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: New => Inco

[Bug 1363015] Re: App icons require shaping at every callsite

** Description changed: - Currently, showing an app icon in the correct Ubuntu shape requires - shaping it when you are using it. - - For example, ensuring that "iconFrame" is set to "True" when using ListItem.Standard{}. + In list items, showing an app icon in the correct Ubuntu shape requires

[Bug 1363015] Re: App icons require shaping at every callsite

** Description changed: Currently, showing an app icon in the correct Ubuntu shape requires shaping it when you are using it. For example, ensuring that "iconFrame" is set to "True" when using ListItem.Standard{}.

[Bug 1363015] Re: App icons require shaping at every callsite

** Description changed: Currently, showing an app icon in the correct Ubuntu shape requires shaping it when you are using it. For example, ensuring that "iconFrame" is set to "True" when using ListItem.Standard{}.