[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2016-04-23 Thread Mathew Hodson
** Changed in: gui-ufw (Ubuntu Vivid) Status: Fix Committed => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1410839 Title: Shell Command injection in ufw_backend.py To manage noti

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-11-02 Thread Mathew Hodson
** Changed in: gui-ufw (Ubuntu) Importance: High => Medium ** Changed in: gui-ufw (Ubuntu Vivid) Importance: High => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1410839 Title: Shell

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-11-02 Thread Mathew Hodson
** Tags removed: removal-candidate ** Information type changed from Public to Public Security ** Changed in: gui-ufw (Ubuntu) Importance: Undecided => High ** Changed in: gui-ufw (Ubuntu Vivid) Importance: Undecided => High -- You received this bug notification because you are a member o

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-10-08 Thread Brian Murray
** Also affects: gui-ufw (Ubuntu Vivid) Importance: Undecided Status: New ** Changed in: gui-ufw (Ubuntu Vivid) Status: New => Fix Committed ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of U

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-10-03 Thread Bernd Dietzel
fix works. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1410839 Title: Shell Command injection in ufw_backend.py To manage notifications about this bug go to: https://bugs.launchpad.net/gui-ufw/+b

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-07-01 Thread Chris J Arges
Hello Bernd, or anyone else affected, Accepted gui-ufw into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gui- ufw/15.04.4-0ubuntu0.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https:

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-06-04 Thread Launchpad Bug Tracker
This bug was fixed in the package gui-ufw - 15.10.0-0ubuntu1 --- gui-ufw (15.10.0-0ubuntu1) wily; urgency=medium * New upstream release. Upstream changelog: + 15.10.0 - Added miniDLNA profile - Updated languages + 15.04.4 - Fix: Migrate commands to subproce

Re: [Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-21 Thread costales
Hi Bernd! Yes, you are right. I tried subproccess a few years ago and I found something that was not working in what I need (i don't remember what). But I will try it again :) I will create another bug for that and I will give you a feedback. I can't upload that change because It'll be complicate

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-21 Thread Bernd Dietzel
Ok, the parameters are filtered now. I'd still like to see subprocess.Popen() in combination with it's Parameter shell=False in the code. Please, do not use commands.getstatusoutput() , its unsave when there are arguments in the string wich the attacker can reach. Subprocess.Popen() directs the

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-21 Thread costales
** Changed in: gui-ufw Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1410839 Title: Shell Command injection in ufw_backend.py To manage notifications abou

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-21 Thread costales
Wow Bernd! :) You're doing a really awesome review!! I'll be in paranoiac mode on and I'll check all the parameters. Please, take a look to the path :) Thanks in advance! ** Attachment removed: "Patchs for Ubuntu 14.04 & 14.10" https://bugs.launchpad.net/gui-ufw/+bug/1410839/+attachment/43007

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-21 Thread costales
** Patch removed: "patchs.tar.gz" https://bugs.launchpad.net/gui-ufw/+bug/1410839/+attachment/4301935/+files/patchs.tar.gz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1410839 Title: Shell Comm

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-21 Thread costales
** Changed in: gui-ufw Status: Fix Released => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1410839 Title: Shell Command injection in ufw_backend.py To manage notifications abou

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-20 Thread Bernd Dietzel
I was able to use "iface" to insert a shell command, too. 1.) save a profile wich uses some interface , for example "eth0" to your home directory. 2.) edit the file like this iface = eth0;xterm; 3.) rename the profile to some other name than before 4.) import the new profile with Gufw from your

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-19 Thread Bernd Dietzel
It was an honor to help you :-) Maybe it would be an good idea to think about 'quoting' each and every parameter before it's passed to command ? https://docs.python.org/3/library/shlex.html#shlex.quote with best reagrds Bernd -- You received this bug notification because you are a member of U

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-19 Thread costales
@Bernd, I owe you a beer ;P I was reviewing the code and I found another shell injection in the IP & Ports :( I'm attaching the patchs for all the affected versions and I'm sending the new version 15.04.2 to the maintainers. Best regards and thanks Bernd! ** Patch removed: "Patchs for Gufw 14.04

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-19 Thread costales
** Patch removed: "path_1410839.patch" https://bugs.launchpad.net/gui-ufw/+bug/1410839/+attachment/4300558/+files/path_1410839.patch ** Patch removed: "patch2.patch" https://bugs.launchpad.net/gui-ufw/+bug/1410839/+attachment/4300704/+files/patch2.patch ** Patch removed: "Final patch"

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-18 Thread Bernd Dietzel
Interessiting. One thing leads to an other thing :-) If its get's worse you may wan't to think about going back and using subprocess.popen() instead of the old commands.getstatusoutput() This could make the code shorter. -- You received this bug notification because you are a member of Ubuntu B

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-18 Thread costales
Updated patchs (it crashed with no profiles = first run). ** Attachment added: "Patchs for Gufw 14.04.2 & 14.10.1" https://bugs.launchpad.net/gui-ufw/+bug/1410839/+attachment/4301088/+files/patchs_14.04.2_and_14.10.1.tar.gz -- You received this bug notification because you are a member of Ub

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-18 Thread costales
@Bernd: All is done :) I sent just now the updated version 15.04.1. I want to thank you the report of an impotant vulnerability like this |o/ Thanks!! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/141

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-17 Thread Ubuntu Foundations Team Bug Bot
The attachment "path_1410839.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-mur

[Bug 1410839] Re: Shell Command injection in ufw_backend.py

2015-01-17 Thread costales
** Also affects: gui-ufw (Ubuntu) Importance: Undecided Status: New ** Changed in: gui-ufw (Ubuntu) Status: New => Confirmed ** Changed in: gui-ufw Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which