[Bug 1413494] Re: Free partition space isn't correctly updated after erasing

2015-02-18 Thread Launchpad Bug Tracker
** Branch linked: lp:~yuningdodo/usb-creator/usb-creator.lp1413494v2 -update-free-space-after-format -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1413494 Title: Free partition space isn't correctly

[Bug 1413494] Re: Free partition space isn't correctly updated after erasing

2015-02-18 Thread Launchpad Bug Tracker
** Branch linked: lp:~yuningdodo/usb-creator/usb-creator.lp1413494-auto- mount-after-format -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1413494 Title: Free partition space isn't correctly updated

[Bug 1413494] Re: Free partition space isn't correctly updated after erasing

2015-02-18 Thread Yu Ning
Brian, thanks for the review, here is the declaration of unmount_all(): def unmount_all(udisks, parent): '''Unmounts the device or any partitions of the device.''' As you can see the last param is expected to be parent, and in my test if we pass "dev" to it it can't unmount properly, so I thi

[Bug 1413494] Re: Free partition space isn't correctly updated after erasing

2015-02-18 Thread Brian Murray
What is the purpose of this change? --- a/bin/usb-creator-helper +++ b/bin/usb-creator-helper @@ -237,7 +237,7 @@ check_system_internal(dev) # TODO LOCK -unmount_all(udisks, dev) +unmount_all(udisks, parent_dev) Thanks! -- You received this bug notificati

[Bug 1413494] Re: Free partition space isn't correctly updated after erasing

2015-01-22 Thread Ubuntu Foundations Team Bug Bot
The attachment "auto-mount-after-format.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by

[Bug 1413494] Re: Free partition space isn't correctly updated after erasing

2015-01-21 Thread Yu Ning
I checked the source code and found usb-creator can only calculate the free space for a mounted partition, however the newly formated partition isn't mounted. So to fix the issue we could mount it automatically after the formating. In the attached patch this job is done in the dbus method Format()