[Bug 1452766] Re: [Browser] Cannot favorite site when it is loading

2015-08-17 Thread Matthew Paul Thomas
A Web page script may change, add, or remove the page title at any time, during or after page loading. document.title = "Here I am changing the title" So what the title of a bookmark should be doesn't really have anything to do with whether the page is loading. I guess it should be whatever t

[Bug 1452766] Re: [Browser] Cannot favorite site when it is loading

2015-08-17 Thread James Mulholland
** Changed in: ubuntu-ux Status: Won't Fix => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1452766 Title: [Browser] Cannot favorite site when it is loading To manage notificat

[Bug 1452766] Re: [Browser] Cannot favorite site when it is loading

2015-08-17 Thread James Mulholland
** Description changed: Simple bug but annoying: When a site is loading, the favourite star is not visible. Use-case: you get a website from a friend, or you click a link on a page when the network suddenly goes away. You want to save that page to look at it later, when your connec

[Bug 1452766] Re: [Browser] Cannot favorite site when it is loading

2015-08-04 Thread James Mulholland
Understood. We should definitely let users bookmark pages before they finish loading. I think in cases where the page isn't yet known, we can use the URL as the bookmark name/ in place of a page title (I believe bookmarks currently work this way already). --- --- --- Also, when I experimented

[Bug 1452766] Re: [Browser] Cannot favorite site when it is loading

2015-08-04 Thread Olivier Tilloy
That sounds almost right, but for this detail: when the connection is lost, the loading will eventually time out, so the "page never finishes loading" is not really a use case. However it could happen that a page takes a very long time to load, and the user might want to bookmark the page before it

[Bug 1452766] Re: [Browser] Cannot favorite site when it is loading

2015-08-04 Thread James Mulholland
Thanks for clarifying Olivier. So a revised use-case would be: 1. Attempt to visit a URL with an active connection, page begins loading. 2. Active connection is lost. Page never finishes loading & 'Network error' page is not shown. 3. User can't ever tap star to favourite entered URL (as the star

[Bug 1452766] Re: [Browser] Cannot favorite site when it is loading

2015-08-04 Thread Olivier Tilloy
I think the description of the use case doesn’t match the actual bug title: the issue is that while a page is loading (progress bar filling), the star icon is not displayed, and one has to wait until the page is fully loaded (or the loading failed due to the network going down) to be able to bookma

[Bug 1452766] Re: [Browser] Cannot favorite site when it is loading

2015-08-03 Thread James Mulholland
** Description changed: Simple bug but annoying: - When a site is loading, the favorite star is not visible. + When a site is loading, the favourite star is not visible. Use-case: you get a website from a friend, or you click a link on a page when the network suddenly goes away. You w

[Bug 1452766] Re: [Browser] Cannot favorite site when it is loading

2015-06-08 Thread Olivier Tilloy
** Changed in: webbrowser-app (Ubuntu) Importance: Undecided => Low ** No longer affects: webbrowser-app ** Also affects: webbrowser-app (Ubuntu RTM) Importance: Undecided Status: New ** Changed in: webbrowser-app (Ubuntu RTM) Status: New => Confirmed ** Changed in: webbrows