[Bug 1493049] Re: memory corruption during live-migration in TCG mode

I'm chasing a bug similar in behavior but I'm using "qemu-system-x86_64 -enable-kvm" so it's not TCG, AFAICT. Would it be possible this problem also manifests in KVM mode? Or should I open a new bug? @pboldin, when you get a chance, could you please check if the 2.0.0 +dfsg-2ubuntu1.23 version

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

** Changed in: qemu (Ubuntu Trusty) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1493049 Title: memory corruption during live-migration in TCG mode To manage

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Hello Pavel, or anyone else affected, Accepted qemu into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/2.0.0+dfsg- 2ubuntu1.23 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Hello Pavel, or anyone else affected, Accepted qemu into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/2.0.0+dfsg- 2ubuntu1.23 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

** No longer affects: qemu (Ubuntu Vivid) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to qemu in Ubuntu. https://bugs.launchpad.net/bugs/1493049 Title: memory corruption during live-migration in TCG mode To manage notifications

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

** No longer affects: qemu (Ubuntu Vivid) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1493049 Title: memory corruption during live-migration in TCG mode To manage notifications about this bug go

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

This bug was fixed in the package qemu - 1:2.3+dfsg-5ubuntu6 --- qemu (1:2.3+dfsg-5ubuntu6) wily; urgency=medium * Make qemu-system-common and qemu-utils depend on qemu-block-extra to fix errors with missing block backends. (LP: #1495895) * Cherry pick fixes for vmdk

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

This bug was fixed in the package qemu - 1:2.3+dfsg-5ubuntu6 --- qemu (1:2.3+dfsg-5ubuntu6) wily; urgency=medium * Make qemu-system-common and qemu-utils depend on qemu-block-extra to fix errors with missing block backends. (LP: #1495895) * Cherry pick fixes for vmdk

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qemu (Ubuntu Trusty) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1493049 Title:

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qemu (Ubuntu Vivid) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1493049 Title:

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qemu (Ubuntu Vivid) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to qemu in Ubuntu.

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qemu (Ubuntu Trusty) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to qemu in Ubuntu.

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Here is the updated patch for the bug. All it does is merely setting `tcg_commit' function as `log_global_start' callback. `tcg_commit' is then flushes all the appropriate TLBs on `memory_log_global_start' call. ** Patch added: "more clean solution"

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Here is the updated patch for the bug. All it does is merely setting `tcg_commit' function as `log_global_start' callback. `tcg_commit' is then flushes all the appropriate TLBs on `memory_log_global_start' call. ** Patch added: "more clean solution"

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Applying the attached patch I was able to do around 300 migrations back and forth successfully. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to qemu in Ubuntu. https://bugs.launchpad.net/bugs/1493049 Title: memory corruption during

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Applying the attached patch I was able to do around 300 migrations back and forth successfully. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1493049 Title: memory corruption during live-migration

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

@serge-hallyn, This patch is exactly what fixes the problem for me (was able to do around 150 successful migrations with it). However, this should be rewritten to only contain exactly calls to tlb_flush when in TCG mode so there is no extra code and no unrelated changes. The reason patches are

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

@serge-hallyn, This patch is exactly what fixes the problem for me (was able to do around 150 successful migrations with it). However, this should be rewritten to only contain exactly calls to tlb_flush when in TCG mode so there is no extra code and no unrelated changes. The reason patches are

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

The attachment "backported solution" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

The attachment "backported solution" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

There is no memory_region_get_dirty_log_mask in the 2.0.0, this was only introduced later. Strictly speaking, 2.0.0 is quite different from 2.4.0 in this matter but I checked the code logic here and it should be good. Yes, I was not sure what versions it affects so I only referenced Trusty. If

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

There is no memory_region_get_dirty_log_mask in the 2.0.0, this was only introduced later. Strictly speaking, 2.0.0 is quite different from 2.4.0 in this matter but I checked the code logic here and it should be good. Yes, I was not sure what versions it affects so I only referenced Trusty. If

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

thanks for reporting this bug. Your backported patch skips the part in render_memory_region() where: -fr.dirty_log_mask = mr->dirty_log_mask; +fr.dirty_log_mask = memory_region_get_dirty_log_mask(mr); Was that on purpose? Also, in the NOVA bug you said you had filed a 'trusty' bug.

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

thanks for reporting this bug. Your backported patch skips the part in render_memory_region() where: -fr.dirty_log_mask = mr->dirty_log_mask; +fr.dirty_log_mask = memory_region_get_dirty_log_mask(mr); Was that on purpose? Also, in the NOVA bug you said you had filed a 'trusty' bug.

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

@pboldin, the patch you cited was one of several (7?) which appear to be related, including commit 677e7805cf95f3b2bca8baf0888d1ebed7f0c606 Author: Paolo Bonzini Date: Mon Mar 23 10:53:21 2015 +0100 memory: track DIRTY_MEMORY_CODE in mr->dirty_log_mask

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

@pboldin, the patch you cited was one of several (7?) which appear to be related, including commit 677e7805cf95f3b2bca8baf0888d1ebed7f0c606 Author: Paolo Bonzini Date: Mon Mar 23 10:53:21 2015 +0100 memory: track DIRTY_MEMORY_CODE in mr->dirty_log_mask

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Great, thank you. ** Changed in: qemu (Ubuntu) Status: Incomplete => Triaged ** Changed in: qemu (Ubuntu) Importance: Undecided => High ** Also affects: qemu (Ubuntu Vivid) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Trusty) Importance: Undecided

[Bug 1493049] Re: memory corruption during live-migration in TCG mode

Great, thank you. ** Changed in: qemu (Ubuntu) Status: Incomplete => Triaged ** Changed in: qemu (Ubuntu) Importance: Undecided => High ** Also affects: qemu (Ubuntu Vivid) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Trusty) Importance: Undecided