[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-02-02 Thread Michał Sawicz
** Changed in: qtmir Assignee: Lukáš Tinkl (lukas-kde) => Nick Dedekind (nick-dedekind) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1535397 Title: [enhancement] Implement support for QWindow:

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-02-02 Thread Jean-Baptiste Lallement
** Tags added: lt-blocker -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1535397 Title: [enhancement] Implement support for QWindow::visibility set to Automatic To manage notifications about this

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-31 Thread Daniel van Vugt
mir (0.19.0+16.04.20160128-0ubuntu1) xenial; urgency=medium ** Changed in: mir Status: Fix Committed => Fix Released ** Changed in: mir (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-29 Thread Launchpad Bug Tracker
** Branch linked: lp:~fboucault/camera-app/fullscreen_staged_only -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1535397 Title: [enhancement] Implement support for QWindow::visibility set to Automa

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-28 Thread Renato Araujo Oliveira Filho
** Branch linked: lp:~renatofilho/mediaplayer-app/pocket-pc-full-screen -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1535397 Title: [enhancement] Implement support for QWindow::visibility set to

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-28 Thread Arthur Mello
** Branch linked: lp:~artmello/gallery-app/gallery-app- convergence_fullscreen -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1535397 Title: [enhancement] Implement support for QWindow::visibility se

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-28 Thread Bill Filler
** Changed in: camera-app (Ubuntu) Importance: Undecided => High ** Changed in: camera-app (Ubuntu) Status: New => In Progress ** Changed in: camera-app (Ubuntu) Assignee: (unassigned) => Florian Boucault (fboucault) ** Changed in: gallery-app (Ubuntu) Importance: Undecided =>

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-25 Thread Michał Sawicz
** Changed in: canonical-devices-system-image Status: Triaged => In Progress ** Changed in: unity8 (Ubuntu) Assignee: Lukáš Tinkl (lukas-kde) => Nick Dedekind (nick-dedekind) ** Changed in: qtubuntu (Ubuntu) Assignee: Lukáš Tinkl (lukas-kde) => Nick Dedekind (nick-dedekind) ** C

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-25 Thread PS Jenkins bot
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.20.0 ** Changed in: mir Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1535397

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-25 Thread Alan Griffiths
** Branch linked: lp:~alan-griffiths/mir/add- mir_surface_spec_set_shell_chrome -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1535397 Title: [enhancement] Implement support for QWindow::visibility s

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-22 Thread Alan Griffiths
My concerns are threefold: 1. there is no good name for this feature: "automatic" doesn't capture specific behaviour; 2. I don't understand why this specific use case needs any special support; and, 3. what advantage is expected from Mir being involved? As discussed above: Clients can implement

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-22 Thread Alan Griffiths
As a note to Chris's comment #9: While what is being asked for is state associated with a surface, it isn't a distinct "surface state". If modelled as surface state it requires at least new two states mir_surface_state_automatic_restored and mir_surface_state_automatic_fullscreen (and possibly mi

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-21 Thread Chris Halse Rogers
As an addendum to Alan's comment: we *have* shell-determined surface state; all surface state requests can be arbitrarily modified by the shell. The use-case being asked for is a “support for surface state that is fullscreen on the phone but windowed on the desktop”; which is available to clients

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-21 Thread Alan Griffiths
To clarify, the desired behaviour /can/ be implemented client-side with the existing Mir API. This would require implementation code in each toolkit (or client). The limitation of this approach being that the shell isn't required to respect set_state() requests issued by the client. We /can/ also

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-21 Thread Lukáš Tinkl
** Branch linked: lp:~lukas-kde/qtmir/automaticVisibility ** Branch linked: lp:~lukas-kde/unity8/automaticVisibility -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1535397 Title: [enhancement] Imple

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-21 Thread Lukáš Tinkl
** Changed in: qtmir Status: New => In Progress ** Changed in: qtmir Assignee: (unassigned) => Lukáš Tinkl (lukas-kde) ** Changed in: unity8 (Ubuntu) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscri

Re: [Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-21 Thread Michał Sawicz
I disagree with calling this a "Qt-specific API", since this is rather Ubuntu-specific behaviour, oblivious of the toolkit. Qt might be the default toolkit we're using, but clients using other toolkits (or none at all) should be able to make use of this behaviour as well. I can rename the bug to "

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-21 Thread Chris Halse Rogers
I remain unconvinced that this needs anything to be implemented in Mir at all. This appears to be a Qt-specific API that can be implemented entirely in the client-side QPA - the QPA needs to know whether the client wants automatic state anyway, knows the form-factor the surface is on, receives eve

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-21 Thread Alan Griffiths
Having discussed this a few times I've reached the following conclusion: "automatic" is not a MirSurfaceState - if it were a MirSurfaceState, then it would be correct to return it from get_state() and for it to be implemented as "looking the same as fullscreen or restored". By comparison, "restor

[Bug 1535397] Re: [enhancement] Implement support for QWindow::visibility set to Automatic

2016-01-21 Thread Daniel van Vugt
** Summary changed: - Implement support for QWindow::visibility set to Automatic + [enhancement] Implement support for QWindow::visibility set to Automatic ** Tags added: enhancement -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. ht