[Bug 1576082] Re: lxd handles cleanup of un-umountable devices badly

2016-05-24 Thread Stéphane Graber
** Changed in: lxd (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1576082 Title: lxd handles cleanup of un-umountable devices badly To manage no

[Bug 1576082] Re: lxd handles cleanup of un-umountable devices badly

2016-04-28 Thread Stéphane Graber
** Changed in: lxd (Ubuntu) Status: New => Fix Committed ** Changed in: lxd (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1576082 Title: lxd handles

[Bug 1576082] Re: lxd handles cleanup of un-umountable devices badly

2016-04-28 Thread David Hedberg
I submitted a pull request at https://github.com/lxc/lxd/pull/1964 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1576082 Title: lxd handles cleanup of un-umountable devices badly To manage notifica

[Bug 1576082] Re: lxd handles cleanup of un-umountable devices badly

2016-04-28 Thread David Hedberg
I tried changing cleanup() to properly check for errors from removeUnixDevices() and removeDiskDevices() and pass these on up the stack. This seems to work; the lxc command now reports an error ("error: lstat /var/lib/lxd/devices/c1/disk.usr-local-nfs: stale NFS file handle") and the contents of /

[Bug 1576082] Re: lxd handles cleanup of un-umountable devices badly

2016-04-28 Thread David Hedberg
** Description changed: I lost some data last night, and I think the problem has to do with how lxd cleans up when there are attached devices that can't be umounted. This is my testcase: --- # / is ext4 # /home is ext4 # /var/lib/lxd is btrfs # /usr/local/nfs is a remote nfs