[Bug 1578540] Re: setupcon looks for VARIANT in wrong path: /usr/etc/default/

2017-03-21 Thread Ɓukasz Zemczak
I agree with Michael here. For changes like these (e.g. not really ubuntu-specific) we would need at least someone from upstream reviewing the diff before considering any sponsoring. @TJ Could you please submit this patch upstream [1] and get it reviewed (and ultimately merged) before asking for

[Bug 1578540] Re: setupcon looks for VARIANT in wrong path: /usr/etc/default/

2016-06-12 Thread Michael Hudson-Doyle
I don't know much about this package, but it looks to me like this applies to the version in Debian there. Have you considered sending the patch to them? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1578540] Re: setupcon looks for VARIANT in wrong path: /usr/etc/default/

2016-06-01 Thread Mathew Hodson
** Changed in: console-setup (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1578540 Title: setupcon looks for VARIANT in wrong path: /usr/etc/default/

[Bug 1578540] Re: setupcon looks for VARIANT in wrong path: /usr/etc/default/

2016-05-05 Thread Ubuntu Foundations Team Bug Bot
The attachment "Patch that uses findfile() to locate the variant config" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed

[Bug 1578540] Re: setupcon looks for VARIANT in wrong path: /usr/etc/default/

2016-05-05 Thread TJ
I noticed the existing code to set {USER,MAIN}_CONFIG{,2} is a bit messed up; USER_CONFIG refers to console-setup but MAIN_CONFIG refers to keyboard which means lack of a keyboard.${VARIANT} causes the incorrect error message and failure. The assignments to CONFIG{,2} are also reversed; when

[Bug 1578540] Re: setupcon looks for VARIANT in wrong path: /usr/etc/default/

2016-05-05 Thread TJ
$ sh -x /bin/setupcon tj + do_font=yes + do_kbd=yes + do_check=yes + do_verbose= + do_save= + savekbdfile= + setupdir= + SETUP= + TMPFILE= + [ tj ] + [ -z ] + VARIANT=tj + shift + [ ] + installdir=/bin + installdir= + [ -n -a -d /bin ] + installdir=/usr + [ tj ] + VARIANT=.tj +