Re: [Bug 1580348] [NEW] mksh 52c bi_errorf(Tbadsubst) format string is not a string literal

2016-05-10 Thread Thorsten Glaser
Chih-Hung Hsieh dixit: >Lastest mksh/histrap.c (R52c) has a warning from clang/llvm compiler. >It is a tricky use of pointer to the middle of string literals, >which is recognized by gcc but not clang/llvm. Arrgh, stupid compilers, trying to be too smart and utterly failing. I’ve recently had “fu

Re: [Bug 1580348] [NEW] mksh 52c bi_errorf(Tbadsubst) format string is not a string literal

2016-05-10 Thread Thorsten Glaser
Chih-Hung Hsieh dixit: >change > bi_errorf(Tbadsubst); >to > bi_errorf0(Tbadsubst); >where bi_errorf0 is declared as > void bi_errorf0(const char *); // without format check >and implemented as a weak alias: > void bi_errorf0(const char *s) __attribute__((weak, alias("bi_errorf"))); For

[Bug 1580348] [NEW] mksh 52c bi_errorf(Tbadsubst) format string is not a string literal

2016-05-10 Thread Chih-Hung Hsieh
Public bug reported: Lastest mksh/histrap.c (R52c) has a warning from clang/llvm compiler. It is a tricky use of pointer to the middle of string literals, which is recognized by gcc but not clang/llvm. This warning now blocks mksh upgrade in Android open source. Could you fix the following warnin