[Bug 1645324] Re: ebtables: Lock file handling has races

2019-03-08 Thread Bug Watch Updater
** Changed in: ebtables (Debian) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645324 Title: ebtables: Lock file handling has races To manage notifications

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-13 Thread Launchpad Bug Tracker
This bug was fixed in the package ebtables - 2.0.10.4-3.5ubuntu1.17.04.1 --- ebtables (2.0.10.4-3.5ubuntu1.17.04.1) zesty; urgency=medium * Use real locking in ebtables (LP: #1645324) - Prior use of locking by file exclusive access is inadequate because if ebtables

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-13 Thread Launchpad Bug Tracker
This bug was fixed in the package ebtables - 2.0.10.4-3ubuntu1.14.04.1 --- ebtables (2.0.10.4-3ubuntu1.14.04.1) trusty; urgency=medium * Use real locking in ebtables (LP: #1645324) - Prior use of locking by file exclusive access is inadequate because if ebtables crashes

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-13 Thread Launchpad Bug Tracker
This bug was fixed in the package ebtables - 2.0.10.4-3.4ubuntu2 --- ebtables (2.0.10.4-3.4ubuntu2) xenial; urgency=medium * Use real locking in ebtables (LP: #1645324) - Prior use of locking by file exclusive access is inadequate because if ebtables crashes or is killed

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-13 Thread Launchpad Bug Tracker
This bug was fixed in the package ebtables - 2.0.10.4-3.5ubuntu1.16.10.1 --- ebtables (2.0.10.4-3.5ubuntu1.16.10.1) yakkety; urgency=medium * Use real locking in ebtables (LP: #1645324) - Prior use of locking by file exclusive access is inadequate because if ebtables

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-09 Thread Łukasz Zemczak
** Tags removed: verification-done ** Tags added: verification-done-trusty verification-done-xenial verification-done-yakkety verification-done-zesty -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-06 Thread Eric Desrochers
It has been brought to my attention the following : "I was able to install and test it and seems to be OK." ^ Tested by someone affected by the issue using the trusty-proposed package. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-02 Thread Eric Desrochers
@szilard, The constant values (#define LOCKDIR ...) hasn't been touched in these patches, meaning that it was already like that before this SRU. With that being said, the LOCKDIR location isn't a problem, so IMHO, there is no need for the LOCKDIR in Trusty to move to "/run" if it doesn't create

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-02 Thread Szilard Cserey
The verification was done using Test Case 1 and Test Case 2 However I noticed that in the Trusty version the lock file is located at /var/lib/ebtables/lock Whereas on the Xenial/Yakkety/Zesty versions lock file is at /run/ebtables.lock -- You received this bug notification because you are a

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-02 Thread Eric Desrochers
** Changed in: ebtables (Ubuntu Xenial) Assignee: Dragan S. (dragan-s) => Eric Desrochers (slashd) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645324 Title: ebtables: Lock file handling has

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-02 Thread Eric Desrochers
@szilard, is your testing/verification has been made based on Dragan's test case #1 and #2 ? Could you please provide more details ? output This will be useful informations for the SRU members to give their final approval. - Eric -- You received this bug notification because you are a

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-02 Thread Szilard Cserey
Hi All, I have successfully tested the following versions of ebtables for Trusty: 2.0.10.4-3ubuntu1.14.04.1 OK for Xenial: 2.0.10.4-3.4ubuntu2 OK for Yakkety: 2.0.10.4-3.5ubuntu1.16.10.1 OK for Zesty: 2.0.10.4-3.5ubuntu1.17.04.1 OK Szilard ** Tags removed:

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-02 Thread Szilard Cserey
** Description changed: [Impact]  * ebtables uses creation of a file with an exclusive flag    as a lock to synchronize table modification when used    with --concurrent parameter.  * If ebtables crashes it will leave a stale lock file.    This will prevent another copy of

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-06-01 Thread Łukasz Zemczak
Hello Amad, or anyone else affected, Accepted ebtables into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ebtables/2.0.10.4-3.5ubuntu1.17.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package.

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-29 Thread Eric Desrochers
** Changed in: ebtables (Ubuntu Xenial) Status: New => In Progress ** Tags removed: patch ** Tags added: sts -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645324 Title: ebtables: Lock file

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-29 Thread Eric Desrochers
** Changed in: ebtables (Ubuntu Zesty) Status: Triaged => In Progress ** Changed in: ebtables (Ubuntu Yakkety) Status: New => In Progress ** Changed in: ebtables (Ubuntu Zesty) Assignee: Dragan S. (dragan-s) => Eric Desrochers (slashd) ** Changed in: ebtables (Ubuntu Yakkety)

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-29 Thread Eric Desrochers
** Also affects: ebtables (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: ebtables (Ubuntu Yakkety) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-29 Thread Launchpad Bug Tracker
This bug was fixed in the package ebtables - 2.0.10.4-3.5ubuntu2 --- ebtables (2.0.10.4-3.5ubuntu2) artful; urgency=medium * Use real locking in ebtables (LP: #1645324) - Prior use of locking by file exclusive access is inadequate because if ebtables crashes or is killed

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-29 Thread Eric Desrochers
** Changed in: ebtables (Ubuntu Trusty) Assignee: Dragan S. (dragan-s) => Eric Desrochers (slashd) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645324 Title: ebtables: Lock file handling has

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-16 Thread Eric Desrochers
rbasak, morning I see you talked with dragan about this LP: #1645324. From now on, I'm taking care of this bug, I see that some ppls suggest Dragan to submit in the upstream project first, but in this case it seems that ebtables is nearly "dead" last commits were made in 2015. Nowadays, all the

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-16 Thread Eric Desrochers
** Description changed: [Impact] - * ebtables uses creation of a file with an exclusive flag -as a lock to synchronize table modification when used -with --concurrent parameter. +  * ebtables uses creation of a file with an exclusive flag +    as a lock to synchronize table

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-16 Thread Eric Desrochers
ebtables (for IPv4, IPv6, ARP and Ethernet bridging, respectively) are intended to be replaced with nft as a single unified implementation. With that being said, nowadays all the development/focus is happening in nft instead. - Eric -- You received this bug notification because you are a member

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-15 Thread Eric Desrochers
Artful debdiff ** Patch added: "artful_lp1645324.debdiff" https://bugs.launchpad.net/ubuntu/+source/ebtables/+bug/1645324/+attachment/4877194/+files/artful_lp1645324.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-15 Thread Eric Desrochers
** Changed in: ebtables (Ubuntu Artful) Assignee: (unassigned) => Eric Desrochers (slashd) ** Changed in: ebtables (Ubuntu Artful) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-15 Thread Eric Desrochers
** Also affects: ebtables (Ubuntu Artful) Importance: Medium Assignee: Dragan S. (dragan-s) Status: Triaged ** Changed in: ebtables (Ubuntu Artful) Assignee: Dragan S. (dragan-s) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-15 Thread Eric Desrochers
Additionally, it seems like it isn't the first time Debian patched ebtables, thus Ubuntu package without submitting upstream. Example : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813760 Zesty : libebtc.c:137:#define LOCKDIR "/run" libebtc.c:138:#define LOCKFILE LOCKDIR"/ebtables.lock"

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-15 Thread Eric Desrochers
@ChristianEhrhardt & @Robie Basak I'll be covering Dragan for this bug from now on. I'm afraid that there is not much development activities in the ebtables upstream project nowadays : Last 3 ebtables commits : Date: Tue Mar 28 19:42:39 2017 +0530 Date: Thu Oct 22 16:41:03 2015 +0200 Date:

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-03 Thread Bug Watch Updater
** Changed in: ebtables (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645324 Title: ebtables: Lock file handling has races To manage notifications about

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-03 Thread ChristianEhrhardt
Hi, Zesty+1 meant the following release which is in the meantime known as "Artful". For the SRU handling [1] in general changes need to go to the current development release first and then SRU'ed back. When you worked on this the last time zesty was just about to be released, but artful not yet

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-05-02 Thread Dragan S.
** Changed in: ebtables (Debian) Status: Fix Released => Unknown ** Changed in: ebtables (Debian) Remote watch: Debian Bug tracker #813760 => Debian Bug tracker #860590 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-04-19 Thread Dragan S.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860590 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645324 Title: ebtables: Lock file handling has races To manage notifications about this bug

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-04-19 Thread Dragan S.
** Changed in: ebtables (Ubuntu Zesty) Assignee: (unassigned) => Dragan S. (dragan-s) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645324 Title: ebtables: Lock file handling has races To

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-04-19 Thread Eric Desrochers
** Also affects: ebtables (Ubuntu Zesty) Importance: Medium Status: Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1645324 Title: ebtables: Lock file handling has races To manage

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-04-19 Thread Dragan S.
@Robie- Hi Robie- if by Z+1 you mean Zesty, I have attached the patch for zesty and Dan nominated it for zesty but we are waiting for someone with permissions to confirm it. I also filed a bug with upstream Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860590 The DEP-3 header is in

[Bug 1645324] Re: ebtables: Lock file handling has races

2017-04-19 Thread Robie Basak
As the conclusion in this bug is that better lock handling is needed (not just a path move), I've renamed the bug, and the fix isn't in the development release yet so I changed that back to Triaged. -- You received this bug notification because you are a member of Ubuntu Bugs, which is