[Bug 1662620] Re: "ip addr add" permits illegal labels

2021-10-21 Thread Christian Ehrhardt 
Thanks Chris for having a look. > On the other hand, from the bug it looks like if you *don't* mix valid and > invalid labels > then everything actually works? So this would potentially be breaking > currently working setups? Yes while having that echoing in my head for a while I think you are

[Bug 1662620] Re: "ip addr add" permits illegal labels

2021-10-19 Thread Chris Halse Rogers
Hm. It's not clear what the actual user impact of this is? Reading from the original description, it seems that if a user uses an invalid label to set one address and *also* uses a valid label to set another address *then* tools can be confused? “Our parser is actually more lenient than the

[Bug 1662620] Re: "ip addr add" permits illegal labels

2021-10-08 Thread Christian Ehrhardt 
Reviewed and tested - uploading to Bionic-unapproved for a check by the SRU Team. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1662620 Title: "ip addr add" permits illegal labels To manage

[Bug 1662620] Re: "ip addr add" permits illegal labels

2021-10-07 Thread Christian Ehrhardt 
SRU template added -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1662620 Title: "ip addr add" permits illegal labels To manage notifications about this bug go to:

[Bug 1662620] Re: "ip addr add" permits illegal labels

2021-10-07 Thread Christian Ehrhardt 
Not sure if it will pass build, review or be acceptable as SRU since it is so low impact. But the fix was so trivial that after all this time I'd feel bad to keep it as-is. So I've prepared an MP to fix it https://code.launchpad.net/~paelzer/ubuntu/+source/iproute2/+git/iproute2/+merge/409821

[Bug 1662620] Re: "ip addr add" permits illegal labels

2021-10-07 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/iproute2/+git/iproute2/+merge/409821 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1662620 Title: "ip addr add"

[Bug 1662620] Re: "ip addr add" permits illegal labels

2021-10-07 Thread Christian Ehrhardt 
Hi, I come by trying to clear out a few old bugs that might still need to be resolved (or can be closed by now). Even though this one seems to be forgotten by everyone so far it has been fixed. Bionic (affected) root@b:~# ip addr add 1.1.1.1 label test1 dev eth0 "dev" (eth0) must match "label"

[Bug 1662620] Re: "ip addr add" permits illegal labels

2017-02-13 Thread Joshua Powers
** Changed in: iproute2 (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1662620 Title: "ip addr add" permits illegal labels To manage notifications about this