Public bug reported:
Hi,
Could you please pull the following net patches into Zesty.
Thanks,
Suresh.
[root@dhcp-10-192-206-109 benet]# git log .
commit 34393529163af7163ef8459808e3cf2af7db7f16
Author: Ivan Vecera <c...@cera.cz>
Date: Fri Jan 13 22:38:29 2017 +0100
be2net: fix MAC addr setting on privileged BE3 VFs
During interface opening MAC address stored in netdev->dev_addr is
programmed in the HW with exception of BE3 VFs where the initial
MAC is programmed by parent PF. This is OK when MAC address is not
changed when an interfaces is down. In this case the requested MAC is
stored to netdev->dev_addr and later is stored into HW during opening.
But this is not done for all BE3 VFs so the NIC HW does not know
anything about this change and all traffic is filtered.
This is the case of bonding if fail_over_mac == 0 where the MACs of
the slaves are changed while they are down.
The be2net behavior is too restrictive because if a BE3 VF has
the FILTMGMT privilege then it is able to modify its MAC without
any restriction.
To solve the described problem the driver should take care about these
privileged BE3 VFs so the MAC is programmed during opening. And by
contrast unpriviled BE3 VFs should not be allowed to change its MAC
in any case.
Cc: Sathya Perla <sathya.pe...@broadcom.com>
Cc: Ajit Khaparde <ajit.khapa...@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com>
Cc: Somnath Kotur <somnath.ko...@broadcom.com>
Signed-off-by: Ivan Vecera <c...@cera.cz>
Signed-off-by: David S. Miller <da...@davemloft.net>
commit 6d928ae590c8d58cfd5cca997d54394de139cbb7
Author: Ivan Vecera <c...@cera.cz>
Date: Fri Jan 13 22:38:28 2017 +0100
be2net: don't delete MAC on close on unprivileged BE3 VFs
BE3 VFs without FILTMGMT privilege are not allowed to modify its MAC,
VLAN table and UC/MC lists. So don't try to delete MAC on such VFs.
Cc: Sathya Perla <sathya.pe...@broadcom.com>
Cc: Ajit Khaparde <ajit.khapa...@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com>
Cc: Somnath Kotur <somnath.ko...@broadcom.com>
Signed-off-by: Ivan Vecera <c...@cera.cz>
Signed-off-by: David S. Miller <da...@davemloft.net>
commit fe68d8bfe59c561664aa87d827aa4b320eb08895
Author: Ivan Vecera <c...@cera.cz>
Date: Fri Jan 13 22:38:27 2017 +0100
be2net: fix status check in be_cmd_pmac_add()
Return value from be_mcc_notify_wait() contains a base completion status
together with an additional status. The base_status() macro need to be
used to access base status.
Fixes: e3a7ae2 be2net: Changing MAC Address of a VF was broken
Cc: Sathya Perla <sathya.pe...@broadcom.com>
Cc: Ajit Khaparde <ajit.khapa...@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com>
Cc: Somnath Kotur <somnath.ko...@broadcom.com>
Signed-off-by: Ivan Vecera <c...@cera.cz>
Signed-off-by: David S. Miller <da...@davemloft.net>
commit 6052cd1af86f9833b6b0b60d5d4787c4a06d65ea
Author: Ivan Vecera <c...@cera.cz>
Date: Fri Jan 6 21:59:30 2017 +0100
be2net: fix unicast list filling
The adapter->pmac_id[0] item is used for primary MAC address but
this is not true for adapter->uc_list[0] as is assumed in
be_set_uc_list(). There are N UC addresses copied first from net_device
to adapter->uc_list[1..N] and then N UC addresses from
adapter->uc_list[0..N-1] are sent to HW. So the last UC address is never
stored into HW and address 00:00:00:00;00:00 (from uc_list[0]) is used
instead.
Cc: Sathya Perla <sathya.pe...@broadcom.com>
Cc: Ajit Khaparde <ajit.khapa...@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com>
Cc: Somnath Kotur <somnath.ko...@broadcom.com>
Fixes: b717241 be2net: replace polling with sleeping in the FW completion
path
Signed-off-by: Ivan Vecera <c...@cera.cz>
Signed-off-by: David S. Miller <da...@davemloft.net>
commit 1d0f110a2c6c4bca3dbcc4b0e27f1e3dc2d44a2c
Author: Ivan Vecera <c...@cera.cz>
Date: Fri Jan 6 20:30:02 2017 +0100
be2net: fix accesses to unicast list
Commit 988d44b "be2net: Avoid redundant addition of mac address in HW"
introduced be_dev_mac_add & be_uc_mac_add helpers that incorrectly
access adapter->uc_list as an array of bytes instead of an array of
be_eth_addr. Consequently NIC is not filled with valid data so unicast
filtering is broken.
Cc: Sathya Perla <sathya.pe...@broadcom.com>
Cc: Ajit Khaparde <ajit.khapa...@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com>
Cc: Somnath Kotur <somnath.ko...@broadcom.com>
Fixes: 988d44b be2net: Avoid redundant addition of mac address in HW
Signed-off-by: Ivan Vecera <c...@cera.cz>
Signed-off-by: David S. Miller <da...@davemloft.net>
commit 096de2f83ebc8e0404c5b7e847a4abd27b9739da
Author: Sabrina Dubroca <s...@queasysnail.net>
Date: Tue Jan 3 16:26:04 2017 +0100
benet: stricter vxlan offloading check in be_features_check
When VXLAN offloading is enabled, be_features_check() tries to check if
an encapsulated packet is indeed a VXLAN packet. The check is not strict
enough, and considers any UDP-encapsulated ethernet frame with a 8-byte
tunnel header as being VXLAN. Unfortunately, both GENEVE and VXLAN-GPE
have a 8-byte header, so they get through this check.
Force the UDP destination port to be the one that has been offloaded to
hardware.
Without this, GENEVE-encapsulated packets can end up having an incorrect
checksum when both a GENEVE and a VXLAN (offloaded) tunnel are
configured.
This is similar to commit a547224dceed ("mlx4e: Do not attempt to
offload VXLAN ports that are unrecognized").
Signed-off-by: Sabrina Dubroca <s...@queasysnail.net>
Signed-off-by: David S. Miller <da...@davemloft.net>
commit 76b15923b777aa2660029629179550124c1fc40e
Author: Kalesh A P <kalesh-anakkur.pura...@broadcom.com>
Date: Tue Dec 20 10:14:30 2016 -0500
be2net: Increase skb headroom size to 256 bytes
The driver currently allocates 128 bytes of skb headroom.
This was found to be insufficient with some configurations
like Geneve tunnels, which resulted in skb head reallocations.
Increase the headroom to 256 bytes to fix this.
Signed-off-by: Kalesh A P <kalesh-anakkur.pura...@broadcom.com>
Signed-off-by: Suresh Reddy <suresh.re...@broadcom.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
commit c63d352f053a788281eb90df0a71cd3a6b2c4040
Merge: 862b3d2 bc3913a
Author: David S. Miller <da...@davemloft.net>
Date: Tue Dec 6 21:33:19 2016 -0500
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
** Affects: linux (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1666103
Title:
Pull latest be2net "net" patches to Ubunut 17.04
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1666103/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
