[Bug 1713175] Re: fsck should check before running on an encrypted LUKS partition

2017-08-26 Thread asi
One day cryptsetup will link to liblkid, adding two "use friendly" things in luksFormat - warn if it detects something on disk before destroying it - run wipefs to really destroy all the magic strings there (as Teo suggested) So valid feature request also on the cryptsetup side, with the same

[Bug 1713175] Re: fsck should check before running on an encrypted LUKS partition

2017-08-26 Thread Theodore Ts'o
So what happened is the following. There was a previous ext4 file system on the disk. You ran "cryptsetup luksFormat /dev/sda1" which wiped out the primary superblock. You then manually ran fsck.ext4 on the device. It noticed the primary superblock was non-existent, and then asked permission

[Bug 1713175] Re: fsck should check before running on an encrypted LUKS partition

2017-08-26 Thread Theodore Ts'o
Note: I think this should be a low-priority/wishlist/feature request. But I can't edit the importance.It is a valid feature request though, so I plan to treat it at that priority. If someone else thinks it's higher priority, patches are welcome. :-) ** Changed in: cryptsetup (Ubuntu)