[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2018-05-12 Thread Jeremy Bicha
** Changed in: tilix (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1718909 Title: Hyperlink feature unexpectedly removed by PCRE2 patch To mana

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2018-01-30 Thread Jeremy Bicha
This will be stuck in bionic-proposed for a bit because of the ongoing ldc transition https://launchpad.net/ubuntu/+source/tilix/1.7.5-1ubuntu1 https://people.canonical.com/~ubuntu-archive/transitions/html/ldc.html ** Changed in: tilix (Ubuntu) Status: Triaged => Fix Committed -- You re

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2018-01-22 Thread Egmont Koblinger
I truly hope so too, but that's not a guarantee for this to happen :) Anyway, it's not worth spending any more time on this nitpicking, do as you please, I'm fine with whichever. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2018-01-21 Thread Jeremy Bicha
> 0.60 is due in a mere two years, why not 0.99 or so? :) I sure hope we can drop this patch before then! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1718909 Title: Hyperlink feature unexpectedly

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2018-01-21 Thread Jeremy Bicha
** Changed in: tilix (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1718909 Title: Hyperlink feature unexpectedly removed by PCRE2 patch To manage notifi

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2018-01-21 Thread Egmont Koblinger
Indeed, nice simplification, and nice refactoring from Tilix (irrelevant: https://github.com/gnunn1/tilix/issues/1264). 0.60 is due in a mere two years, why not 0.99 or so? :) ** Bug watch added: github.com/gnunn1/tilix/issues #1264 https://github.com/gnunn1/tilix/issues/1264 -- You received

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2018-01-21 Thread Jeremy Bicha
I think we can reduce the pcre2 patch down to this one for tilix 1.7.5. I am waiting for the ongoing ldc transition in Ubuntu to progress before uploading this since tilix is currently unbuildable in bionic-proposed. ** Patch added: "pcre2-version-update.patch for tilix 1.7.5" https://bugs.lau

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2017-10-27 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: tilix (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1718909 Title: Hype

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2017-10-15 Thread Egmont Koblinger
I've tested: - VTE from git master (no PCRE patch) - Tilix from git master, with this patch only Hyperlinks work as expected. That is, if the PCRE stuff works correctly with Ubuntu's pcre-patched 0.48, which I assume you tested, then this patch is good. Thanks! -- You received this bug notifica

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2017-10-15 Thread Jeremy Bicha
Ok, here's just the patch (without the patch to a patch). ** Patch added: "pcre2-version-update.patch" https://bugs.launchpad.net/ubuntu/+source/tilix/+bug/1718909/+attachment/4972200/+files/pcre2-version-update.patch -- You received this bug notification because you are a member of Ubuntu B

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2017-10-15 Thread Egmont Koblinger
Hi, Thanks for looking into this! So this is a patch to a patch... my mind is exploding :D You'll need to revert the changes in the immediate surrounding lines of "vte.setAllowHyperlink(true)" as well. Thx! -- You received this bug notification because you are a member of Ubuntu Bugs, which i

[Bug 1718909] Re: Hyperlink feature unexpectedly removed by PCRE2 patch

2017-10-15 Thread Jeremy Bicha
I think this attached diff is what you mean but I don't have vte2.91 0.50 at the moment to try out. Ubuntu 17.10 will stay with vte2.91 0.48 (LP: #1721412) ** Patch added: "lp1718909-tilix-hyperlinks.debdiff" https://bugs.launchpad.net/ubuntu/+source/tilix/+bug/1718909/+attachment/4971635/+fil