[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2021-02-06 Thread Thorsten Glaser
As far as I see, openjdk-8 (8u275-b01-1) contains this patch, so it was backported upstream. ** Changed in: openjdk-8 (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2018-05-27 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: openjdk-9 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title:

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-20 Thread md_5
Patch was applied upstream, http://hg.openjdk.java.net/jdk/jdk/rev/d4ed3b8d166c Requesting a backport to 8/9 please. Should apply without conflicts - file hasn't been otherwise modified in either version. Thanks Michael -- You received this bug notification because you are a member of Ubuntu

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-07 Thread Ubuntu Foundations Team Bug Bot
The attachment "disabled.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray,

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-07 Thread md_5
No upstream bug yet unfortunately (OpenJDK bugtracker is restricted access as I'm sure you know). I made a mailing list thread a few days ago here http://mail.openjdk.java.net/pipermail/swing-dev/2017-November/007904.html although haven't had any feedback aside from the patch not being

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-07 Thread Daniel van Vugt
Great, thanks. Do you have a link to the upstream bug? ** Changed in: openjdk-9 (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression]

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-07 Thread md_5
Patch I submitted upstream is attached, not through yet though. ** Patch added: "disabled.diff" https://bugs.launchpad.net/ubuntu/+source/openjdk-8/+bug/1729558/+attachment/5005613/+files/disabled.diff ** Also affects: openjdk-9 (Ubuntu) Importance: Undecided Status: New -- You

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-05 Thread Daniel van Vugt
** Changed in: ubuntu-themes Status: Confirmed => Invalid ** Changed in: ubuntu-themes (Ubuntu) Status: Confirmed => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-03 Thread md_5
Ok Turns out Java has some super funky code: int componentState = context.getComponentState(); if ((componentState & SynthConstants.DISABLED) == SynthConstants.DISABLED){ if (!GTKLookAndFeel.is3()) { Color orgColor =

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-03 Thread md_5
Java looks to be using the disabled foreground colour correctly (to me, the untrained observer): gtk2_widget = gtk2_get_widget(widget_type); GtkStyle* style = gtk2_widget->style; switch (color_type) { case FOREGROUND: color = &(style->fg[state_type]);

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-03 Thread md_5
If you were testing your own install the font rendering is messed because of this bug in freetype https://bugs.launchpad.net/bugs/1722508 Downgrading to the Zesty version of freetype (as in my screenshots) fixes that issue. -- You received this bug notification because you are a member of

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-02 Thread Daniel van Vugt
I think it's more the Swing/other toolkit's unique way of rendering things than GTK. Testing a native GTK-2 app (geeqie) doesn't seem to exhibit the problem. Yes I agree with your terminology. Worth noting though even the font rendering style looks messed up in Netbeans. From what I recall in

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-02 Thread md_5
Java isn’t hardcoding them, it’s pulling them from GTK. There is the possibility that it’s pulling the wrong type of element colour (sorry not sure about terminology). I guess the test is to find a GTK 2 app with disabled menu elements that previously had a white menu which is now black wih this

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-02 Thread Daniel van Vugt
** Tags added: visual-quality -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements To manage

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-02 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: openjdk-8 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558 Title:

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-02 Thread Daniel van Vugt
** Changed in: ubuntu-themes Importance: Undecided => Low ** Changed in: openjdk-8 (Ubuntu) Importance: Undecided => Low ** Changed in: ubuntu-themes (Ubuntu) Importance: Undecided => Low ** Changed in: ubuntu-themes Status: New => Confirmed -- You received this bug

[Bug 1729558] Re: [regression] In Java apps like Netbeans, dark menu bars don't look good for disabled elements

2017-11-02 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: ubuntu-themes (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729558