[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-14 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 4.0.0-1ubuntu5 --- libvirt (4.0.0-1ubuntu5) bionic; urgency=medium * run dnsmasq as libvirt-dnsmasq (LP: #1743718) - d/libvirt-daemon-system.postinst: add libvirt-dnsmasq user and group - d/libvirt-daemon-system.postrm: remove

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-08 Thread ChristianEhrhardt
** Tags added: 4.0.0-1ubuntu5 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752361 Title: virt-aa-helper should resolve symlinks and use only resolved paths To manage notifications about this bug

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-07 Thread ChristianEhrhardt
Pushed after slight changes due to upstream feedback. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752361 Title: virt-aa-helper should resolve symlinks and use only resolved paths To manage

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-02 Thread ChristianEhrhardt
Patch up for review - https://www.redhat.com/archives/libvir- list/2018-March/msg00022.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752361 Title: virt-aa-helper should resolve symlinks and

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-01 Thread ChristianEhrhardt
Implemented the walking code. Also adding this as another case (that can't be translated / accessed): Generates: "/run/symlinkdisk-doesexist" rwk,

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-01 Thread ChristianEhrhardt
virt-aa-helper right now: "/run/symlinkdisk-doesexist" rwk, "/var/run/symlinkdisk-doesnotexist" rwk, "/run/symlinksocket-doesexist" rw, "/var/run/symlinksocket-doesnotexist" rw, "/var/run/pathdoesnotexist/symlinksocket" rw, "/run/symlinknet-doesexist" rw,

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-01 Thread ChristianEhrhardt
Extended Testcase for existing and non-existing Files as well as non existing paths (can't be dereferenced). symlink-test deadbeef-dead-beef-dead-beefdeadbeef 1048576 1 hvm

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-01 Thread ChristianEhrhardt
Actually realpath can resolve non existing file, as long as it is on existing paths $ ll /var/run/symlinkdisk /var/run/foobar/symlinkdisk ls: cannot access '/var/run/symlinkdisk': No such file or directory ls: cannot access '/var/run/foobar/symlinkdisk': No such file or directory $ realpath

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-01 Thread ChristianEhrhardt
Check why it doesn't $ libtool --mode=execute gdb ./src/virt-aa-helper (gdb) b vah_add_path (gdb) run -u libvirt-deadbeef-dead-beef-dead-beefdeadbeef -r --dryrun < /tmp/symlink-test.xml [...] Breakpoint 1, vah_add_path (buf=0x7fffd500, path=0x5578b000 "/var/run/symlinkdisk",

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-01 Thread ChristianEhrhardt
Actually the call to realpath should already do that (but it doesn't) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1752361 Title: virt-aa-helper should resolve symlinks and use only resolved paths

[Bug 1752361] Re: virt-aa-helper should resolve symlinks and use only resolved paths

2018-03-01 Thread ChristianEhrhardt
Test notes: test file: symlink-test deadbeef-dead-beef-dead-beefdeadbeef 1048576 1 hvm