[Bug 1753938] Re: slirp: domainname and classic stateless for DHCP

2018-04-09 Thread ChristianEhrhardt
Ok Benjamin, I filed bug 1762315 for a) on change #1 I'm rather sure it is a good change since it is already tested by me and was in Bionic a while without complaints. Never the less I need an FFE given the time. So lets see if we run into any trouble there being so late. If you get to upstream

[Bug 1753938] Re: slirp: domainname and classic stateless for DHCP

2018-04-07 Thread Benjamin Drung
Having #1 without #2 is important for me (option a). Patch #2 is nice to have, but patch #1 is required for making testing live-boot with QEMU working. Without the domainname support the boot will fail (at least if you have custom boot scripts that operate on the FQDN). -- You received this bug

[Bug 1753938] Re: slirp: domainname and classic stateless for DHCP

2018-04-03 Thread ChristianEhrhardt
It isn't really upstream yet, Samuel usually asks for pulls on the start of a version. fd06527b was the last for 2.12 so I'd assume it only gets "really upstream" around mid-May. Of course under the current conditions we can assume this patch will make it. The question is now your urgency: a)

[Bug 1753938] Re: slirp: domainname and classic stateless for DHCP

2018-03-24 Thread Benjamin Drung
Sorry for missing the IRC ping. I agree to drop the classless static routes support (patch 2) since this needs bigger changes than expected. So let's get this done upstream. The domainname option (patch 1) is uncontroversial and small. It was review and Samuel Thibault and he applied it to his

[Bug 1753938] Re: slirp: domainname and classic stateless for DHCP

2018-03-22 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.11+dfsg-1ubuntu5 --- qemu (1:2.11+dfsg-1ubuntu5) bionic; urgency=medium * Revert the slirp changes of 1:2.11+dfsg-1ubuntu3 until they are upstream accepted to be better long term maintainable (LP: #1753938) -- Christian Ehrhardt

[Bug 1753938] Re: slirp: domainname and classic stateless for DHCP

2018-03-22 Thread ChristianEhrhardt
Sadly since this can't get upstream in time I'm (for now) forced to remove it. It is just that sort of non-upstream Delta that might become a long term maintenance pain e.g. as discussed upstream "... Sadly, once the QMP is released, we don't want to be changing it ...". That combined with the

[Bug 1753938] Re: slirp: domainname and classic stateless for DHCP

2018-03-20 Thread ChristianEhrhardt
there was a reply yesterday which looked more like a nack still :-/ I pinged Benjamin on IRC. But as deadlines are closing and this is a post Feature Freeze addition which might end up super hard to maintain I hope you get it accepted so that we can update it to what is upstream. FYI: I

[Bug 1753938] Re: slirp: domainname and classic stateless for DHCP

2018-03-14 Thread Benjamin Drung
I agree on point 3. I incorporated the feedback on 0002-slirp-Add-classless-static-routes- support-to-DHCP-se.patch and posted patch v3: http://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg04437.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1753938] Re: slirp: domainname and classic stateless for DHCP

2018-03-07 Thread ChristianEhrhardt
@Benjamin - please comment what you think and we will go from there together -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1753938 Title: slirp: domainname and classic stateless for DHCP To manage