[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

This bug was fixed in the package lttng-modules - 2.9.0-1ubuntu3.2 --- lttng-modules (2.9.0-1ubuntu3.2) artful; urgency=medium * Fix builds for 4.13.0-38 kernel (LP: #1756240) - Update definition of kvm_mmio() to match the new kernel -- Khalid Elmously

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

This bug was fixed in the package lttng-modules - 2.8.0-1ubuntu1~16.04.5 --- lttng-modules (2.8.0-1ubuntu1~16.04.5) xenial; urgency=medium * Fix builds for 4.13.0-38 kernel (LP: #1756240) - Update definition of kvm_mmio() to match the new kernel -- Khalid Elmously

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Hello SRU team, Verification appears to be complete for this fix and the holding period has ended. Could you please promote this to -updates? Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Tested on Xenial + 4.13 kernel, works as expected. Thanks ** Tags removed: verification-needed verification-needed-xenial ** Tags added: verification-done verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Hello Po-Hsu, or anyone else affected, Accepted lttng-modules into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lttng- modules/2.8.0-1ubuntu1~16.04.5 in a few hours, and then in the -proposed repository. Please help us by testing this new

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

The fix works as expected, thanks. ** Tags removed: verification-needed verification-needed-artful ** Tags added: verification-done verification-done-artful -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Fix has been merged into mainline lttng as well: git://git.lttng.org/lttng-modules.git be02509026192106196fe6dfd9df0db739804045 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1756240 Title: Unable

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Hello Po-Hsu, or anyone else affected, Accepted lttng-modules into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lttng- modules/2.9.0-1ubuntu3.2 in a few hours, and then in the -proposed repository. Please help us by testing this new

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

This bug was fixed in the package lttng-modules - 2.10.5-1ubuntu1 --- lttng-modules (2.10.5-1ubuntu1) bionic; urgency=medium * Fix builds for 4.13.0-38 kernel (LP: #1756240) - Update definition of kvm_mmio() to match the new kernel -- Khalid Elmously

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

lgtm! sponsored to bionic ** Changed in: lttng-modules (Ubuntu Bionic) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1756240 Title: Unable to build lttng-module

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Fix for bionic - lots of thanks to @tyhicks for the explanation and help ** Patch added: "fix2-bionic.debdiff" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1756240/+attachment/5088302/+files/fix2-bionic.debdiff -- You received this bug notification because you are a member of Ubuntu

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

The attachment "proposed-fix" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray,

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

** Also affects: lttng-modules (Ubuntu) Importance: Undecided Status: New ** Changed in: lttng-modules (Ubuntu Xenial) Status: New => In Progress ** Changed in: lttng-modules (Ubuntu Artful) Status: New => In Progress ** Changed in: lttng-modules (Ubuntu Xenial)

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

@Khaled these debdiffs look good enough for me to sponsor. I made one superficial change by removing the "## " prefix from the patch tags lines. However, there were two important changes required for the Xenial debdiff. The version wasn't correct (I changed it to 2.8.0-1ubuntu1~16.04.5 instead of

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

@Khaled after giving it a little more thought, I think these changes might be needed in bionic in the situation that an artful user is upgrading to bionic or when a xenial hwe user is upgrading to bionic. I think that if the lttng-modules-dkms binary package is upgraded to the bionic package

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Adding equivalent fix for xenial-hwe ** Patch added: "fix2-xenial.debdiff" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1756240/+attachment/5087192/+files/fix2-xenial.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Updated debdiff to fix a problem with macro arguments. Same testing as before. ** Patch added: "fix2-artful.debdiff" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1756240/+attachment/5087155/+files/fix2-artful.debdiff -- You received this bug notification because you are a member of

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

** Description changed: + [Impact] + + * The 4.13.0-38 artful kernel included a change (backported from 4.15) + that modifies the definition of kvm_mmio(). This breaks the lttng- + modules-dkms package because it is using the old (<4.15) definition. + + * lttng-modules-dkms already has a list

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

4.13.0-38 introduced a new definition of kvm_mmio() that is backported from 4.15. There's already a list of excepted kernel versions for which the new (4.15) definition should be used. I added ubuntu 4.13.0-38-and- later kernels to that list. Tested by first successfully building

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1756240 Title: Unable to build lttng-module with Artful kernel To manage notifications about this bug go to:

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

** Changed in: linux (Ubuntu) Assignee: (unassigned) => Khaled El Mously (kmously) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1756240 Title: Unable to build lttng-module with Artful kernel

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Can we fix this by modifying the code in lttng-modules-dkms ? Something like "proposed-patch-1.txt" ** Attachment added: "proposed-fix" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1756240/+attachment/5085503/+files/proposed-patch-1.txt -- You received this bug notification because

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

** Changed in: linux (Ubuntu) Assignee: Colin Ian King (colin-king) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1756240 Title: Unable to build lttng-module with Artful kernel

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

This build failure occurs because of the following artful commit: commit 356852284931cda6749c41f77acefcb13bd534fe Author: Wanpeng Li Date: Thu Jan 4 01:57:52 2018 -0500 KVM: Fix stack-out-of-bounds read in write_mmio CVE-2017-17741 This redefines the kvm_mmio

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

** Changed in: linux (Ubuntu) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1756240 Title: Unable to build lttng-module with Artful kernel To manage

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

This issue can be reproduced with Xenial HWE kernel as well (4.13) 03/20 05:22:06 DEBUG| utils:0153| [stdout] Building initial module for 4.15.0-13-lowlatency 03/20 05:22:14 DEBUG| utils:0153| [stdout] Error! Bad return status for module build on kernel: 4.15.0-13-lowlatency (x86_64) 03/20

[Bug 1756240] Re: Unable to build lttng-module with Artful kernel

Sorry in comment #3 it's the Xenial Edge kernel (4.15), this is the Xenial HWE one: 03/16 01:12:07 DEBUG| utils:0153| [stdout] Error! Bad return status for module build on kernel: 4.13.0-38-lowlatency (x86_64) 03/16 01:12:07 DEBUG| utils:0153| [stdout] Consult