[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-10 Thread Bryce Harrington
Thanks Alvin, those debdiffs look good, I'll try and work on getting merge proposals put together for them today. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1773324 Title: rabbitmqadmin shows

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-10 Thread Robie Basak
** Tags added: server-next -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1773324 Title: rabbitmqadmin shows %%VSN%% as version To manage notifications about this bug go to:

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-09 Thread Alvin Joseph Tang
I created a separate debdiff for Eoan and Disco since it uses rabbitmq- server 3.7.8 already. I was able to build and test it on both Disco and Eoan. ** Patch added: "1-1.0-1ubuntu3.debdiff"

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-09 Thread Alvin Joseph Tang
Re-uploading patch v3, I just corrected the date in last updated. ** Patch added: "patch v3" https://bugs.launchpad.net/ubuntu/+source/rabbitmq-server/+bug/1773324/+attachment/5269746/+files/3-1.0-1ubuntu2.debdiff -- You received this bug notification because you are a member of Ubuntu

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-08 Thread Alvin Joseph Tang
Thanks for the clarification Bryce! I updated the patch attached and tested it works also in Cosmic. Disco uses version 3.7.8 and is it correct I need to create a new patch for Disco since the documentation is for a different version? ** Patch added: "patch v3"

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-07 Thread Bryce Harrington
Hi Alvin, Looking really good. Sorry for the confusion with the patch name, rather than 'fix-3.6.10.patch' I think you should call it, literally, 'fix-version- string.patch' since it is fixing the version string. You can probably omit the line "This patch header follows DEP-3:

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-06 Thread Alvin Joseph Tang
Thanks for the comments Bryce! I attached here the updated patch based on your comments. Do I also build and test for other releases tagged in this bug? ** Patch added: "patch version 2"

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-05 Thread Ubuntu Foundations Team Bug Bot
The attachment "debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-05 Thread Ubuntu Foundations Team Bug Bot
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1773324 Title: rabbitmqadmin shows %%VSN%% as version To manage notifications about this bug go to:

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-05 Thread Bryce Harrington
Hi Alvin, Good progress! And thanks for documenting the patch. I would suggest a few changes: * Instead of calling it 'mypatch.diff' give it a descriptive name, like 'fix-version-string.patch' * In the patch metadata, make sure to replace all the stuff in . For example, instead of:

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-05 Thread Alvin Joseph Tang
Thanks Bryce and Andreas. I have this debdiff for Bionic. I built this using pbuilder-dist and it builds successfully. I also installed and tested and it works as intended. Please let me know your thoughts. ** Patch added: "debdiff"

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-04 Thread Andreas Hasenack
See where the $(PROJECT_VERSION) makefile variable is defined, as that is used in the sed to replace the %string%, and go from there. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1773324

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-04 Thread Andreas Hasenack
See where the $(PROJECT_VERSION) makefile variable is defined, as that is used in the sed to replace the %string%, and go from there. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1773324 Title:

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-03 Thread Bryce Harrington
Hi Alvin, thanks for giving this issue some attention. Often, projects will have some infrastructure in place for tracking their version. I would suggest start by reviewing their release directions, to see if they've documented where they set the number at release. Often there is a

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-06-03 Thread Alvin Joseph Tang
Hi! I'd like to work on this bug. I am targeting fix for bionic. This is my first bug and I'll give it my best. I've already created a package and able to change the version message using sed as mentioned in previous comment but the string is hard coded. How do I get the correct version of the

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-01-09 Thread Andreas Hasenack
Still happens with disco: root@disco-rabbit:~# rabbitmqadmin --version rabbitmqadmin %%VSN%% root@disco-rabbit:~# dpkg-query -W rabbitmq-server rabbitmq-server 3.7.8-4ubuntu2 -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report.

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2019-01-09 Thread Andreas Hasenack
Still happens with disco: root@disco-rabbit:~# rabbitmqadmin --version rabbitmqadmin %%VSN%% root@disco-rabbit:~# dpkg-query -W rabbitmq-server rabbitmq-server 3.7.8-4ubuntu2 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2018-06-27 Thread Andreas Hasenack
All that's needed is a sed pass on deps/rabbitmq_management/bin/rabbitmqadmin, which has: VERSION = '%%VSN%%' Its makefile seems to be ready for that in the prepare-dist target: prepare-dist:: $(verbose) sed 's/%%VSN%%/$(PROJECT_VERSION)/' bin/rabbitmqadmin \ >

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2018-06-27 Thread Andreas Hasenack
All that's needed is a sed pass on deps/rabbitmq_management/bin/rabbitmqadmin, which has: VERSION = '%%VSN%%' Its makefile seems to be ready for that in the prepare-dist target: prepare-dist:: $(verbose) sed 's/%%VSN%%/$(PROJECT_VERSION)/' bin/rabbitmqadmin \ >

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2018-05-29 Thread Andreas Hasenack
Confirmed in artful, bionic and cosmic. ** Changed in: rabbitmq-server (Ubuntu) Status: New => Triaged ** Changed in: rabbitmq-server (Ubuntu) Importance: Undecided => Medium ** Tags added: bitesize -- You received this bug notification because you are a member of Ubuntu Server,

[Bug 1773324] Re: rabbitmqadmin shows %%VSN%% as version

2018-05-29 Thread Andreas Hasenack
Confirmed in artful, bionic and cosmic. ** Changed in: rabbitmq-server (Ubuntu) Status: New => Triaged ** Changed in: rabbitmq-server (Ubuntu) Importance: Undecided => Medium ** Tags added: bitesize -- You received this bug notification because you are a member of Ubuntu Bugs, which