[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-20 Thread Launchpad Bug Tracker
This bug was fixed in the package samba - 2:4.7.6+dfsg~ubuntu-0ubuntu2.4 --- samba (2:4.7.6+dfsg~ubuntu-0ubuntu2.4) bionic; urgency=medium * d/p/fix-rmdir.patch: fix the patch to not apply with offset, which previously made it change the wrong, almost identical, function.

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-14 Thread Rolando Gorgs
I added proposed repo again and installed samba version 2:4.7.6+dfsg ~ubuntu-0ubuntu2.4 from proposed and I'm happy to say, that this version fixed the bug. I tested Nemo, Nautilus and Thunar and all of them are able to delete all kind of directories within Samba shares now. Thanks a lot for your

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-13 Thread Brian Murray
Hello Rolando, or anyone else affected, Accepted samba into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/samba/2:4.7.6+dfsg ~ubuntu-0ubuntu2.4 in a few hours, and then in the -proposed repository. Please help us by testing this new package.

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-09 Thread Andreas Hasenack
New package uploaded, waiting for the approval of the SRU team. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To manage

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-09 Thread Andreas Hasenack
New package uploaded, waiting for the approval of the SRU team. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To manage

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-09 Thread  Christian Ehrhardt 
** Description changed: [Impact] The samba client doesn't check the result of rmdir, returning success when the directory is not empty. This results in clients reporting successful directory removal when in fact the directory was not removed. This bug affects anything that uses

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-08 Thread Rolando Gorgs
No problem. Thank you for your time! Will review the new patch when its out. :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-08 Thread Andreas Hasenack
I'm confident in the fix for bionic now: smb: \> rmdir testdir NT_STATUS_DIRECTORY_NOT_EMPTY removing remote directory file \testdir smb: \> quit root@bionic-samba-rmdir:~# It's in review. Apologies for the mistake. ** Description changed: [Impact] The samba client doesn't check the

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-08 Thread Andreas Hasenack
I'm confident in the fix for bionic now: smb: \> rmdir testdir NT_STATUS_DIRECTORY_NOT_EMPTY removing remote directory file \testdir smb: \> quit root@bionic-samba-rmdir:~# It's in review. Apologies for the mistake. ** Description changed: [Impact] The samba client doesn't check the

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-08 Thread Andreas Hasenack
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/358520 -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-08 Thread Andreas Hasenack
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/358520 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-08 Thread Andreas Hasenack
Found the issue. I made a silly mistake while applying the patch to the 4.7 code tree. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-08 Thread Andreas Hasenack
Found the issue. I made a silly mistake while applying the patch to the 4.7 code tree. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-07 Thread Andreas Hasenack
4.7.11, latest upstream, still affected. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To manage notifications about this

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-07 Thread Andreas Hasenack
4.7.11, latest upstream, still affected. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To manage notifications about this bug go

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-07 Thread Andreas Hasenack
Confirmed not working in bionic, thanks for the verification. Looks like the upstream patch is not enough for the case of samba 4.7. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1795772

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-07 Thread Andreas Hasenack
Confirmed not working in bionic, thanks for the verification. Looks like the upstream patch is not enough for the case of samba 4.7. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title:

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-07 Thread Andreas Hasenack
Yes, it's a client-side fix. I'm taking a look at what is going on in bionic. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-07 Thread Andreas Hasenack
Yes, it's a client-side fix. I'm taking a look at what is going on in bionic. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-07 Thread Rolando Gorgs
Thunar (1.6.15) is also affected now. Without the fix Thunar was able to delete empty and non-empty directories. Now it cannot delete ANY directory too. :( -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-07 Thread Rolando Gorgs
** Changed in: samba (Ubuntu Bionic) Status: Fix Committed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-07 Thread Rolando Gorgs
Ok, I did further testing and the fix made things even worse! (I used two - apart from this new samba version - identical VMs to verify the behavior.) Before the fix I was not able to delete non-empty directories. With installed fix I'm not able to delete ANY directory - regardless of content!

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-06 Thread Rolando Gorgs
I also rebooted my client but the problem persists. I searched Synaptic for "samba" and all samba packages are version 2:4.7.6+dfsg~ubuntu- 0ubuntu2.3 now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-06 Thread Rolando Gorgs
I added proposed repo and installed samba version 2:4.7.6+dfsg~ubuntu- 0ubuntu2.3 from proposed, but to be honest I don't see any difference in Nemo. I tested with Nemo 3.8.6 to delete a non empty directory within a smb share before and after the update and both failed silently. Just to be sure:

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-06 Thread Rolando Gorgs
** Tags removed: verification-needed-bionic ** Tags added: verification-failed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-11-06 Thread Brian Murray
Hello Rolando, or anyone else affected, Accepted samba into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/samba/2:4.7.6+dfsg ~ubuntu-0ubuntu2.3 in a few hours, and then in the -proposed repository. Please help us by testing this new package.

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-29 Thread Andreas Hasenack
My previous upload was rejected because I didn't prefix the bug number in debian/changelog with a "#". I uploaded again, and it's in the bionic unapproved queue again (see https://launchpad.net/ubuntu/bionic/+queue?queue_state=1_text=samba) -- You received this bug notification because you are a

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-29 Thread Andreas Hasenack
My previous upload was rejected because I didn't prefix the bug number in debian/changelog with a "#". I uploaded again, and it's in the bionic unapproved queue again (see https://launchpad.net/ubuntu/bionic/+queue?queue_state=1_text=samba) -- You received this bug notification because you are a

Re: [Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-28 Thread Vonschutter
I am on traveling foot... so no chance to test with latest ubuntu packages... On Fri, Oct 26, 2018, 23:25 Rolando Gorgs <1795...@bugs.launchpad.net> wrote: > Any good news? :-) > > -- > You received this bug notification because you are subscribed to a > duplicate bug report (1773634). >

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-26 Thread Rolando Gorgs
Any good news? :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To manage notifications about this bug go to:

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-15 Thread Andreas Hasenack
Uploaded to bionic unapproved, waiting for SRU team's approval. -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To manage

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-15 Thread Andreas Hasenack
Uploaded to bionic unapproved, waiting for SRU team's approval. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To manage

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-11 Thread Rolando Gorgs
Hello Andreas, this answer makes me calm me down. I thought for a second bionic has been forgotten. And yes, this bug is indeed very very annoying. I'm surprised that I'm the first one who reports this. Probably most affected users don't even noticed yet that they are constantly leaving a mess

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-11 Thread Andreas Hasenack
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/356614 -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-11 Thread Andreas Hasenack
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/356614 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-11 Thread Andreas Hasenack
** Changed in: samba (Ubuntu Bionic) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Server, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-11 Thread Andreas Hasenack
** Changed in: samba (Ubuntu Bionic) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty samba directory fails silently To

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-11 Thread Andreas Hasenack
Hi Rolando. I totally understand your eagerness for this fix, and a bionic update will follow. We just needed to make sure that the current development release of Ubuntu had the fix before starting to address the stable releases, specially since today is the Final Freeze day for Ubuntu 18.10.

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-11 Thread Andreas Hasenack
Hi Rolando. I totally understand your eagerness for this fix, and a bionic update will follow. We just needed to make sure that the current development release of Ubuntu had the fix before starting to address the stable releases, specially since today is the Final Freeze day for Ubuntu 18.10.

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-11 Thread Rolando Gorgs
Thanks for your work! Progress looks promising, but I run samba 2:4.7.6+dfsg~ubuntu-0ubuntu2.2 on bionic. Would you please push your fix also to this package so that LTS users benefit from a working delete function. Please excuse my impatientness. I'm not familiar with the process of bug fixing at

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-11 Thread Launchpad Bug Tracker
This bug was fixed in the package samba - 2:4.8.4+dfsg-2ubuntu2 --- samba (2:4.8.4+dfsg-2ubuntu2) cosmic; urgency=high [ Karl Stenerud ] * d/p/fix-rmdir.patch: Fix to make the samba client library report directory-not-empty errors (LP: #1795772) -- Andreas Hasenack Tue,

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-09 Thread Andreas Hasenack
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/356356 ** Changed in: samba (Ubuntu) Assignee: Karl Stenerud (kstenerud) => Andreas Hasenack (ahasenack) ** Changed in: samba (Ubuntu Bionic) Assignee: Karl Stenerud (kstenerud)

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-09 Thread Andreas Hasenack
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/356356 ** Changed in: samba (Ubuntu) Assignee: Karl Stenerud (kstenerud) => Andreas Hasenack (ahasenack) ** Changed in: samba (Ubuntu Bionic) Assignee: Karl Stenerud (kstenerud)

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Karl Stenerud
** Description changed: + samba + + [Impact] + + The samba client doesn't check the result of rmdir, returning success + when the directory is not empty. This results in clients reporting + successful directory removal when in fact the directory was not removed. + + This bug affects anything

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: samba (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title:

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Karl Stenerud
** Changed in: samba (Ubuntu) Assignee: (unassigned) => Karl Stenerud (kstenerud) ** Changed in: samba (Ubuntu Bionic) Assignee: (unassigned) => Karl Stenerud (kstenerud) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: samba (Ubuntu Bionic) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Karl Stenerud
** This bug is no longer a duplicate of bug 1777601 can not delete a non-empty directory on remote NAS smb share -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on non-empty

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Karl Stenerud
** This bug has been marked a duplicate of bug 1777601 can not delete a non-empty directory on remote NAS smb share -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1795772 Title: rmdir on

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Andreas Hasenack
>From my testing, looks like bionic and cosmic are affected. Xenial returns a proper error: smb: \> rmdir somedir NT_STATUS_DIRECTORY_NOT_EMPTY removing remote directory file \somedir ** Also affects: samba (Ubuntu Bionic) Importance: Undecided Status: New ** Bug watch added: Samba

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Andreas Hasenack
>From my testing, looks like bionic and cosmic are affected. Xenial returns a proper error: smb: \> rmdir somedir NT_STATUS_DIRECTORY_NOT_EMPTY removing remote directory file \somedir ** Also affects: samba (Ubuntu Bionic) Importance: Undecided Status: New ** Bug watch added: Samba

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Andreas Hasenack
Thanks for this detailed bug report. While I gear up to reproduce it, could you just let us know in which ubuntu release and samba version you experienced this? The upstream bug report has fixes for 4.8.x and 4.9.x. Currently only Cosmic 18.10 has 4.8.x, and we don't ship 4.9.x yet. -- You

[Bug 1795772] Re: rmdir on non-empty samba directory fails silently

2018-10-03 Thread Andreas Hasenack
Thanks for this detailed bug report. While I gear up to reproduce it, could you just let us know in which ubuntu release and samba version you experienced this? The upstream bug report has fixes for 4.8.x and 4.9.x. Currently only Cosmic 18.10 has 4.8.x, and we don't ship 4.9.x yet. -- You