This bug was fixed in the package golang-github-docker-docker-
credential-helpers - 0.5.0-2ubuntu0.1
---
golang-github-docker-docker-credential-helpers (0.5.0-2ubuntu0.1) bionic;
urgency=medium
* d/p/free_unsafe_pointer_fix.patch: fix invalid free call when running docker
I tested this in a bionic lxc container with the following steps:
# install affected golang-docker-credential-helpers version 0.5.0-2
apt update && apt install -y docker.io golang-docker-credential-helpers
# prepare Dockerfile and run build
mkdir /tmp/dummy-docker-build
cd /tmp/dummy-docker-build
Ah, I see now - it actually ships a binary. Thank you for confirming!
** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu Bionic)
Status: In Progress => Fix Committed
** Tags added: verification-needed verification-needed-bionic
--
You received this bug notification
Hi Robie,
This will not need a subsequent rebuild of other packages here since it
is the binary package (and not the -dev one) which is triggering the
reported issue.
However, may the bogus call to free manifest in any other form for any
other binary package building against the golang -dev
Hi Robie,
I verified that it is not necessary to rebuild other packages in this
case. Just updating golang-docker-credential-
helpers_0.5.0-2ubuntu0.1_amd64.deb inside a VM is enough to fix the
issue and have the "docker build" stop manifesting the error. But maybe
Athos would like to
Won't this need a subsequent rebuild of other packages for this change
to have any effect? Have you tested the outcome against your PPA?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1813003
Title:
I verified that the patch is applied in Impish.
** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu)
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Thanks for the review and upload, Sergio!
** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu Bionic)
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Thanks for addressing the comments, Athos.
Uploaded:
$ dput
golang-github-docker-docker-credential-helpers_0.5.0-2ubuntu0.1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg:
Thanks for the review, Sergio.
I addressed your comments and pushed the proposed fix to the following
PPA:
https://launchpad.net/~athos-ribeiro/+archive/ubuntu/lp-1813003-docker-
credential-helpers/+packages
** Patch added: "1-0.5.0-2ubuntu0.1.debdiff"
Thanks for the patch and for working on this bug, Athos.
A few comments:
- Since this is an SRU, the version will be a bit different than in a
normal upload to a development version. In this particular case, the
version should be:
0.5.0-2ubuntu0.1
- The "Origin:" DEP-3 header should contain
This is a debdiff to apply the fix proposed in
https://github.com/docker/docker-credential-helpers/pull/29 to bionic.
** Description changed:
+ [Impact]
+
+ The bug results in an error being printed on the user screen when
+ running docker builds.
+
+ While the error will not cause the build
** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu Bionic)
Assignee: (unassigned) => Athos Ribeiro (athos-ribeiro)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1813003
Title:
It works for me.
I confirm that error is not displayed anymore if package 'pass' is installed.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1813003
Title:
Invalid free while running docker build
(For anyone who comes across this one of the upstream issues
(https://github.com/docker/docker-credential-
helpers/issues/103#issuecomment-576854271 ) mentions the problem goes
away if `pass` package is also installed and this seemed to make the
issue disappear for me too)
** Bug watch added:
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu Bionic)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Also affects: golang-github-docker-docker-credential-helpers (Ubuntu Bionic)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1813003
Title:
Invalid free
What does the packag "golang-github-docker-docker-credential-helpers" do?
->It stores username and password used for `docker login` to "docker
registries" in a "safer way".
When does the bug manifest/occur?
->The bug occurs for instance when running `docker build`.
How to get rid of this bug
Hello, we are also affected by this bug.
dpkg -l | grep docker
ii docker-compose 1.17.1-2
all Punctual, lightweight development environments using Docker
ii docker.io 18.09.7-0ubuntu1~18.04.3
** Tags added: bionic
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1813003
Title:
Invalid free while running docker build
To manage notifications about this bug go to:
diff --git a/secretservice/secretservice_linux.go
b/secretservice/secretservice_linux.go
index 95a1310..383b0c2 100644
--- a/secretservice/secretservice_linux.go
+++ b/secretservice/secretservice_linux.go
@@ -93,7 +93,7 @@ func (h Secretservice) List() (map[string]string, error) {
var
I agree with @anatoly.borodin - in fact the commit
https://github.com/docker/docker-credential-
helpers/commit/73e5f5dbfea31ee3b8ebbf189785fa69731c and pull request
https://github.com/docker/docker-credential-
helpers/pull/29/commits/79f93e5e69abc2ead458d19f4577b64b7e35c504 are the
same fix.
A fix could be ported, or a package could be upgraded to v0.6.2. See
https://github.com/docker/docker-credential-
helpers/pull/29/commits/79f93e5e69abc2ead458d19f4577b64b7e35c504
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: golang-github-docker-docker-credential-helpers (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
24 matches
Mail list logo
