[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-04-09 Thread Christian Ehrhardt 
Arrr, this issue keeps on giving. Thanks webflow for the hint, I'll have to look into that in a new bug - I filed bug 1823872 for that. Please consider subscribing and chiming in there. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-04-09 Thread Webflow
Hi, just wanted to add: This bug also crashes unattended-upgrade and thus prevents security updates on 18.04: root@mailin1:~# unattended-upgrade Traceback (most recent call last): File "/usr/bin/unattended-upgrade", line 1998, in sys.exit(main(options)) File "/usr/bin/unattended-upgrade"

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-27 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.12+dfsg-3ubuntu8.6 --- qemu (1:2.12+dfsg-3ubuntu8.6) cosmic-security; urgency=medium [ Marc Deslauriers ] * SECURITY UPDATE: multiple pvrdma security issues - debian/patches/split_pvrdma.patch: split PVRDMA from RDMA in config

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-27 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.11+dfsg-1ubuntu7.12 --- qemu (1:2.11+dfsg-1ubuntu7.12) bionic-security; urgency=medium [ Marc Deslauriers ] * SECURITY UPDATE: TOCTTOU in MTP - debian/patches/CVE-2018-16872.patch: use O_NOFOLLOW and O_CLOEXEC in hw/usb/dev-mt

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-27 Thread Christian Ehrhardt 
MPs are reviewed and this most likely goes in bundled with a security updated to not kill all that is in the SRU pipe already. ** Changed in: qemu (Ubuntu Bionic) Status: New => Triaged ** Changed in: qemu (Ubuntu Cosmic) Status: New => Triaged -- You received this bug notificatio

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-25 Thread Christian Ehrhardt 
** Description changed: + [Impact] + + * The feature of qemu-guest agent to run freeze hooks is used rarely but +where used important to get data consistency right. Due to a path error +when packaging the script (from upstream) it is currently not working +at all (it calls a non e

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-25 Thread Christian Ehrhardt 
I have prepared a PPA and MPs for this to become an SRU. I'm not yet sure if I'll upload this on its own, but OTOH there is an unaccepted SRU still waiting so it could be bundled for Bionic. Adding SRU Template now ... -- You received this bug notification because you are a member of Ubuntu Bug

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-25 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~ubuntu-virt/ubuntu/+source/qemu/+git/qemu/+merge/365022 ** Merge proposal linked: https://code.launchpad.net/~ubuntu-virt/ubuntu/+source/qemu/+git/qemu/+merge/365023 -- You received this bug notification because you are a member of Ub

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-22 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:3.1+dfsg-2ubuntu3 --- qemu (1:3.1+dfsg-2ubuntu3) disco; urgency=medium * qemu-guest-agent: fix path of fsfreeze-hook (LP: #1820291) - d/qemu-guest-agent.install: use correct path for fsfreeze-hook - d/qemu-guest-agent.pre{rm|inst}/.

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-21 Thread Christian Ehrhardt 
Re-Review and tests are complete. I have opened a PR in Debian as well to fix my mistake in all places where it is affecting users :-/ => https://salsa.debian.org/qemu-team/qemu/merge_requests/5 I'll give Michael a chance to reply so that we can try to handle it the "same way" in Debian/Ubuntu. B

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-20 Thread Christian Ehrhardt 
Yes it is Pierre, but that is the only way to do it right :-/ Review was great to make it more resilient, testing the new version (one more testcase) ... - no modification -> move silently (ok) - modified old file -> move with modification and place dpkg-new file (ok) - old file removed -> old di

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-19 Thread Pierre Gaxatte
Thank you Christian! It looks good to me. It seems like a lot of trouble to move a file in the place of the directory with the same name! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1820291 Title:

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-19 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/364760 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1820291 Title: fsfreeze-hook script is mis

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-19 Thread Christian Ehrhardt 
Test cases: - no modification -> move silently (ok) - modified old file -> move with modification (ok) - old file removed -> old dir and non-existing file untouched, ...dpkg-new is placed (ok) Ok that should work, I'll pass that (The Disco variant) to Team review. -- You received this bug notif

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
I went a bit back and forth on this, but after further checks I realized that due to the code expecting "fsfreeze-hook.d" to be below the path where the main script is located this has to be fixed by moving the script around. Otherwise we'd also have to change the code of the initial fsfreeze-hoo

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
Chances are that affected people have fixed it up in /etc/default/qemu-guest-agent just as you have or in latter releases modified (the defaults file was dropped) /lib/systemd/system/qemu-guest-agent.service Now exactly those (few) people that would have fixed the path up that way would be bro

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
Bionic to Disco are affected - adding tasks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1820291 Title: fsfreeze-hook script is misplaced in qemu-guest-agent To manage notifications about this bug

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
It turns out the renaming is unnecessarily complex in this case for the reasons I outlined before. Furthermore the change differs per release. Lets approach this in a different way ... ** Also affects: qemu (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: qemu (Ubunt

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
Without such fixed it looks like this: dpkg: warning: qemu-guest-agent: conffile '/etc/qemu/fsfreeze-hook' is not a plain file or symlink (= '/etc/qemu/fsfreeze-hook') And then leaves a dpkg-new file: ubuntu@disco:~$ ll /etc/qemu total 20 drwxr-xr-x 4 root root 4096 Mar 18 09:34 ./ drwxr-xr-x 87

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
The trivial update has troubles with the old path colliding. Let modify that to use mv conffile - maybe I also need a tweak to properly handle the new path changing from a DIR to a FILE as being a conffile would not remove it by default on an upgrade. -- You received this bug notification becau

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
Current: ll /etc/qemu/fsfreeze-hook/fsfreeze-hook -rwxr-xr-x 1 root root 1274 Dec 11 17:44 /etc/qemu/fsfreeze-hook/fsfreeze-hook Yeah that should only be ll /etc/qemu/fsfreeze-hook/fsfreeze-hook -rwxr-xr-x 1 root root 1274 Dec 11 17:44 /etc/qemu/fsfreeze-hook -- You received this bug notifica

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
Broken in Debian as well since they picked my change, I'll report the fix there too -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1820291 Title: fsfreeze-hook script is misplaced in qemu-guest-agent

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
/etc/qemu/fsfreeze-hook.d path is correct -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1820291 Title: fsfreeze-hook script is misplaced in qemu-guest-agent To manage notifications about this bug g

[Bug 1820291] Re: fsfreeze-hook script is misplaced in qemu-guest-agent

2019-03-18 Thread Christian Ehrhardt 
Thanks a lot for that bug report Pierre. You are right and we want to solve that before Disco is released to not have to mess around too much with confile moving around between releases. (The rules are relaxed for not yet released Ubuntu releases and in this case it makes sense - usage will be v