[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-23 Thread Francis Ginther
** Tags added: id-5daf76eda2a6e5756012409b -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity offers installation media as an install target To manage notifications about this

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-14 Thread Dimitri John Ledkov
I'm slightly interested to know how you can use biggest_free # Skip devices containing the installation medium [ -e "$dev/installation_medium" ] && continue And we have always done that, meaning if one boots from something that looks like installation_medium it

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-14 Thread Dimitri John Ledkov
@superm1 i want the OEM image. Imho, i like mwhudson approach. In general, we do want to prevent some_device, if installer is running from the device in question. My change to capture partitions, is because our regular stock installer now mounts as a partition, rather than a whole disk. -- You

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-13 Thread Mario Limonciello
Ah right, so since we're using biggest_free that corrected line from xnox wouldn't even run. I opened up another bug for this regression so we don't lose it (bug 1847944), so maybe we should move discussion there. -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-13 Thread Michael Hudson-Doyle
Argh you're right of course. Have to run now, don't have time to make a better patch. And yes, I was assuming your recipe doesn't use some_device -- the intent of my change was essentially to restrict the logic xnox added to some_device and not the others (we should also probably add some

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-13 Thread Mario Limonciello
Thanks for the quick turnaround! I was able to do some quick testing with it, and it does fix the problem. A few comments though: * This line: $(mount | grep -qF "$device on /cdrom ") && continue Is what was in 134ubuntu10, so is that what you actually meant? It seems like it might want to

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-13 Thread Michael Hudson-Doyle
Argh I was worried that might happen :( Are you in a postition to test the attached patch? (I realize testing installer patches like this isn't the easiest thing) ** Patch added: "0001-only-suppress-the-installation-media-for-some_device.patch"

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-13 Thread Mario Limonciello
Yes; I can confirm that is root cause; IE removing that new line in /lib/partman/lib/auto-shared.sh resolves the issue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity offers

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-13 Thread Mario Limonciello
I think this change broke OEM installation from a recovery partition on HDD. Can't seem to install to it anymore. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity offers

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-10 Thread Launchpad Bug Tracker
This bug was fixed in the package ubiquity - 19.10.18 --- ubiquity (19.10.18) eoan; urgency=medium * Automatic update of included source packages: partman-auto 134ubuntu11. (LP: #1845571) -- Dimitri John Ledkov Thu, 10 Oct 2019 03:04:14 +0100 ** Changed in: ubiquity

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-10 Thread Launchpad Bug Tracker
This bug was fixed in the package partman-auto - 134ubuntu11 --- partman-auto (134ubuntu11) eoan; urgency=medium * lib/auto-shared.sh: skip installer disk when it's mounted as a partition too, as the current casper tries to do by default when presented with a

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Dimitri John Ledkov
** Also affects: ubiquity (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity offers installation media as an install target

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Dimitri John Ledkov
** Description changed: I guess this is actually a bug in some partman component, but well. In both the desktop and ubuntu studio installers for eoan beta, I was offered the installation media as a target disk. This seems unlikely to be correct. + + == + + partman-auto must not use the

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Dimitri John Ledkov
** Attachment added: "test.sh" https://bugs.launchpad.net/ubuntu/+source/partman-auto/+bug/1845571/+attachment/5296102/+files/test.sh -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title:

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Dimitri John Ledkov
Hm, I wonder, if this is now the same issue as seen on ppc64le subiquity images, that parted now detects our installer media as partition table `mac' and doesn't deal with it via partman which shows no partitions for the device. and the state directory for it has no partitions. -- You received

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Dimitri John Ledkov
Hm, i wonder if $(mount | grep -qF "$device on /cdrom ") && continue is broken ever since UEFI was introduced, since now $device1 is mounted not simply $device. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Dimitri John Ledkov
Reading a bit more code ubiquity has partman/check.d/partition_too_small which does read /cdrom/casper/filesystem.size (which is 5GiB) and should actually prevent from successfully contining to install on the installation media. Also there is d-i/source/partman-auto/lib/auto-shared.sh

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Dimitri John Ledkov
For the dell usecase, the expection is to "use free" or "wipe Ubuntu FOO and reinstall", meaning that only free space is used or an existing Ubuntu partition is wiped & reinstalled. Meaning that the full device /dev/sdb (the install media) is not offered for install target. The only time we do

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Dimitri John Ledkov
But looking at brian's screenshot 2.3GB usb stick should not be offered for installation, as it's too small and should have been filtered out by some_device for installation. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Brian Murray
For the record this happens when choosing use "Erase disk and install Ubuntu", not in an advanced partitioning screen. Attached you'll find a screenshot of issue with the install media as the default destination. Although it might be because I used the following "kvm -m 4096 -boot d -hda

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Jeremy Bicha
Years ago, I believe I used to be able to use grub to mount an Ubuntu iso on my hard drive as a loopback device and use that to install Ubuntu on the same hard drive. But years ago, that use case broke. (Apologies if I'm way off-topic here.) -- You received this bug notification because you are

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Sebastien Bacher
If we are not confident in fixing the bug this cycle what about reverting the casper change that created the problem for now? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-09 Thread Sebastien Bacher
(also 'it's hard to fix' isn't really a reason that justify lowering the importance of an issue) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity offers installation media as

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-08 Thread Michael Hudson-Doyle
The reason that I argued for the importance to be lowered is that I'm not super confident about fixing it on a short turnaround without causing other problems. In disco and before, casper would mount the entire device (say /dev/sdb) containing the installation media (i.e. mount /dev/sdb not

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-08 Thread Sebastien Bacher
@Brian, I'm raising that back to at least High, Desktop consider it as a visible problem that should be resolved for 19.10, could you make sure it's stay on your list? ** Changed in: partman-auto (Ubuntu Eoan) Importance: Medium => High -- You received this bug notification because you are a

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-08 Thread Jean-Baptiste Lallement
IMHO, importance is High and fixed for release because the disk selection page is always displayed even if the machine only has one drive and shouldn't. Also if the user selects the USB stick, the installation will fail. -- You received this bug notification because you are a member of Ubuntu

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-07 Thread Brian Murray
** Changed in: partman-auto (Ubuntu Eoan) Importance: Critical => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity offers installation media as an install target To

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-04 Thread Francis Ginther
** Tags added: id-5d96126fc078dd5a88fdcc5c -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity offers installation media as an install target To manage notifications about this

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-03 Thread Brian Murray
** Changed in: partman-auto (Ubuntu Eoan) Importance: Undecided => Critical ** Changed in: partman-auto (Ubuntu Eoan) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-03 Thread Steve Langasek
** Also affects: partman-auto (Ubuntu Eoan) Importance: Undecided Status: New ** Tags removed: rls-ee-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-03 Thread Dimitri John Ledkov
i wonder if we are missing casper uuids or some things in .disk that causes the installation media to be excluded (detected as install media) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-02 Thread Jean-Baptiste Lallement
** Package changed: ubiquity (Ubuntu) => partman-auto (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity offers installation media as an install target To manage

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-10-01 Thread Brian Murray
** Tags added: eoan ** Tags added: rls-ee-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1845571 Title: ubiquity offers installation media as an install target To manage notifications

[Bug 1845571] Re: ubiquity offers installation media as an install target

2019-09-26 Thread Ubuntu QA Website
This bug has been reported on the Ubuntu ISO testing tracker. A list of all reports related to this bug can be found here: http://iso.qa.ubuntu.com/qatracker/reports/bugs/1845571 ** Tags added: iso-testing -- You received this bug notification because you are a member of Ubuntu Bugs, which is