[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-12-02 Thread Frank Heimes
** Changed in: ubuntu-power-systems Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1847948 Title: Improve NVMe guest performance on Bionic QEMU To manage

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-12-02 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.11+dfsg-1ubuntu7.21 --- qemu (1:2.11+dfsg-1ubuntu7.21) bionic; urgency=medium * d/p/lp-1842774-s390x-cpumodel-Add-the-z15-name-to-the-description-o.patch: update the z15 model name (LP: #1842774) * d/p/u/lp-1847948-*: allow MSIX BAR

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-11-25 Thread Frank Heimes
Thanks for the verification Murillo. I updated the tags based on comment #25. ** Tags removed: verification-needed verification-needed-bionic ** Tags added: verification-done verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscrib

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-11-25 Thread Christian Ehrhardt 
I found no obvious regressions with this build in a run of our usual set of tests. @IBM - for SRu verification - can you give the actual testcase it was intended for a shot in your environment as you had that set up int he past? -- You received this bug notification because you are a member of U

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-11-22 Thread Frank Heimes
** Changed in: ubuntu-power-systems Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1847948 Title: Improve NVMe guest performance on Bionic QEMU To manage

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-11-22 Thread Timo Aaltonen
Hello bugproxy, or anyone else affected, Accepted qemu into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:2.11+dfsg- 1ubuntu7.21 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See htt

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-11-13 Thread Christian Ehrhardt 
This got surpassed by a security upload while waiting for SRU Team. I have uploaded rebased versions to -unapproved. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1847948 Title: Improve NVMe guest p

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-11-04 Thread Manoj Iyer
** Changed in: ubuntu-power-systems Status: Triaged => Fix Released ** Changed in: ubuntu-power-systems Status: Fix Released => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-27 Thread Christian Ehrhardt 
Uploaded for SRU Team review and acceptance into proposed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1847948 Title: Improve NVMe guest performance on Bionic QEMU To manage notifications about t

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-25 Thread Rafael David Tinoco
After reading this: * I know, one could as well call that a "feature", but it really is a performance bug fix more than anything else. Also the SRU policy allows exploitation/toleration of new HW especially for LTS releases. Therefore I think this is fine as SRU. I'm okay with that inte

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-25 Thread Rafael David Tinoco
Agreed on Frank's last comment. commit a32295c612c57990d17fb0f41e7134394b2f35f6 Author: Alexey Kardashevskiy Date: Wed Dec 13 00:31:31 2017 vfio-pci: Allow mapping MSIX BAR By default VFIO disables mapping of MSIX BAR to the userspace as the userspace may program it in a way a

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-23 Thread Frank Heimes
Regarding the kernel part of this LP ticket I plan to set it to Won't Fix - if nobody objects. And that's because we usually do not add performance improvements to stable kernels, but have the hardware enablement (HWE) kernel instead. I checked disco's git tree and "vfio-pci: Allow mapping MSIX

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-17 Thread Christian Ehrhardt 
I opened up the MP for review again after pushing the extra patches that you tested. Once that is done I can push it to the SRU teams queue ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1847948 T

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-17 Thread Christian Ehrhardt 
Thanks Murilo, I need no test with the basic kernel yet. But later when we really SRU this it will be good to do both a old and a HWE kernel check. Let me add that to the verification steps ... ** Description changed: [Impact] - * In the past qemu has generally not allowd MSI-X BAR mapping

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-16 Thread Christian Ehrhardt 
Thanks for your feedback and tests Murilo*2 (There seems to be a team of Murilo's on this :-) - thanks for your efforts and fast responses bringing this case forward.) With the main changes requested I really think we need the patch in #8 to avoid issues on other HW setups that due to the new code

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-15 Thread Murilo Opsfelder Araújo
Christian, Patch from comment 8 seems yet another nice improvement. We haven't tried it to have a strong opinion. If it's included, then I think patch from comment 9 won't hurt being added too. Murilo -- You received this bug notification because you are a member of Ubuntu Bugs, which is subs

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-15 Thread Murilo Opsfelder Araújo
Christian, Using QEMU from comment 6, it improved the performance for numjobs=4 and numjobs=64 cases, respectively: READ: bw=1140MiB/s (1195MB/s), 271MiB/s-302MiB/s (284MB/s-317MB/s), io=66.8GiB (71.7GB), run=60001-60001msec READ: bw=4271MiB/s (4479MB/s), 30.1MiB/s-82.6MiB/s (31.6MB/s-86.6

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-15 Thread Christian Ehrhardt 
And on top of the former question most likely then also [1]. [1]: https://git.qemu.org/?p=qemu.git;a=commit;h=5c08600547c059e3fd072995f9f367cdaf3c7d9d -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/184

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-15 Thread Christian Ehrhardt 
@Murilo: I was wondering - I think we might want/need also [1] to not run into fatal false positives. What is your opinion on this? [1]: https://git.qemu.org/?p=qemu.git;a=commit;h=567b5b309abe744b1098018a2eb157e7109c9f30 ** Description changed: + [Impact] + + * In the past qemu has generally

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-15 Thread Christian Ehrhardt 
All systems I could easily get a hold of already had their NVME drives in use so I couldn't pass them through easily. Therefore I'd like to come back to your offer to check the test build. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-15 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/374130 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1847948 Title: Improve NVMe guest performa

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-15 Thread Christian Ehrhardt 
FYI: Test builds are in [1]. It isn't required, but would be great if you could give it a check as well ahead of the actual SRU. [1]: https://launchpad.net/~paelzer/+archive/ubuntu/bug-1847948-nvmeperf-1842774 -z15name-bionic -- You received this bug notification because you are a member of Ubun

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-15 Thread Christian Ehrhardt 
I must have been blind, of course your testcase in the description is fine. Sorry for even asking. I'll give it a try if it also works to reflect the improvement on some HW I can access, but if not thanks for offer to test it on your side. -- You received this bug notification because you are a

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-14 Thread Murilo Opsfelder Araújo
Christian, The test case for this is to: - passthrough the NVMe disk to guest; - and run fio benchmarks against the passed-through NVMe disk in the guest. I have detailed these steps and pasted the commands in the bug description. Please let me know if steps are not clear. The only required HW

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-13 Thread Christian Ehrhardt 
The kernel part of this is in since 4.16 so it either needs a HWE kernel or to add a kernel Task to backport the related change for the kernel as well. I'll add a task but it depends the Kernelteam (doability) and the reporters request (for which kernel it is needed). ** Also affects: linux (Ubunt

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-13 Thread Christian Ehrhardt 
FYI kernel commit is [1] I haven't checked if any context is needed. https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1847948 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1847948 Title: Improve

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-13 Thread Christian Ehrhardt 
For Qemu the code is in 2.12, therefore as requested we only need to consider Bionic. @Murilo: do you have a good testcase for this to verify the bug when it became an accepted SRU? Could you outline what has to be done and if it requires special HW or a rather complex setup maybe even commit to

[Bug 1847948] Re: Improve NVMe guest performance on Bionic QEMU

2019-10-13 Thread Frank Heimes
** Also affects: ubuntu-power-systems Importance: Undecided Status: New ** Changed in: ubuntu-power-systems Status: New => Triaged ** Changed in: ubuntu-power-systems Importance: Undecided => Medium ** Changed in: ubuntu-power-systems Assignee: (unassigned) => Canonical