[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-12-27 Thread Gianfranco Costamagna
I uploaded 1.1.15 which contains the upstream fix and new regression test for this particular bug. If it builds, we can assume we are fine -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-12-03 Thread Gianfranco Costamagna
and reuploaded! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to:

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-12-03 Thread Gianfranco Costamagna
Hello, yes, I requested that test and I will cherry-pick. I tried right now a build with that added test in my ppa (but no fix) and it failed https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/costamagnagianfranco-ppa/+build/20359561 the very same build (so no patch for the corruption

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-12-01 Thread Chris Halse Rogers
It looks like this has been noticed on the borgbackup GitHub, resulting in https://github.com/ThomasWaldmann/borg/commit/aa3938a7a53c29d35df8567f4ebba4c2c76e7342 . As it's just a test, this might be a sensible thing to cherry-pick? It'd turn the test case from “back up lots of data, and hope you

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-11-26 Thread Steve Dodd
I've gone through the upstream bug https://github.com/borgbackup/borg/issues/4829 and not found any data which could be used as a test case. While the description of the bug there is quite detailed, I think one would have to be incredibly familiar with borg internals & code to create a reproducer.

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-11-26 Thread Steve Dodd
Given this is a *known data corrupting bug* declared by upstream, it would seem really odd to hold up the release for bionic and focal, where the solution is just an upgrade to the upstream version containing the fix! (I can possibly see the argument for being more careful with cherrypicked

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-11-26 Thread Gianfranco Costamagna
I added the testcase to the bug -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in all versions before 1.1.11 To manage notifications about this bug go to:

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-11-26 Thread Gianfranco Costamagna
Brian, the testcase is to backup some TB of data, and try to read them, the index should not be corrupted. This is why I'm asking upstream to test the package once its in proposed pocket, because I lack the data to test it properly ** Description changed: [ Impact ] * Data is corrupted on

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-11-24 Thread Brian Murray
What I'm saying is there is not a documented "Test Case" in the bug report which is an important part of the SRU process. Please add one so that we can review this SRU. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-11-16 Thread Gianfranco Costamagna
Hello Brian, I'll ask upstream to test it once the new version is in proposed pocket. Is it ok for you? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data corruption issue in

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-10-27 Thread Brian Murray
It looks like there may be a test case in the upstream bug but it'd be helpful if one was added to the Launchpad one. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877844 Title: [SRU] data

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-10-15 Thread Gianfranco Costamagna
xenial 16.04: upgrade from the current 1.0.12 to 1.0.13-0ubuntu1.16.04.1 (a.k.a. stock 1.0.13 + this fix cherry-picked from 1.0 maint branch) bionic 18.04: upgrade to 1.1.14-2ubuntu18.04.1 (sorry, just the versioning in changelog was wrong!) focal 20.04: upgrade to 1.1.14-2ubuntu20.04.1 I fixed

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-10-14 Thread Robie Basak
SRU review There's something wrong going on here, but I'm not sure exactly what you intend so I'm not sure what to suggest. The upload in the Bionic queue is 1.1.14-2ubuntu1.20.04.1 but Bionic is 18.04. Focal is on 1.1.11-5 which is lower than the Bionic upload, so that can't work. Please could

[Bug 1877844] Re: [SRU] data corruption issue in all versions before 1.1.11

2020-10-13 Thread Gianfranco Costamagna
Unfortunately upgrading from 1.1.11 to 1.1.14 requires xxhash being installed on the system, because I removed the embedded version being used in borgbackup -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.