[Bug 1879272] Re: corrupted json payload when adding a device

2020-06-02 Thread Launchpad Bug Tracker
This bug was fixed in the package gpsd - 3.20-8ubuntu0.2 --- gpsd (3.20-8ubuntu0.2) focal; urgency=medium * fix json missing quotes on device add (LP: #1879272) -- Christian Ehrhardt Wed, 20 May 2020 08:23:02 +0200 ** Changed in: gpsd (Ubuntu Focal) Status: Fix

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-28 Thread Launchpad Bug Tracker
This bug was fixed in the package gpsd - 3.20-12 --- gpsd (3.20-12) unstable; urgency=medium [ Bernd Zeimetz ] * [b7a30c42] Disable reprotest on CI for now. Until somebody comes up with a fix. [ Christian Ehrhardt ] * [fccbcc8f] fix json missing quotes on device add (LP:

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-27 Thread Christian Ehrhardt 
** Changed in: gpsd (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879272 Title: corrupted json payload when adding a device To manage

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-27 Thread Christian Ehrhardt 
Test worked for me as well, thanks Andreas for the fast test on your side as well. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-26 Thread Andreas Tobler
The version gpsd-3.20-8ubuntu0.2 fixes my issue. The test was adding a device and parsing the json output from the ctrl socket. Thanks a lot, Andreas ** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-26 Thread Brian Murray
Hello Andreas, or anyone else affected, Accepted gpsd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gpsd/3.20-8ubuntu0.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-25 Thread Christian Ehrhardt 
FYI the groovy fix is ready in proposed but it's release is entangled with qtbase-opensource-src transition. So it might take a few more days to appear in groovy. Being that far is ok as SRU prereq, so I uploaded the change for SRU review into Focal-unapproved as well now. -- You received this

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-20 Thread Lucas Kanashiro
** Changed in: gpsd (Ubuntu Focal) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879272 Title: corrupted json payload when adding a device To manage

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-20 Thread Christian Ehrhardt 
Thanks Andreas I think I can use this for the SRU. Bernd already merged my branch and uploaded debian/3.20-12 which is currently building in Debian and Groovy. So soon all that will be left is the SRU to Focal which need a teammate to check my branch for errors. ** Changed in: gpsd (Ubuntu

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-20 Thread Christian Ehrhardt 
FYI - Tested against the PPA with the SRU test steps: {"class":"DEVICE","path":"/dev/ttyUSB0","activated":"2020-05-20T08:49:45.631Z"} Working now -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-20 Thread Christian Ehrhardt 
FYI: Added the SRU template to the description -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879272 Title: corrupted json payload when adding a device To manage notifications about this bug go

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-20 Thread Bernd Zeimetz
Fixed in 3.20-12 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879272 Title: corrupted json payload when adding a device To manage notifications about this bug go to:

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-20 Thread Andreas Tobler
@Christian, thanks for taking care of this issue. Well, if you rely on the output of the control socket of gpsd then you get corrupt json payload if a gps device is added to gpsd. We rely on this output and our application fails if it can't parse the json payload which results in a non working

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-20 Thread Christian Ehrhardt 
Reported a fix to Debian https://salsa.debian.org/debian-gps-team/pkg- gpsd/-/merge_requests/8 in case they want it as well - Bernd can pick it up that way or in 3.21 when it is released some time later. For Ubuntu I already have these prepared:

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-20 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/gpsd/+git/gpsd/+merge/384232 ** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/gpsd/+git/gpsd/+merge/384233 -- You received this bug notification because you are a member of Ubuntu

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-19 Thread Christian Ehrhardt 
@Andreas - I could reproduce this and I'm fine going on with the fix. Yet I haven't seen any "impact" like what doesn't work because of this. It will be easy to fix it for Ubuntu 20.10 and onwards, but for the SRU [1] I'll need to describe the impact to justify it - if you could help me on that

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-19 Thread Christian Ehrhardt 
Repro steps: Start without a device like /etc/defaul/gpsd DEVICES="" Attach a json watcher like to gpsd like $ telnet localhost 2947 then enter ?WATCH={"enable":true,"json":true}; This looks like: $ telnet localhost 2947 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'.

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-19 Thread Christian Ehrhardt 
Thanks for reporting this Andreas, I'll take a look. Note: The fix is not yet in a released version but will be in 3.21 once it is released. ** Changed in: gpsd (Ubuntu) Assignee: (unassigned) => Christian Ehrhardt  (paelzer) -- You received this bug notification because you are a

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-19 Thread Andreas Tobler
Yes, this is the mentioned patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879272 Title: corrupted json payload when adding a device To manage notifications about this bug go to:

[Bug 1879272] Re: corrupted json payload when adding a device

2020-05-19 Thread Lucas Kanashiro
Thanks for reporting this bug and also the provided upstream patch. Just to make it clear this is the mentioned patch: https://gitlab.com/gpsd/gpsd/-/commit/733495192307d43c9e3bdd9e1b202045e66d998b ** Also affects: gpsd (Ubuntu Focal) Importance: Undecided Status: New ** Tags added: