[Bug 1881074] Re: Support btrfs when writable is converted to btrfs

2020-06-02 Thread Ɓukasz Zemczak
Sponsored for groovy. Please give me a sign if anything else is needed! ** Changed in: initramfs-tools-devices (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1881074] Re: Support btrfs when writable is converted to btrfs

2020-06-02 Thread Woodrow Shen
** Description changed: - It's a special case that we may need to convert rootfs from ext4 to + [Impact] + + * It's a special case that we may need to convert rootfs from ext4 to btrfs, and we have to resize btrfs inside initramfs as well. + + [Test Case] + + * Use ubuntu-image to create a

[Bug 1881074] Re: Support btrfs when writable is converted to btrfs

2020-05-28 Thread Alfonso Sanchez-Beato
@Woodrow thanks for your changes - you are right the binaries are already included by hooks from dependencies. LGTM from my side - although I cannot review formally apparently :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

Re: [Bug 1881074] Re: Support btrfs when writable is converted to btrfs

2020-05-28 Thread Woodrow Shen
Hi Alfonso, On Thu, May 28, 2020 at 4:20 PM Alfonso Sanchez-Beato < 1881...@bugs.launchpad.net> wrote: > Some comments on the debdiff: > > Use > blkid -s TYPE "$writable_part" -o value > instead of > blkid -s TYPE "$writable_part" | awk '{print $2}' | grep -o '".*"' | tr -d > '"' > I've revised

[Bug 1881074] Re: Support btrfs when writable is converted to btrfs

2020-05-28 Thread Woodrow Shen
Revised the patch according to suggestions, thanks. ** Patch added: "debdiff.patch" https://bugs.launchpad.net/ubuntu/+source/initramfs-tools-devices/+bug/1881074/+attachment/537/+files/debdiff.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1881074] Re: Support btrfs when writable is converted to btrfs

2020-05-28 Thread Ubuntu Foundations Team Bug Bot
The attachment "debdiff.patch" seems to be a debdiff. The ubuntu- sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you

[Bug 1881074] Re: Support btrfs when writable is converted to btrfs

2020-05-28 Thread Alfonso Sanchez-Beato
Some comments on the debdiff: Use blkid -s TYPE "$writable_part" -o value instead of blkid -s TYPE "$writable_part" | awk '{print $2}' | grep -o '".*"' | tr -d '"' No need to redirect to >>$LOGFILE in resize_filesystem() which is already redirected when called. Also, you should not redirect to

[Bug 1881074] Re: Support btrfs when writable is converted to btrfs

2020-05-28 Thread Woodrow Shen
** Patch added: "debdiff.patch" https://bugs.launchpad.net/ubuntu/+source/initramfs-tools-devices/+bug/1881074/+attachment/5377723/+files/debdiff.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.