I should add that while they claim their design is for async python code
(e.g. coroutines) they don't actually use it from a coroutine in this
older version of code, they are manually using the future's
on_done_callback() instead of just await-ing the future object (as they
do in newer code).
> the size of the _putters list is constrained by per-process open file
limits
there is no mechanism to restrict this inherent in the Queue class, it
would be up to the caller to use the class with that restriction
> every _putter represents a socket
no, their design for the Queue is for it to
No, I was unable to recreate a reproducer. I attached 2 files
(client.py, server.py) to demonstrate the oom error, but was
unsuccessful.
| raise an error if the Queue is already full, place the requestor on
the _putters list, and keep going.
Yeah I agree.
About the size of the getters and
I was asked to give this a quick look; do you have a reproducer that
demonstrates the problem?
It looks to me like the bounded Queue implementation tries hard to push
back against unconstrained resource growth:
def put(
[ ... ]
future = Future() # type: Future[None]
This bug was fixed in the package python-tornado - 4.2.1-1ubuntu3.1
---
python-tornado (4.2.1-1ubuntu3.1) xenial; urgency=low
* d/p/0001-lp1903733-read-queue-of-1-message.patch (LP: #1903733)
- fixes potential oom error with python-tornado client websocket
*
This bug was fixed in the package python-tornado - 4.5.3-1ubuntu0.2
---
python-tornado (4.5.3-1ubuntu0.2) bionic; urgency=low
* d/p/0001-lp1903733-read-queue-of-1-message.patch (LP: #1903733)
- fixes potential oom error with python-tornado client websocket
*
Thank you for digging into the verification, Heather, Dan. Seeing the
change and reading the verification comments, I agree with the rationale
and will proceed with the release.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
I went through the code with @hypothetical-lemon and the patches do
appear to fix the issue; with the previous code they were adding new
messages into a deque without any throttling, but now they are using a
different queue class that, while it still uses deques internally,
returns a future object
I don't believe what they have done with implementing a Queue(1) solves the
client oom errors.
This actually didn't solve the problem because the underlying implementation
still uses collection.deque() which was the issue to begin with.
websocket.py
self.read_queue = Queue(1)
queues.py
class
** Attachment removed: "client.py"
https://bugs.launchpad.net/ubuntu/xenial/+source/python-tornado/+bug/1903733/+attachment/5451896/+files/client.py
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Kicked the autopackage tests again.. passed 2nd time around
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1903733
Title:
Out of memory issue for websocket client
To manage notifications about this
Link to autopackage source test https://launchpad.net/ubuntu/+source
/python-tornado/4.5.3-1ubuntu0.2
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1903733
Title:
Out of memory issue for websocket
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
Hello Heather, or anyone else affected,
Accepted python-tornado into bionic-proposed. The package will build now
and be available at https://launchpad.net/ubuntu/+source/python-
tornado/4.5.3-1ubuntu0.2 in a few hours, and then in the -proposed
repository.
Please help us by testing this new
Ok, the patches *seem* fine (especially that they're cherry-picks), but
this SRU seems to be missing the regression potential analysis (per the
[Where problems could occur] section). I don't know the code enough to
feel if and which parts might regress after we land this change. Could
you update
[sts-sponsors][bionic]
Sponsored.
Thanks for your contribution Heather !
- Eric
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1903733
Title:
Out of memory issue for websocket client
To manage
[sts-sponsors][xenial]
Sponsored.
Thanks for your contribution Heather !
- Eric
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1903733
Title:
Out of memory issue for websocket client
To manage
v2 of xenial python-tornado package upload
** Patch added: "python-tornado-xenial-lp1903733.debdiff"
https://bugs.launchpad.net/ubuntu/xenial/+source/python-tornado/+bug/1903733/+attachment/5452755/+files/python-tornado-xenial-lp1903733.debdiff
--
You received this bug notification because
v2 of python-tornado bionic lp#1903733
** Patch added: "python-tornado-bionic-lp1903733.debdiff"
https://bugs.launchpad.net/ubuntu/xenial/+source/python-tornado/+bug/1903733/+attachment/5452754/+files/python-tornado-bionic-lp1903733.debdiff
--
You received this bug notification because you
** Tags added: sts-sponsor-slashd
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1903733
Title:
Out of memory issue for websocket client
To manage notifications about this bug go to:
ah ok i see, I will fix today. Thanks!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1903733
Title:
Out of memory issue for websocket client
To manage notifications about this bug go to:
[sts-sponsors][Review]
Quilt header for X and B:
* Add the commit link, not the PR please.
* Clean-up the launchpad.net bug -> https://launchpad.net/bugs/1903733
+Origin: upstream,
https://github.com/tornadoweb/tornado/pull/2351/commits/20becca336caae61cd24f7afba0e177c0a210c70
+Bug-Ubuntu:
[sts-sponsors][Review]
Quilt header
* Add the commit link, not the PR please.
* Clean-up the launchpad.net bug -> https://launchpad.net/bugs/1903733
+Origin: upstream,
https://github.com/tornadoweb/tornado/pull/2351/commits/20becca336caae61cd24f7afba0e177c0a210c70
+Bug-Ubuntu:
[sts-sponsors][Review]
Bionic debdiff nitpicks:
* Change 4.5.3-1ubuntu0.1.1 -> 4.5.3-1ubuntu0.2
* Change (LP#:1903733) to (LP: #1903733)
Xenial debdiff nitpicks:
* Change (LP#:1903733) to (LP: #1903733)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
** Patch added: "python-tornado-xenial-lp1903733.debdiff"
https://bugs.launchpad.net/ubuntu/bionic/+source/python-tornado/+bug/1903733/+attachment/5452707/+files/python-tornado-xenial-lp1903733.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
updated bionic python-tornado package
** Patch added: "python-tornado_4.5.3-1ubuntu0.1.1+bionic+lp1903733.debdiff"
https://bugs.launchpad.net/ubuntu/bionic/+source/python-tornado/+bug/1903733/+attachment/5452411/+files/python-tornado_4.5.3-1ubuntu0.1.1+bionic+lp1903733.debdiff
--
You
** Patch removed: "python-tornado-xenial-lp1903733b0.debdiff"
https://bugs.launchpad.net/ubuntu/+source/python-tornado/+bug/1903733/+attachment/5443587/+files/python-tornado-xenial-lp1903733b0.debdiff
** Patch removed: "python-tornadob0-lp1903733-bionic.debdiff"
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
attached screenshot of terminal setup and running
** Attachment added: "Screenshot from 2021-01-11 13-37-11.png"
https://bugs.launchpad.net/ubuntu/+source/python-tornado/+bug/1903733/+attachment/5452293/+files/Screenshot%20from%202021-01-11%2013-37-11.png
--
You received this bug
** Attachment added: "server.py"
https://bugs.launchpad.net/ubuntu/xenial/+source/python-tornado/+bug/1903733/+attachment/5451897/+files/server.py
** Changed in: python-tornado (Ubuntu Xenial)
Importance: Undecided => Low
** Changed in: python-tornado (Ubuntu Bionic)
Importance:
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
[sts-sponsor][xenial]
d/changelog mentioned 3 patches:
* d/p/0001-read-queue-of-1-message.patch
* d/p/0001-Remove-unused-import.patch
* d/p/0001-test-Skip-test_source_port_fail-when-running-as-root.patch
but d/p/series only has 2 of them ?
+0001-read-queue-of-1-message.patch
[sts-sponsor][xenial]
d/changelog mentioned 3 patches:
* d/p/0001-read-queue-of-1-message.patch
* d/p/0001-Remove-unused-import.patch
* d/p/0001-test-Skip-test_source_port_fail-when-running-as-root.patch
but d/p/series only has 2 of them ?
+0001-read-queue-of-1-message.patch
[sts-sponsor][Bionic]
Is this your final debdiff ?
* The bionic debdiff is incomplete as it only contains d/changelog.
* Version in d/changelog should be "4.5.3-1ubuntu0.2" instead of
"4.5.3-1ubuntu0.1.1" since the previous version was "4.5.3-1ubuntu0.1"
--
You received this bug notification
** Changed in: python-tornado (Ubuntu Xenial)
Status: New => In Progress
** Changed in: python-tornado (Ubuntu Bionic)
Status: New => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
python tornado xenial
** Patch added: "python-tornado-xenial-lp1903733b0.debdiff"
https://bugs.launchpad.net/ubuntu/xenial/+source/python-tornado/+bug/1903733/+attachment/5443587/+files/python-tornado-xenial-lp1903733b0.debdiff
--
You received this bug notification because you are a member
python-tornado bionic debdiff
** Patch added: "python-tornadob0-lp1903733-bionic.debdiff"
https://bugs.launchpad.net/ubuntu/xenial/+source/python-tornado/+bug/1903733/+attachment/5443547/+files/python-tornadob0-lp1903733-bionic.debdiff
--
You received this bug notification because you are a
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
** Description changed:
[Impact]
Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
[Other Info]
Upstream commit(s):
** Attachment added: "client py code"
https://bugs.launchpad.net/ubuntu/+source/python-tornado/+bug/1903733/+attachment/5437262/+files/client.py
** Description changed:
[Impact]
- Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related
** Attachment added: "server py code"
https://bugs.launchpad.net/ubuntu/+source/python-tornado/+bug/1903733/+attachment/5437261/+files/server.py
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Description changed:
[Impact]
+ Applications using package python-tornado v5.1.1 or earlier are susceptible
to an out of memory error related to websockets.
- [Test Case]
-
- [Where problems could occur]
[Other Info]
Upstream commit(s):
** Description changed:
+ [Impact]
+
+
+ [Test Case]
+
+
+ [Where problems could occur]
+
+
+ [Other Info]
+
+ $ git remote -v
+ originhttps://github.com/tornadoweb/tornado.git (fetch)
+ originhttps://github.com/tornadoweb/tornado.git (push)
+
+ $ git describe --contains
** Tags added: seg sts
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1903733
Title:
Out of memory issue for websocket client
To manage notifications about this bug go to:
** Changed in: python-tornado (Ubuntu)
Assignee: (unassigned) => Heather Lemon (hypothetical-lemon)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1903733
Title:
Out of memory issue for
54 matches
Mail list logo
