[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-03-01 Thread Launchpad Bug Tracker
This bug was fixed in the package sssd - 2.2.3-3ubuntu0.4 --- sssd (2.2.3-3ubuntu0.4) focal; urgency=medium [ Marco Trevisan ] * debian/control: - Add missing (test) dependencies as per libcrypto usage (LP: #1905790) - Update Maintainer to Ubuntu devs * debian/rules: Com

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-23 Thread Launchpad Bug Tracker
This bug was fixed in the package sssd - 2.3.1-3ubuntu4 --- sssd (2.3.1-3ubuntu4) groovy; urgency=medium * Avoid sending malformed SYSLOG_IDENTIFIER to journald (LP: #1908065): - d/p/lp-1908065-01-syslog_identifier-format.patch: Upstream patch to include "sssd[]" identifie

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-19 Thread Launchpad Bug Tracker
This bug was fixed in the package sssd - 2.4.0-1ubuntu5 --- sssd (2.4.0-1ubuntu5) hirsute; urgency=medium * No change rebuild with fixed ownership. -- Dimitri John Ledkov Tue, 16 Feb 2021 15:22:14 + ** Changed in: sssd (Ubuntu Hirsute) Status: Fix Committed => Fix Re

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-19 Thread Valters Jansons
Performing verification on Focal (20.04) # # Install current SSSD from focal-updates (2.2.3-3ubuntu0.3) # apt install -y sssd/focal-updates # apt policy sssd sssd: Installed: 2.2.3-3ubuntu0.3 Candidate: 2.2.3-3ubuntu0.3 Version table: 2.2.3-3ubuntu0.4 400 400 http://archive.

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-19 Thread Valters Jansons
The fix for Hirsute is in 2.4.0-1ubuntu4 which did not get pushed further into -release. Currently Hirsute has 2.4.0-1ubuntu5 in -proposed (since Feb 16) with the global archive ownership rebuild. ** Changed in: sssd (Ubuntu Hirsute) Status: Fix Released => Fix Committed -- You received t

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-19 Thread Robie Basak
This is fixed in Hirsute, which has sssd 2.4.0-1ubuntu3. ** Changed in: sssd (Ubuntu Hirsute) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1908065 Title: Inv

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-19 Thread Robie Basak
Hello Valters, or anyone else affected, Accepted sssd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sssd/2.2.3-3ubuntu0.4 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-17 Thread Valters Jansons
The description was updated to reflect changes in the test case for Groovy verification, as the initial test case was valid for Bionic and Focal (already mitigated on Groovy from upstream). ** Description changed: [Impact]  * On Ubuntu (Focal) 20.04, SSSD 2.2.3-3, logs in journald have inv

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-17 Thread Valters Jansons
Performing verification on Groovy (20.10) The case for Groovy was removal of multiple square brackets from syslog output. rsyslog was working with identifiers output such as `be[DOMAIN.COM][1234]:` which is expected to be seen as `sssd_be[1234]:` following the change. # # Install current SSSD fr

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-16 Thread Brian Murray
Hello Valters, or anyone else affected, Accepted sssd into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sssd/2.3.1-3ubuntu4 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.u

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-11 Thread Sergio Durigan Junior
I am marking this bug as Won't Fix for Bionic because as far as I could see there is nobody who is affected by this but there. Of course, I am willing to reconsider this decision in case someone shows up and complains about this problem on Bionic. ** Changed in: sssd (Ubuntu Bionic) Status

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Valters Jansons
Thank you! Similarly as well - feel free to ping me on IRC in case anything comes up. @mhodson tagged this as affecting Bionic, so I provided the patch. It has upstream commit tags, highlighting the upstream Git repository has a maintenance branch for 1.16 at https://github.com/SSSD/sssd/commits/s

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Sergio Durigan Junior
Thanks for driving this effort, much appreciated. I can work on properly applying the patches and testing the packages next week (feel free to ping me on IRC if I don't update this bug). I don't know about backporting this to Bionic; it seems that it's not a very urgent issue to justify the updat

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Valters Jansons
These latest debdiffs should include all the necessary changes and should be ready for verification, if there are no concerns about the material changes. To summarize the current proposed changes: Hirsute (21.04) and Groovy (20.10) receive commmits 1823353 and 01cc267 - one to add "sssd[]" in the

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Valters Jansons
** Patch removed: "sssd_2.4.0-1ubuntu4.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5456639/+files/sssd_2.4.0-1ubuntu4.debdiff ** Patch added: "sssd_2.4.0-1ubuntu4-2.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5460657

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Valters Jansons
** Patch removed: "sssd_2.3.1-3ubuntu4.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5456636/+files/sssd_2.3.1-3ubuntu4.debdiff ** Patch removed: "sssd_2.3.1-3ubuntu4-2.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/54566

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Valters Jansons
** Patch removed: "sssd_1.16.1-1ubuntu1.8-2.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5460573/+files/sssd_1.16.1-1ubuntu1.8-2.debdiff ** Patch added: "sssd_1.16.1-1ubuntu1.8-3.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attac

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Valters Jansons
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1908065 Title: Invalid SYSLOG_PID for (systemd) journal messages To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Valters Jansons
** Patch added: "sssd_2.2.3-3ubuntu0.4-3.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5460593/+files/sssd_2.2.3-3ubuntu0.4-3.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.l

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Valters Jansons
Upstream developers/maintainers opted to remove custom SYSLOG_IDENTIFIER entirely, allowing the program name to be used in place. This avoids having unexpected "[]" in the TAG. The change is pushed as: - 01cc267 for main branch (upstream version 2.4.1); - 360d8fc for version 1.16 backports. I wil

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-02-05 Thread Valters Jansons
** Patch added: "sssd_1.16.1-1ubuntu1.8-2.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5460573/+files/sssd_1.16.1-1ubuntu1.8-2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-25 Thread Valters Jansons
Opened https://github.com/SSSD/sssd/pull/5477 proposing to replace square brackets with parentheses. I will wait for review there before proposing new debdiffs with the change, in case either I missed something or upstream wants other tokens than parentheses. -- You received this bug notificatio

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-25 Thread Valters Jansons
> Probably someone should explain the problem to upstream sssd and suggest they use something other than brackets; literally anything else should avoid this problem, e.g. parenthesis, curly brackets, etc. This formatting with "[" in syslog TAG is already a concern on Groovy and Hirsute even withou

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-25 Thread Dan Streetman
> It seems like to properly fix this and avoid > https://github.com/SSSD/sssd/issues/5384 > which I think Groovy us affected by, two commits are needed: commit 00e7b1a > and commit 1823353. unfortunately the latter seems to add back in the problematic naming that includes brackets. Probably so

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-25 Thread Valters Jansons
Bionic and Hirsute do not have anything in -proposed currently. Focal and Groovy are waiting on LP: #1910611 to be released out from -proposed, and still in need of verification. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https:/

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-25 Thread Valters Jansons
For Bionic (18.04) sssd_1.16.1-1ubuntu1.8.debdiff contains rules change (--with-syslog=journald) along with upstream commits 225fe99 and 647a130 (backports for 1.16). For Focal (20.04) sssd_2.2.3-3ubuntu0.4.debdiff contains rules change (--with-syslog=journald) along with upstream commits 00e7b1a

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-25 Thread Valters Jansons
** Patch added: "sssd_2.4.0-1ubuntu4.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5456639/+files/sssd_2.4.0-1ubuntu4.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-25 Thread Valters Jansons
New revision of sssd_2.3.1-3ubuntu4 debdiff with changes to the patch description, clarifying that the previously referred commit is included in an upstream release already and not a part of the patch series. ** Patch added: "sssd_2.3.1-3ubuntu4-2.debdiff" https://bugs.launchpad.net/ubuntu/+so

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-25 Thread Valters Jansons
** Patch added: "sssd_2.3.1-3ubuntu4.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5456636/+files/sssd_2.3.1-3ubuntu4.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-24 Thread Valters Jansons
** Patch added: "sssd_1.16.1-1ubuntu1.8.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5456290/+files/sssd_1.16.1-1ubuntu1.8.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.lau

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-24 Thread Valters Jansons
The Bionic 20.04 debdiff (as 2.2.3-3ubuntu0.4) does include both referenced commits. I will take a look and provide debdiffs for the other affected versions - Bionic 18.04, Groovy 20.10, Hirsute 21.04. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subsc

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-24 Thread Valters Jansons
Sorry, in the last message I meant the Focal 20.04 debdiff includes both. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1908065 Title: Invalid SYSLOG_PID for (systemd) journal messages To manage no

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-23 Thread Mathew Hodson
** Also affects: sssd (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: sssd (Ubuntu Bionic) Importance: Undecided => Low ** Description changed: [Impact]  * On Ubuntu (Focal) 20.04, SSSD 2.2.3-3, logs in journald have invalid -(non-numeric) SYSLOG_PID. Any

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-23 Thread Mathew Hodson
It seems like to properly fix this and avoid https://github.com/SSSD/sssd/issues/5384 which I think Groovy us affected by, two commits are needed: commit 00e7b1a and commit 1823353. They both seem to have been ported to the sssd-1-16 branch as well. ** Bug watch added: github.com/SSSD/sssd/issues

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-23 Thread Mathew Hodson
** Description changed: [Impact] -  * On Ubuntu (Focal) 20.04, SSSD 2.2.3-3, logs in Journald have invalid - (non-numeric) SYSLOG_PID. Any tooling collecting SYSLOG_PID further, or - attempting to work with syslog directly, fail to parse the PID as - number. +  * On Ubuntu (Focal) 20.04, SSSD

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-23 Thread Mathew Hodson
** No longer affects: systemd (Ubuntu) ** Also affects: sssd (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: sssd (Ubuntu) Status: Triaged => Fix Released ** Changed in: sssd (Ubuntu) Importance: Undecided => Low ** Changed in: sssd (Ubuntu Focal) Importan

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-23 Thread Valters Jansons
Thank you for subscribing ubuntu-sponsors. Feel free to handles this after 2.2.3-3ubuntu0.3 reaches focal-updates, as that was published on focal-proposed yesterday (2021-01-22), and this change is not necessarily of such high priority compared to it. -- You received this bug notification becaus

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-23 Thread Ubuntu Foundations Team Bug Bot
The attachment "sssd_2.2.3-3ubuntu0.4.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" ta

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-23 Thread Valters Jansons
** Patch added: "sssd_2.2.3-3ubuntu0.4.debdiff" https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1908065/+attachment/5456023/+files/sssd_2.2.3-3ubuntu0.4.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launc

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-23 Thread Valters Jansons
Sorry Dan, I did not initially grasp the full implication of your message if it was intended that way. Thank you for the upstream commit linked. Will poke around a bit more and provide a proposed debdiff to be sponspored then, but to summarize from SSSD side: indeed not reproducible with a minimal

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-22 Thread Valters Jansons
It does not appear that systemd-journald is automatically parsing SYSLOG_IDENTIFIER. The following sample program: #include int main(int argc, char *argv[]) { sd_journal_send("MESSAGE=%s", "Hello world!", "SYSLOG_IDENTIFIER=%s", "sssd[sudo]", NULL); }

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-22 Thread Dan Streetman
sssd is setting SYSLOG_IDENTIFIER to the debug_prg_name internal var, which is set via calls to server_setup(), and in focal (and probably earlier) that's set to a name like "sssd[sudo]". However the syslog MSG section TAG field format requires only alphanumeric characters: https://tools.ietf.or

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-22 Thread Paride Legovini
Hi Valters, This really seems to be a systemd issue: sssd never sets SYSLOG_PID when calling sd_journal_send(), yet journalctl shows e.g. SYSLOG_PID=sudo instead of an empty string. Looks like systemd is mixing the variables or leaking one into the others. The sssd upstream patch you pointed to ma

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-22 Thread Paride Legovini
** Also affects: systemd (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1908065 Title: Invalid SYSLOG_PID for (systemd) journal messages To manag

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2021-01-20 Thread Valters Jansons
Is there any way to assist in moving this bug along? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1908065 Title: Invalid SYSLOG_PID for (systemd) journal messages To manage notifications about thi

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2020-12-16 Thread Valters Jansons
** Description changed: [Impact] - * On Ubuntu (Focal) 20.04, SSSD 2.2.3-3, logs in Journald have invalid +  * On Ubuntu (Focal) 20.04, SSSD 2.2.3-3, logs in Journald have invalid (non-numeric) SYSLOG_PID. Any tooling collecting SYSLOG_PID further, or attempting to work with syslog direc

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2020-12-16 Thread Valters Jansons
This could also be something on systemd/journald side. Looking at the source code, it seems SYSLOG_IDENTIFIER is the relevant part that gets set, but then somehow ends up 'leaking' into SYSLOG_PID. https://github.com/SSSD/sssd/blob/sssd-2_2_3/src/util/sss_log.c#L110 There is a further upstream com

[Bug 1908065] Re: Invalid SYSLOG_PID for (systemd) journal messages

2020-12-16 Thread Lucas Kanashiro
Thank you for taking the time to file a bug report. I was able to reproduce a similar behavior following the steps you described. I am going to mark this bug as Triaged ans subscribe our team to take a look at it any time soon. ** Changed in: sssd (Ubuntu) Status: New => Triaged -- You r