[Bug 1926298] Re: Segfault added in the recent changes

2021-05-24 Thread Launchpad Bug Tracker
This bug was fixed in the package update-notifier - 3.192.40.2 --- update-notifier (3.192.40.2) hirsute; urgency=medium [ Dan Bungert ] * Address segfault regression in the 3.192.40 update (LP: #1926298) related to hook command path lookup -- Brian Murray Thu, 29 Apr 2021

[Bug 1926298] Re: Segfault added in the recent changes

2021-05-22 Thread Mathew Hodson
** Tags removed: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926298 Title: Segfault added in the recent changes To manage notifications about this bug go to: https://bugs.lau

[Bug 1926298] Re: Segfault added in the recent changes

2021-05-21 Thread Dan Bungert
Same for 3.192.40.2 in hirsute-proposed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926298 Title: Segfault added in the recent changes To manage notifications about this bug go to: https://bugs

[Bug 1926298] Re: Segfault added in the recent changes

2021-05-21 Thread Dan Bungert
Also 3.192.42, which has the impish version of this fix, is not showing crashes for this problem: https://errors.ubuntu.com/problem/74e558a18105a756eb6a4b6aaa7145b79471754a -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.

[Bug 1926298] Re: Segfault added in the recent changes

2021-05-20 Thread Dan Bungert
Self-verified as follows: * use virtual machine manager to create a KVM with /srv/iso/hirsute/ubuntu-21.04-desktop-amd64.iso, 4 cpu/8G mem *

[Bug 1926298] Re: Segfault added in the recent changes

2021-05-07 Thread Launchpad Bug Tracker
This bug was fixed in the package update-notifier - 3.192.42 --- update-notifier (3.192.42) impish; urgency=medium [ Dan Bungert ] * Address segfault regression in the 3.192.40 update (LP: #1926298) related to hook command path lookup -- Brian Murray Thu, 29 Apr 2021 15:07

[Bug 1926298] Re: Segfault added in the recent changes

2021-05-04 Thread Dan Bungert
The same scenario occurs on impish, without update-notifier being involved: https://autopkgtest.ubuntu.com/packages/u/update-motd/impish/amd64 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926298 Tit

[Bug 1926298] Re: Segfault added in the recent changes

2021-05-03 Thread Dan Bungert
I believe update-notifier is the innocent bystander here, and the failure is caused by https://bugs.launchpad.net/ubuntu/+source/update- motd/+bug/1926660 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/

[Bug 1926298] Re: Segfault added in the recent changes

2021-05-03 Thread Steve Langasek
Hello Sebastien, or anyone else affected, Accepted update-notifier into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update- notifier/3.192.40.2 in a few hours, and then in the -proposed repository. Please help us by testing this new packag

[Bug 1926298] Re: Segfault added in the recent changes

2021-05-01 Thread Mathew Hodson
** Tags added: regression-release -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926298 Title: Segfault added in the recent changes To manage notifications about this bug go to: https://bugs.launch

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-30 Thread Dan Bungert
Requesting sponsorship for SRU of hirsute-update- notifier-2-3.192.40.2.debdiff ** Patch added: "hirsute-update-notifier-2-3.192.40.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1926298/+attachment/5493992/+files/hirsute-update-notifier-2-3.192.40.2.debdiff ** Chan

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-30 Thread Dan Bungert
** Description changed: [Impact] On hirsute/impish, update-notifier can crash when attempting to run hooks. This issue is the #2 crash on update-notifier in hirsute, presently (and maybe some of the others). I would call this a severe regression. + + In the crash cases, cleanup steps

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-30 Thread Dan Bungert
** Description changed: [Impact] - On Hirsute/Impish, update-notifier can crash when attempting to run - hooks. + On hirsute/impish, update-notifier can crash when attempting to run hooks. + This issue is the #2 crash on update-notifier in hirsute, presently (and + maybe some of the others).

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-30 Thread Dan Bungert
Test hooks to cover the cases introduced by the original change. ** Attachment added: "tests.tgz" https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1926298/+attachment/5493991/+files/tests.tgz -- You received this bug notification because you are a member of Ubuntu Bugs, which i

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-30 Thread Sebastien Bacher
** Changed in: update-notifier (Ubuntu) Status: Confirmed => Fix Committed ** Changed in: update-notifier (Ubuntu Hirsute) Assignee: (unassigned) => Dan Bungert (dbungert) ** Changed in: update-notifier (Ubuntu Hirsute) Importance: Undecided => High -- You received this bug notif

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-29 Thread Dan Bungert
** Description changed: + [Impact] + + On Hirsute/Impish, update-notifier can crash when attempting to run + hooks. + + [Test Case] + + Create a file 'bug' + + 'Name: bug + Priority: Low + Command: "/bin/true" + DisplayIf: /bin/true + Description: update notifier bug' + + and copy it to /var/

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-28 Thread Brian Murray
I manually retraced the crash file Dan provided and the results follow: Stacktrace: #0 0x7f3250972202 in g_strfreev (str_array=) at ../../../glib/gstrfuncs.c:2552 i = 0 #1 g_strfreev (str_array=0x69726f6972500a67) at ../../../glib/gstrfuncs.c:2546 i = #2 0x562c680

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Dan Bungert
** Attachment added: "_usr_bin_update-notifier.1000.crash" https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1926298/+attachment/5492933/+files/_usr_bin_update-notifier.1000.crash -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed t

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Dan Bungert
It is a patch but I'm not looking for a sponsor at this time, since it's going thru the MP. ** Tags removed: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926298 Title: Segfault added in the

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Brian Murray
** Also affects: update-notifier (Ubuntu Hirsute) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926298 Title: Segfault added in the recent changes To ma

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Ubuntu Foundations Team Bug Bot
The attachment "update-notifier-1-3.192.41.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "pat

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Dan Bungert
MP: https://code.launchpad.net/~dbungert/update-notifier/+git/update- notifier/+merge/401901 ** Changed in: update-notifier (Ubuntu) Status: In Progress => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~dbungert/update-notifier/+git/update-notifier/+merge/401901 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926298 Title: Segfault added in t

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Sebastien Bacher
Thanks Dan, the explanation of the issue and simplification as a solution are making sense, I've tested locally the patch and confirmed it resolves the segfault. The other bug you mention has its fix uploaded so nothing is preventing us to queue another upload now -- You received this bug notific

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Dan Bungert
Root cause: The goto out for cleanup can skip a variable initialization, so in some cases we crash on if(pathdirs) g_strfreev(pathdirs); because p

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Dan Bungert
** Changed in: update-notifier (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926298 Title: Segfault added in the recent changes To manage notificat

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Dan Bungert
Marking confirmed as I can see a segfault, but mine looks a little different: Thread 1 "update-notifier" received signal SIGSEGV, Segmentation fault. show_next_hook (hooks=0x55778340 = {...}, ta=, ta=) at hooks.c:376 376 gtk_widget_hide(priv->button_next); (gdb) bt #0 show_next_hook

[Bug 1926298] Re: Segfault added in the recent changes

2021-04-27 Thread Dan Bungert
** Tags added: fr-1314 ** Changed in: update-notifier (Ubuntu) Assignee: (unassigned) => Dan Bungert (dbungert) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1926298 Title: Segfault added in t