[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-11-22 Thread Launchpad Bug Tracker
This bug was fixed in the package software-properties - 0.96.24.32.18 --- software-properties (0.96.24.32.18) bionic; urgency=medium [ Chad Smith ] * utils: prefer /var/lib/ubuntu-advantage/status.json over ua status - Handle absent /var/lib/ubuntu-advantage/status.json for

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-11-17 Thread Launchpad Bug Tracker
This bug was fixed in the package software-properties - 0.99.16 --- software-properties (0.99.16) jammy; urgency=medium * Show Ubuntu Pro banner on Livepatch page (LP: #1934439) -- Robert Ancell Wed, 17 Nov 2021 16:17:44 +1300 ** Changed in: software-properties (Ubuntu)

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-11-14 Thread Robert Ancell
Tested software-properties-gtk 0.96.24.32.18 on bionic. Confirmed banner shows with correct link and can be dismissed. ** Tags removed: verification-needed verification-needed-bionic ** Tags added: verification-done-bionic -- You received this bug notification because you are a member of Ubuntu

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-11-10 Thread Launchpad Bug Tracker
This bug was fixed in the package software-properties - 0.99.9.8 --- software-properties (0.99.9.8) focal; urgency=medium [ Corey Bryant ] * cloudarchive: Enable support for the Yoga Ubuntu Cloud Archive on 20.04 (LP: #1948806). [ Chad Smith ] * utils: prefer

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-11-10 Thread Brian Murray
Hello Robert, or anyone else affected, Accepted software-properties into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.96.24.32.18 in a few hours, and then in the -proposed repository. Please help us by testing this new

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-11-09 Thread Sebastien Bacher
** Changed in: software-properties (Ubuntu) Assignee: (unassigned) => Robert Ancell (robert-ancell) ** Changed in: software-properties (Ubuntu Xenial) Assignee: (unassigned) => Robert Ancell (robert-ancell) ** Tags removed: rls-jj-incoming -- You received this bug notification

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-11-04 Thread Robert Ancell
Tested software-properties-gtk 0.99.9.8 on focal. Confirmed banner shows with correct link and can be dismissed. ** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-11-04 Thread Robert Ancell
Tested software-properties-gtk 0.96.24.32.17 on bionic. Confirmed banner shows with correct link and can be dismissed. ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-11-02 Thread Brian Murray
I'm accepting this for Focal now but would like to see it uploaded for Jammy too. ** Tags added: rls-jj-incoming ** Changed in: software-properties (Ubuntu Focal) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-17 Thread Adolfo Jayme
** Changed in: software-properties (Ubuntu) Importance: Undecided => Wishlist ** Changed in: software-properties (Ubuntu Xenial) Importance: Undecided => Wishlist ** Changed in: software-properties (Ubuntu Bionic) Importance: Undecided => Wishlist ** Changed in: software-properties

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-16 Thread Brian Murray
When considering these changes for an SRU I'd like to see the code changes landed in Impish so we don't lose track of them for J. That being said if they are in fact going to be replaced at some point, they don't necessarily need to be in the archive and just having them committed to the VCS would

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-16 Thread Sebastien Bacher
> - What mechanism can we use to determine if it should show? I don't think we have one atm which is why I was suggesting to just change the key default so false there > is it worth bringing that into Impish I'm just trying to anticipate a discussion with the SRU team and extra delays due to

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-14 Thread Robert Ancell
A couple of points about putting it into Impish: - What mechanism can we use to determine if it should show? - Since the banner refers to a beta feature, it will be replaced at some point with a new banner, is it worth bringing that into Impish or waiting for the more complete feature. -- You

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-09 Thread Sebastien Bacher
Thanks Robert, I saw that you uploaded to bionic and focal now, any reason to not merge to impish? If technically the feature doesn't apply to the current serie maybe we should just merge with a default setting to false so we just need to turn the option on for the next LTS if needed? -- You

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-07 Thread Robert Ancell
** Description changed: - Add a banner to the Livepatch page to invite users to join the Ubuntu - Pro for Desktop. + [Impact] + Add a banner to the Livepatch page to invite users to join the Ubuntu Pro for Desktop. Note that this is not shown in current releases, as this feature only applies to

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-07 Thread Robert Ancell
Lech - the Xenial version doesn't have a Livepatch page, should it be placed somewhere else? ** Changed in: software-properties (Ubuntu Bionic) Assignee: (unassigned) => Robert Ancell (robert-ancell) ** Changed in: software-properties (Ubuntu Focal) Assignee: (unassigned) => Robert

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-07 Thread Robert Ancell
** No longer affects: software-properties (Ubuntu Hirsute) ** No longer affects: software-properties (Ubuntu Impish) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1934439 Title: Add Ubuntu Pro

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-07 Thread Lech Sandecki
It's for xenial, bionic and focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1934439 Title: Add Ubuntu Pro banner to Livepatch page To manage notifications about this bug go to:

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-04 Thread Robert Ancell
Thanks for the feedback. Which distribution(s) should this be targetting? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1934439 Title: Add Ubuntu Pro banner to Livepatch page To manage

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-02 Thread Lech Sandecki
Thanks for sharing that, Robert. I like the idea to rename the Livepatch tab to Ubuntu Pro and this is the design that I think is planned for 21.10. That said, the idea of adding that banner to the 'software updates' card is worth discussing if it's as easy to implement as the current design.

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-02 Thread Sebastien Bacher
Hey Robert, I'm going to share some thoughts but ideally confirmation would come from design > - Does the banner only show if you haven't already attached this machine to Ubuntu Advantage? I guess it makes sense to only show it when the service isn't already in use > - When closing the banner,

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-01 Thread Robert Ancell
Information required for implementation: - Where does the link go to, http://ubuntu.com/desktop/pro? - Does the banner only show if you haven't already attached this machine to Ubuntu Advantage? - When closing the banner, does it return next time? - Does it make sense for this to be in the

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-01 Thread Robert Ancell
Implementation at https://code.launchpad.net/~robert-ancell/software- properties/+git/software-properties/+ref/ubuntu-pro-beta -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1934439 Title: Add

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-01 Thread Robert Ancell
** Attachment added: "Screenshot of implementation" https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1934439/+attachment/5508533/+files/Screenshot%20from%202021-07-02%2016-58-30.png ** Also affects: software-properties (Ubuntu Bionic) Importance: Undecided Status:

[Bug 1934439] Re: Add Ubuntu Pro banner to Livepatch page

2021-07-01 Thread Robert Ancell
** Attachment added: "Mockup of banner" https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1934439/+attachment/5508532/+files/ubuntu-pro-mockup.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.