[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-09-03 Thread Launchpad Bug Tracker
This bug was fixed in the package opengcs - 0.3.4+dfsg2-0ubuntu7 --- opengcs (0.3.4+dfsg2-0ubuntu7) impish; urgency=medium * d/p/0003-Add-support-for-runc-1.0.x.patch: Comply with the libcontainer API changes introduced in runc 1.0.x (LP: #1939423). -- Lucas Kanashiro Thu, 1

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-09-03 Thread Launchpad Bug Tracker
This bug was fixed in the package golang-github-containers-buildah - 1.21.3+ds1-1ubuntu1 --- golang-github-containers-buildah (1.21.3+ds1-1ubuntu1) impish; urgency=medium * d/p/support-runc-1.0.1.patch: Add patch to comply with API changes in libcontainer inside runc (LP: #19394

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-13 Thread Sergio Durigan Junior
Thanks, this LGTM. +1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939423 Title: Comply with API changes in runc 1.0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/u

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-13 Thread Lucas Kanashiro
Thanks for the review Sergio (again) :) Answering your questions: - I am not the author, yes. I just adapted the upstream commit, I'll change this field to Reviewed-By. - The upstream commit also updates the runc version embedded in its code, since this package does not contain vendorized deps w

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-13 Thread Sergio Durigan Junior
One more review for Lucas coming out :-). I looked at debdiff and I have a few questions: - IIUC you're not the author of the upstream patch, right? - Forgive my ignorance, but why is the upstream patch so big while the backported patch is really small and contained? Is it because the upstream

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-13 Thread Lucas Kanashiro
golang-github-containers-buildah is also affected by the libcontainer API changes. The attached debdiff fixes the issue. autopkgtest is still happy with the impish-proposed pocket enabled: autopkgtest [13:45:30]: summary dh-golang-autopkgtest PASS ** Attachment added: "debd

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-13 Thread Lucas Kanashiro
** Also affects: golang-github-containers-buildah (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939423 Title: Comply with API changes in runc 1.

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-12 Thread Ubuntu Foundations Team Bug Bot
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939423 Title: Comply with API changes in runc 1.0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubun

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-12 Thread Sergio Durigan Junior
Thanks for the patch, Lucas. I could reproduce the build failure without the patch, and then verified that the patch indeed fixes the issue. The package uses autodep8; I ran the tests and they succeeded. LGTM, +1. -- You received this bug notification because you are a member of Ubuntu Bugs, w

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-12 Thread Lucas Kanashiro
opengcs has the very same issue with the embedded version of containerd and docker. The attached debdiff fixes this issue. ** Attachment added: "debdiff" https://bugs.launchpad.net/ubuntu/+source/opengcs/+bug/1939423/+attachment/5517588/+files/debdiff -- You received this bug notification be

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-12 Thread Lucas Kanashiro
** Also affects: opengcs (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939423 Title: Comply with API changes in runc 1.0.1 To manage notificati

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-11 Thread Launchpad Bug Tracker
This bug was fixed in the package golang-github-containers-storage - 1.31.3+ds1-1ubuntu1 --- golang-github-containers-storage (1.31.3+ds1-1ubuntu1) impish; urgency=medium * d/p/support-runc-1.0.1.patch: Add patch to comply with API changes in libcontainer inside runc (LP: #19394

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-10 Thread Lucas Kanashiro
Thanks for the review Sergio! Package uploaded to impish-proposed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939423 Title: Comply with API changes in runc 1.0.1 To manage notifications about t

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-10 Thread Sergio Durigan Junior
Thanks, Lucas. The patch LGTM. I built the package locally and confirmed that the dep8 tests are passing. +1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939423 Title: Comply with API changes

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-10 Thread Lucas Kanashiro
The attached debdiff fix the issue, autopkgtest with the impish-proposed pocket enabled is happy again: autopkgtest [11:59:56]: summary dh-golang-autopkgtest PASS PPA with the proposed package: https://launchpad.net/~lucaskanashiro/+archive/ubuntu/container-stack ** Attachm

[Bug 1939423] Re: Comply with API changes in runc 1.0.1

2021-08-10 Thread Lucas Kanashiro
This is the error I've been seeing in the logs: # github.com/containers/storage/pkg/archive src/github.com/containers/storage/pkg/archive/archive.go:1143:16: undefined: "github.com/opencontainers/runc/libcontainer/system".RunningInUserNS src/github.com/containers/storage/pkg/archive/archive.go:11