[Bug 1940473] Re: thrift/0.13.0-6 FTBFS in Impish

2021-09-03 Thread Launchpad Bug Tracker
This bug was fixed in the package thrift - 0.13.0-6ubuntu1 --- thrift (0.13.0-6ubuntu1) impish; urgency=medium * d/p/THRIFT-5318_support_php8.patch: Backport upstream patch to add support for PHP 8 (LP: #1940473). * d/rules: export GO111MODULE=off, this will make go.mod file n

[Bug 1940473] Re: thrift/0.13.0-6 FTBFS in Impish

2021-08-18 Thread Lucas Kanashiro
Thanks for the review Sergio. I addressed your comments and already uploaded the package. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940473 Title: thrift/0.13.0-6 FTBFS in Impish To manage noti

[Bug 1940473] Re: thrift/0.13.0-6 FTBFS in Impish

2021-08-18 Thread Sergio Durigan Junior
Thanks, Lucas. The debdiff LGTM; I built the package locally with it. A couple of minor comments: 1) Don't forget to remove the "~ppa1" suffix from the version string :-). 2) When pointing to an upstream bug, DEP-3 says that we should just use the "Bug:" header (without the "-Upstream" suffix).

[Bug 1940473] Re: thrift/0.13.0-6 FTBFS in Impish

2021-08-18 Thread Lucas Kanashiro
I uploaded the proposed changes to this PPA: https://launchpad.net/~lucaskanashiro/+archive/ubuntu/testing -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940473 Title: thrift/0.13.0-6 FTBFS in Impi

[Bug 1940473] Re: thrift/0.13.0-6 FTBFS in Impish

2021-08-18 Thread Ubuntu Foundations Team Bug Bot
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1940473 Title: thrift/0.13.0-6 FTBFS in Impish To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+so

[Bug 1940473] Re: thrift/0.13.0-6 FTBFS in Impish

2021-08-18 Thread Lucas Kanashiro
Added an extra DEP-3 header to the patch. ** Attachment added: "debdiff2" https://bugs.launchpad.net/ubuntu/+source/thrift/+bug/1940473/+attachment/5518845/+files/debdiff2 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bu

[Bug 1940473] Re: thrift/0.13.0-6 FTBFS in Impish

2021-08-18 Thread Lucas Kanashiro
The attached debdiff fixes the FTBFS. ** Attachment added: "debdiff" https://bugs.launchpad.net/ubuntu/+source/thrift/+bug/1940473/+attachment/5518841/+files/debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.lau

[Bug 1940473] Re: thrift/0.13.0-6 FTBFS in Impish

2021-08-18 Thread Lucas Kanashiro
After backporting the upstream commit mentioned in the description, I got another error, but now related to the Go extension. Go 1.16 expects a go.mod file by default and thrift Go extension does not contain that, let's set GO111MODULE to off to avoid this error. -- You received this bug notifica