This bug was fixed in the package samba -
2:4.7.6+dfsg~ubuntu-0ubuntu2.24
---
samba (2:4.7.6+dfsg~ubuntu-0ubuntu2.24) bionic; urgency=medium
* samba.postinst: do not populate sambashare from the Ubuntu admin group
(LP: #1942195)
-- Paride Legovini Wed, 10 Nov 2021 15:29:48
This bug was fixed in the package samba -
2:4.13.14+dfsg-0ubuntu0.20.04.2
---
samba (2:4.13.14+dfsg-0ubuntu0.20.04.2) focal; urgency=medium
* samba.postinst: do not populate sambashare from the Ubuntu admin group
(LP: #1942195)
-- Paride Legovini Fri, 12 Nov 2021 14:42:02
This bug was fixed in the package samba -
2:4.13.14+dfsg-0ubuntu0.21.04.2
---
samba (2:4.13.14+dfsg-0ubuntu0.21.04.2) hirsute; urgency=medium
* samba.postinst: do not populate sambashare from the Ubuntu admin group
(LP: #1942195)
-- Paride Legovini Fri, 12 Nov 2021 14:44:50
This bug was fixed in the package samba -
2:4.13.14+dfsg-0ubuntu0.21.10.2
---
samba (2:4.13.14+dfsg-0ubuntu0.21.10.2) impish; urgency=medium
* samba.postinst: do not populate sambashare from the Ubuntu admin group
(LP: #1942195)
-- Paride Legovini Fri, 12 Nov 2021 11:17:14
Oh, and for the future: please always state which exact versions of
packages for each series have been tested when performing verification,
as other wise - in some cases - the verification can be rejected because
of that.
--
You received this bug notification because you are a member of Ubuntu
It indeed looks to be a bit unreliable, the failure that is. As it has
been discussed with adsys upstream, let me hint it before releasing.
Thanks!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Per team discussion we leave the decision whether adding a hint or
triggering a migration-reference/0 autopkgtest run to the SRU team.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
Verification done per [Test Case].
Note: the adsys autopkgtest failure on impish/arm64 is unrelated to the
samba upload:
1. The part of the test that exercises samba passes. The failure is in an
unrelated test.
2. The autopkgtest run fails even with adsys from impish-release; the test
failure
** Tags removed: verification-needed verification-needed-bionic
verification-needed-focal verification-needed-hirsute verification-needed-impish
** Tags added: verification-done verification-done-bionic
verification-done-focal verification-done-hirsute verification-done-impish
--
You received
It failed again (total 3 times) in the same way:
https://autopkgtest.ubuntu.com/results/autopkgtest-
impish/impish/arm64/a/adsys/2028_112720_82d83@/log.gz
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
The failed adsys/0.7.1 autopkgtest is due to a timeout:
*** Test killed with quit: ran too long (11m0s).
FAILgithub.com/ubuntu/adsys/internal/policies/ad660.011s
I'm trying with a simple retrigger for now. I'll do the verification
once all the tests pass.
--
You received this bug
Hello Richard, or anyone else affected,
Accepted samba into bionic-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/samba/2:4.7.6+dfsg~ubuntu-0ubuntu2.24
in a few hours, and then in the -proposed repository.
Please help us by testing this new package.
Hello Richard, or anyone else affected,
Accepted samba into focal-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/samba/2:4.13.14+dfsg-0ubuntu0.20.04.2
in a few hours, and then in the -proposed repository.
Please help us by testing this new package.
Hello Richard, or anyone else affected,
Accepted samba into hirsute-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/samba/2:4.13.14+dfsg-0ubuntu0.21.04.2
in a few hours, and then in the -proposed repository.
Please help us by testing this new
Hello Richard, or anyone else affected,
Accepted samba into impish-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/samba/2:4.13.14+dfsg-0ubuntu0.21.10.2
in a few hours, and then in the -proposed repository.
Please help us by testing this new package.
SRUs to fix this got uploaded to all the supported releases (thanks
Sergio!):
bionic
focal
hirsute
impish
Now it's up to the SRU team to review the change.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Hi Richard, very interesting, you are right. The Bionic lxd.preinst
script has:
# Add each admin user to the lxd group - for systems installed
# before precise
for u in $(getent group admin | sed -e "s/^.*://" -e "s/,/ /g"); do
adduser "$u" lxd >/dev/null || true
done
I tried to install
Paride, firstly thanks for picking this up. Looking at another machine
I have I notice that the lxd group may have a similar issue. This
suggests the problem may affect other packages as well. Is there a way
to trigger an audit for other packages that might be affected?
--
You received this
** Merge proposal linked:
https://code.launchpad.net/~paride/ubuntu/+source/samba/+git/samba/+merge/411694
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
Installing Samba
** Merge proposal linked:
https://code.launchpad.net/~paride/ubuntu/+source/samba/+git/samba/+merge/411691
** Merge proposal linked:
https://code.launchpad.net/~paride/ubuntu/+source/samba/+git/samba/+merge/411692
** Merge proposal linked:
** Changed in: samba (Ubuntu Bionic)
Status: Triaged => In Progress
** Changed in: samba (Ubuntu Focal)
Status: Triaged => In Progress
** Changed in: samba (Ubuntu Hirsute)
Status: Triaged => In Progress
** Changed in: samba (Ubuntu Impish)
Status: Triaged => In
** Description changed:
[Impact]
Up until Ubuntu 11.10, administrator access using the sudo tool was
granted via the "admin" Unix group. The samba postinst script has some
logic that automatically adds users in the "admin" group to the
sambashare group.
In Ubuntu >= 12.04,
** Description changed:
+ [Impact]
+
+ Up until Ubuntu 11.10, administrator access using the sudo tool was
+ granted via the "admin" Unix group. The samba postinst script has some
+ logic that automatically adds users in the "admin" group to the
+ sambashare group.
+
+ In Ubuntu >= 12.04,
** Changed in: samba (Ubuntu Impish)
Assignee: (unassigned) => Paride Legovini (paride)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
Installing Samba unexpectedly adds many
** Changed in: samba (Ubuntu Impish)
Status: New => Triaged
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
Installing Samba unexpectedly adds many unknown local users to
The upload to the devel release targeted impish, but actually landed in
jammy. Added an Impish task for the SRU.
** Also affects: samba (Ubuntu Impish)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed
This bug was fixed in the package samba - 2:4.13.5+dfsg-2ubuntu3
---
samba (2:4.13.5+dfsg-2ubuntu3) impish; urgency=medium
* d/samba.postinst: do not populate sambashare from the admin group
(Debian packaging cherry-pick. LP: #1942195)
-- Paride Legovini Wed, 06 Oct 2021
** Changed in: samba (Ubuntu)
Status: Confirmed => In Progress
** Also affects: samba (Ubuntu Hirsute)
Importance: Undecided
Status: New
** Also affects: samba (Ubuntu Bionic)
Importance: Undecided
Status: New
** Also affects: samba (Ubuntu Focal)
Importance:
** Merge proposal linked:
https://code.launchpad.net/~paride/ubuntu/+source/samba/+git/samba/+merge/409731
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
Installing Samba
Here it is: https://salsa.debian.org/samba-
team/samba/-/merge_requests/54
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
Installing Samba unexpectedly adds many unknown local users
Thanks for reviewing Sergio. I did the same archeology and indeed the
first line of that commit message is "This reverts commit fe5cef50." :-)
I don't foresee any problem with the approach that commit implements: it
just feels strange to fix a bug by dropping functionality, even if
broken and
Thanks for the commit, Paride. I left a comment there, but I'm also
going to copy it over here:
First of all, thank you for taking the time to investigate and write an
insightful commit message explaining the situation.
My first thought when reviewing this was: "where did this excerpt of
code
** Tags removed: server-triage-discuss
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
Installing Samba unexpectedly adds many unknown local users to
sambashare group
To manage
This is what I propose, see the commit message for the rationale:
https://salsa.debian.org/paride/samba/-/commit/4385c3920afa81e2c30a74d80f2ee0eb04753bb9
I didn't open a MR yet, let's agree on the approach first.
--
You received this bug notification because you are a member of Ubuntu
Bugs,
** Changed in: samba (Ubuntu)
Assignee: (unassigned) => Paride Legovini (paride)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
Installing Samba unexpectedly adds many unknown
** Tags added: server-triage-discuss
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
Installing Samba unexpectedly adds many unknown local users to
sambashare group
To manage
Hello Richard and thanks for this bug report. You are right: the
samba.postinst script adds all the users in the 'admin' group to the
'sambashare' group:
for USER in `getent group admin | cut -f4 -d:`; do
adduser "$USER" sambashare \
|| ! getent passwd "$USER" >/dev/null
done
The
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: samba (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942195
Title:
** Description changed:
I'm running Ubuntu 20.04 in an enterprise environment. I recently
- installed the samba package on my my machine which is configured to get
+ installed the samba package on my machine which is configured to get
most account details from a central ldap server. I was
39 matches
Mail list logo
