[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-07-03 Thread Chengen Du
@mfo I apologize for the haste earlier and have now modified the test plan. ** Description changed: [Impact] Deleting a volume will fail if it has snapshot or volume children, resulting in an ImageBusy error. [Fix] Upstream has a patch that uses RBD flatten operations to break

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-07-03 Thread Mauricio Faria de Oliveira
Hi Chengen, Thanks for implementing this! Could you please confirm/describe the testing performed with this additional patch/option? ** Changed in: cinder (Ubuntu Jammy) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-07-03 Thread Chengen Du
@mfo I have introduced a configuration option, 'enable_flatten_children_deletion', to enable RBD flatten operations during delete_volume/delete_snapshot calls (default is False). Please take a look and proceed with the SRU process. Thanks for your continued support. ** Patch added:

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-06-27 Thread Mauricio Faria de Oliveira
Hi Ed and Chengen, Ed, thanks for your review and feedback. > I think that to make this patch really same some guardrails should be put in place. > it might have been safer to make this an optional feature, defaulting to disabled This also aligns with Dan's feedback (internal): > there are

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-06-24 Thread Edward Hope-Morley
Thanks @mfo i think your two concerns are valid. This patch does create the risk that a user, in deleting a single volume, could overwhelm the Ceph cluster. It is not uncommon for production Ceph clusters to be reasonably full and with this patch if you happen to delete a large volume that has a

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-06-12 Thread Mauricio Faria de Oliveira
Chengen, Now the changes review notes: This patch is concerning for a couple of reasons, if I understand correctly: 1) behavior changes that are potentially impactful to the storage backend; 2) new requirements for the deployment configuration that might seriously impact the deployment. In

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-06-12 Thread Mauricio Faria de Oliveira
Hi Chengen, Thanks for your work on this bug / fix / SRU template! Some process review notes: In the future, please update the bug tasks for the newer/devel releases as well. In this case, Mantic not marked as Won't Fix possibly would require you an extra round-trip during the review with the

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-06-12 Thread Mauricio Faria de Oliveira
** Also affects: cinder (Ubuntu Mantic) Importance: Undecided Status: New ** Also affects: cinder (Ubuntu Noble) Importance: Undecided Status: New ** Also affects: cinder (Ubuntu Oracular) Importance: Undecided Status: New ** Changed in: cinder (Ubuntu Mantic)

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-06-12 Thread Mauricio Faria de Oliveira
** Description changed: [Impact] Deleting a volume will fail if it has snapshot or volume children, resulting in an ImageBusy error. [Fix] Upstream has a patch that uses RBD flatten operations to break dependencies between volumes and snapshots, reducing failures when using RBD

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-06-12 Thread Mauricio Faria de Oliveira
** Description changed: [Impact] Deleting a volume will fail if it has snapshot or volume children, resulting in an ImageBusy error. [Fix] Upstream has a patch that uses RBD flatten operations to break dependencies between volumes and snapshots, reducing failures when using RBD

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-05-30 Thread Ubuntu Foundations Team Bug Bot
The attachment "lp1969643-cinder-jammy.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch"

[Bug 1969643] Re: RBD: Unable to delete a volume which has snapshot/volume children

2024-05-30 Thread Chengen Du
Debdiff for Jammy ** Also affects: cinder (Ubuntu) Importance: Undecided Status: New ** Also affects: cinder (Ubuntu Jammy) Importance: Undecided Status: New ** Description changed: - With the RBD driver, in this scenario: + [Impact] + Deleting a volume will fail if it has