Public bug reported:
SRU Justification:
[Impact]
The mlxbf_gige driver does not utilize the msglvl infrastructure, so
there is no way to dynamically enable/disable certain debug log entries
from the driver.
[Fix]
The fix is to add logic for setting a default msglvl, providing support
for get/set of msglvl via ethtool, and updating certain driver paths
with netif_msg_XXX checks before logging of driver internals.
The driver currently supports the following msglvl settings:
link 0x004 (set by default)
ifup 0x020 (set by default)
rx_status 0x800
rx_err 0x040 (set by default)
tx_err 0x080 (set by default)
tx_done 0x400
tx_queued 0x100
[Test Case]
Boot BF2/BF3 with mlxbf_gige driver containing this patch
Verify "ethtool oob_net0" shows default msglvl in output
e.g. "Current message level: 0x000000e4 (228)
link ifup rx_err tx_err"
Verify that dmesg output shows log entries from driver, e.g.
mlxbf_gige MLNXBF17:00: open: start state tx_ci=0x0 tx_pi=0x0 rx_ci=0x0
rx_pi=0x0 int_mask=0x1
mlxbf_gige MLNXBF17:00: din_drop=0x0 rx_dma=0x4000000 rx_fifo=0x0
rx_polarity=0
Verify that setting new value via "ethtool -s oob_net0 msglvl <value>"
is reflected in output of "ethtool oob_net0"
Verify driver is fully functional after enabling various msglvl settings
[Regression Potential]
Since this is a debug feature that adds to kernel log, there is
potential for causing regression (e.g. spamming log) if the
msglvl is not set appropriately during certain test cases.
** Affects: linux-bluefield (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2101193
Title:
mlxbf_gige: msglvl infrastructure
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-bluefield/+bug/2101193/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
