Hi ek2,
No I don't think so, you don't specify the verison of ksh93 that you looked
at,
I've gone pack to ksh93r which looks like it's from a bit before you reported
it and that has the code you list,
at line 519 - of name.c, not main.c :
514
Agreed. to be honest I can't remember the version number or context I had in
mind - has been 4-5 years :)
your comments make sense though and yes the code is unfortunately ugly.
Admittedly that snip
'else if(np=nq)'
is efficient and annoying simultaneously.
--
You received this
Hi there,
I completely forgot that bug report. Looking at the code it does look changed
to me. there is a check
under the assignment (second if statement) that wasn't there as I can see in my
original post. Shouldn't that be
changed to fixed rather than invalid?
--
You received this bug
I'm not convinced this is a bug (although please check my reasoning);
the code is still present in ast-ksh.2012-09-11 upstream source but has
moved to name.c around line 1201.
That (horrible) block of code is:
1if((nq = (*fp-disc-createf)(np,cp+1,flags,fp)) ==
np)
Sorry, missed one line - what that if (np=nq) is really doing is assigning
the new nq from line (1) to np, and simultaneously
checking if the new nq is null.
Dave
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to the bug report.
** Changed in: ksh (Ubuntu)
Assignee: Kees Cook (keescook) = (unassigned)
Status: Incomplete = New
** Visibility changed to: Public
** This bug is no longer flagged as a security issue
--
Assigning instead of Comparing
https://bugs.launchpad.net/bugs/218837
You received this bug
