[Bug 255255] Re: blkid library detects JFS partition as FAT32

2009-04-14 Thread Julien Plissonneau Duquene
Fix released in 1.41.2-1ubuntu1. ** Changed in: e2fsprogs (Ubuntu) Status: New => Fix Released -- blkid library detects JFS partition as FAT32 https://bugs.launchpad.net/bugs/255255 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-09-06 Thread Theodore Ts'o
Note: a fix for this bug was released in e2fsprogs 1.41.1. -- blkid library detects JFS partition as FAT32 https://bugs.launchpad.net/bugs/255255 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@li

Re: [Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-25 Thread Theodore Ts'o
On Mon, Aug 25, 2008 at 11:22:43PM -, boga wrote: > So I guess your latest idea is correct: if a boot sector looks like > FAT12/16 and contains "JFS " or "HPFS " at 0x36 then it is not > FAT. However are you sure about memcmp(ms->ms_magic, "JFS ", 8) and > memcmp(ms->ms_magic, "HPFS ", 8) ? Th

[Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-25 Thread boga
Theodore, DFSee seems to have originated as an OS/2 partition management utility so there's no wonder it simulates OS/2 UHPFS.DLL/UJFS.DLL behaviour. I've made some tests and the problem seems to involve only those file systems (e.g. when creating an ext2/ext3/reiser partition DFSee simply fills

Re: [Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-24 Thread Theodore Ts'o
On Sun, Aug 24, 2008 at 11:28:42AM +0100, Jan van Wijk wrote: > >Hmm, looking at what you sent me, it looks like DFSee was being > >"clever". It looks like it deliberately put something which looks > >like almost exactly like a FAT12/FAT16 header, passing all of the > >normal checks one might make

Re: [Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-23 Thread Theodore Ts'o
On Wed, Aug 06, 2008 at 03:34:30PM -, boga wrote: > May be you can improve JFS test strength by adding check for the correct > relations between the superblock fields: s_bsize, s_l2bsize, > s_l2bfactor, s_pbsize, s_l2pbsize? This is also a good idea, even if I don't move the probe order of the

Re: [Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-23 Thread Theodore Ts'o
FYI, this is what I've checked into the e2fsprogs git repository. - Ted commit 8305cdf401b05e3748b87d0b63c4fa5bad8f8eb6 Author: Theodore Ts'o <[EMAIL PROTECTED]> Date: Sat Aug 23 22:11:01 2008 -0400 libblkid: Fix false detection of DFSee cr

Re: [Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-23 Thread Theodore Ts'o
(Sorry for the delay in getting back to you; I've been travelling.) Hmm, looking at what you sent me, it looks like DFSee was being "clever". It looks like it deliberately put something which looks like almost exactly like a FAT12/FAT16 header, passing all of the normal checks one might make for

[Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-06 Thread boga
May be you can improve JFS test strength by adding check for the correct relations between the superblock fields: s_bsize, s_l2bsize, s_l2bfactor, s_pbsize, s_l2pbsize? -- blkid library detects JFS partition as FAT32 https://bugs.launchpad.net/bugs/255255 You received this bug notification becaus

[Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-06 Thread boga
I've attached it to the e-mail listed in your profile. -- blkid library detects JFS partition as FAT32 https://bugs.launchpad.net/bugs/255255 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.

[Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-06 Thread Theodore Ts'o
Can you send me the first 64k of the device? i.e.: sudo dd if=/dev/sdb5 of=/tmp/jfs.img bs=64k count=1 And then upload /tmp/jfs.img I have no doubt that moving the JFS-related entry before the VFAT entry will solve the problem, but the probe_fat_nomagic() does a lot of tests before concluding

[Bug 255255] Re: blkid library detects JFS partition as FAT32

2008-08-06 Thread boga
Studying lib/blkid/probe.c: the problem occurs because the JFS partition matches the type_array[] entry: { "vfat", 0, 0x1fe, 2, "\125\252", probe_fat_nomagic }, The problem can be fixed by moving JFS-related entry before this VFAT entry. ** Attachment added: "Fix for JFS det