[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-27 Thread Launchpad Bug Tracker
This bug was fixed in the package xorg-server - 2:1.6.0-0ubuntu5 --- xorg-server (2:1.6.0-0ubuntu5) jaunty; urgency=low [Tormod Volden] * Disable 160_log_timestamping.patch before the beta, this was only used for testing, and the patch also has a serious stack corruption bug.

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-25 Thread Matt Zimmerman
Marking as Fix Committed, as slangasek said there is an upload in the queue for post-beta. Perhaps Bryce could paste the changelog entry here for reference ** Changed in: xorg-server (Ubuntu Jaunty) Status: Triaged = Fix Committed -- X server crash: *** glibc detected *** free(): in

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-25 Thread Martin Pitt
For the record, this is http://launchpadlibrarian.net/24314246/xorg-server_1.6.0-0ubuntu5_source.changes xorg-server (2:1.6.0-0ubuntu5) jaunty; urgency=low . [Tormod Volden] * Disable 160_log_timestamping.patch before the beta, this was only used for testing, and the patch also has

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Matt Zimmerman
I just realized a new element that all of these scenarios have in common: the screensaver. The screensaver is activated when coming back from resume. The crash during installation happened at just about the point where the screensaver activated due to an activity timeout (I noticed during my

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Chris Jones
Matt: if it is screensaver related, it's probably not because of some 3D parts - I have a blank screen and am seeing this, although I've yet to find a log of it (perhaps just because of a lack of retention of Xorg logs for very long, which is something I filed separately a while ago as Bug

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Robert Jordens
I get this crash on resume from time to time. But I also get a crash with the same symptoms on switching between the internal LVDS and an external VGA with xrandr but without a suspend/resume. -- X server crash: *** glibc detected *** free(): in valid next size (fast)

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Tormod Volden
I got suspicious when I saw LogVMessageVerb in the backtrace, which I have touched recently myself... Sure enough I did not think about the possibility of clocks going backwards (which they sometimes do after resume) when I worked on the timestamp stuff and you end up with nice timestamps (like

Re: [Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Matt Zimmerman
On Tue, Mar 24, 2009 at 12:27:07PM -, Tormod Volden wrote: I got suspicious when I saw LogVMessageVerb in the backtrace, which I have touched recently myself... Sure enough I did not think about the possibility of clocks going backwards (which they sometimes do after resume) when I worked

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Matt Zimmerman
Assigning back to Bryce as this has turned out to be a server bug after all ** Changed in: xorg-server (Ubuntu Jaunty) Sourcepackagename: xserver-xorg-video-intel = xorg-server Assignee: (unassigned) = Bryce Harrington (bryceharrington) -- X server crash: *** glibc detected *** free(): in

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Tormod Volden
The timestamps are useful for testing, but we do not want to use a different log format than upstream (for upstreaming of bug reports, automatic processing of logs, googling etc). I'll fix the bug anyway, we can use the timestamping in our development versions. -- X server crash: *** glibc

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Tormod Volden
Here is a debdiff that disables the timestamp patch for now. ** Attachment added: xorg-server_1.6.0-0ubuntu5.debdiff http://launchpadlibrarian.net/24308920/xorg-server_1.6.0-0ubuntu5.debdiff -- X server crash: *** glibc detected *** free(): in valid next size (fast)

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Tormod Volden
This alternative debdiff also fixes the timestamping, in that it deals with negative time deltas or large positive ones. ** Attachment added: xorg-server_1.6.0-0ubuntu5.debdiff http://launchpadlibrarian.net/24310497/xorg-server_1.6.0-0ubuntu5.debdiff -- X server crash: *** glibc detected ***

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Tormod Volden
Changed it a bit so it resets the stopwatch when the time has gone backwards. ** Attachment added: xorg-server_1.6.0-0ubuntu5.debdiff http://launchpadlibrarian.net/24311966/xorg-server_1.6.0-0ubuntu5.debdiff -- X server crash: *** glibc detected *** free(): in valid next size (fast)

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Bryce Harrington
Interesting, it seems my initial analysis in comment #5 was not far off. For now I've opted to drop the patch with tormod's debdiff in comment #51. I've uploaded this, but defer to slangasek's discretion in including it for beta. (I favor dropping it in beta myself but know that time is short,

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Bryce Harrington
kees bryce: this updated patch for 160 will avoid the overflow creep: http://pastebin.osuosl.org/25076 kees bryce: but I don't think upstream will take it, due to the asprintf use. ** Attachment added: 25076.txt http://launchpadlibrarian.net/24315629/25076.txt -- X server crash: *** glibc

[Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Kees Cook
With whitespace intact... For note, the %5d is the problem -- it can grow beyond 5 digits. I recommend asprintf, since it will calculate lengths automatically. If not, please always use snprintf. ** Attachment added: 160_log_timestamping.patch

Re: [Bug 328035] Re: X server crash: *** glibc detected *** free(): in valid next size (fast)

2009-03-24 Thread Steve Langasek
On Tue, Mar 24, 2009 at 08:15:56PM -, Bryce Harrington wrote: Interesting, it seems my initial analysis in comment #5 was not far off. For now I've opted to drop the patch with tormod's debdiff in comment #51. I've uploaded this, but defer to slangasek's discretion in including it for