[Bug 458872] Re: Don't mark for removal manually installed packages

2012-12-10 Thread Barry Warsaw
** Changed in: computer-janitor (Ubuntu) Status: Triaged = Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/458872 Title: Don't mark for removal manually installed packages To manage

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-18 Thread Michael Vogt
We are indeed a bit close to the release by now. One relatively straightforward fix would be to patch python-apt/gdebi/aptaemon so that the install_deb code writes the packagename into /var/lib/apt/notjunk (or manualdownlaoded or something like this). The CJ could honor that. This would not catch

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-18 Thread Milan Bouchet-Valat
That would sure be nice, but one of the use cases where dpkg is called directly is when installing libdvdcss2: this is one of the worst cases since people won't notice they actually need this package, which was installed automatically by a script. -- You received this bug notification because

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Till Kamppeter
** Changed in: computer-janitor (Ubuntu) Importance: Medium = High ** Changed in: computer-janitor (Ubuntu) Milestone: None = ubuntu-11.04 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/458872

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Barry Warsaw
What's causing this is that the CJ unsupported_plugin.py cruft finder plugin will match on all manually installed packages. If you look at the code http://tinyurl.com/3sxhhhx you'll see that the plugin even admits that this will happen, but doesn't really provide a way to prevent it. I'm not

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Till Kamppeter
Why not simply only suggest the packages for removing which sudo apt- get autoremove would remove? It never suggested for me to remove any manufacturer-supplied printer drivers or other third-party packages. Your suggestion to whitelist the packages which are installed without using apt does not

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Michael Vogt
@Ian: if you installed vim-full manually via apt-get install apt should have marked it as a manual install. It would be nice to get the /var/lib/apt/extended_states file from your system. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Michael Vogt
The probem describe in #4 is that a package installed with dpkg or gdebi is not downloadable most of the time (because there is no repository associated with it. This is why CJ considers it potentially obsolete. -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Michael Vogt
The long term solution should be that a package records its origin in the extended_states file. As a short term solution we can just disable the plugin as the auto-removable plugin will take care of most of the important cases. Its currently impossible for the code to distinguish between a package

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Till Kamppeter
I have now done a test of triggereing a printer driver auto-download with Jockey and directly after that I have started computer-janitor and the newly installed driver is not on the list of packages to remove. So it seems Jockey has installed the driver with apt. But if I click on a driver

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Barry Warsaw
mvo barry: I agreed with what you said in the bugreport, its not a regression in any way, the long term solution should be to record if it was a install via dpkg or not [15:13] mvo barry: TBH I don't understand it, or rather I think the result is/will be that all installed

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Till Kamppeter
Barry, can we perhaps simply deactivate this plugin for Natty? And get it later in again if it gets more sensitive in deciding what can be removed and what not? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Barry Warsaw
I'm reluctant to do that because that could be considered a regression and we won't have another beta to test it out. Please note that you can always whitelist the package manually by adding a file called /etc /computer-janitor.d/whatever.whitelist That may in fact lead to an interesting

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-15 Thread Milan Bouchet-Valat
Regression is very relative. I think in this precise case we can easily anticipate the costs and benefits of such a change without requiring user testing. Few people will complain that CJ doesn't remove this kind of obsolete packages, and if they really know they want to get rid of them, they can

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-04-02 Thread Launchpad Bug Tracker
** Branch linked: lp:~r.phate/computer-janitor/bug-458872 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/458872 Title: Don't mark for removal manually installed packages -- ubuntu-bugs mailing

[Bug 458872] Re: Don't mark for removal manually installed packages

2011-01-19 Thread Christoph Buchner
In the dupe bug #704385, a user lost paid software because CJ uninstalled it. This behaviour should be dealt with soon. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/458872 Title: Don't mark for

[Bug 458872] Re: Don't mark for removal manually installed packages

2010-04-14 Thread Milan Bouchet-Valat
Confirmed. It seems that even packages you installed manually using dpkg -i or GDebi are considered as obsolete. This means from the moment you installed them, CJ wants to remove them. I guess there's a way to find out whether they were installed from a repository that is now disabled, or if the