[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-06-24 Thread Michael K. Edwards
It seems that the ordered primitives do need fixing, as dmart suggests; for confirmation see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48126 . I would also think that the ref()/deref() methods should have ordered semantics, since they function like locks (a caller which sees deref() return 0 is e

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-05-24 Thread Jani Monoses
The patch in Ubuntu 11.04 is backported from upstream Qt4.8. If upstream is mistaken, one of the persons who actually have a clue about the fine details of ARMv7 memory barriers (not me) should educate upstream as was suggested in a previous comment. The Ubuntu bug tracker may be watched but un

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-04-06 Thread Dave Martin
The upstream commit looks at least semi-sane -- it looks like the memory barrier stuff is merged in lp:ubuntu/qt4-x11, is my understanding correct? I also generally agree with upstream's view that they don't want to port to the GCC primitives: since Qt already has a pretty decent atomics API, and

Re: [Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-03-14 Thread Scott Kitterman
If upstream is mistaken, please educate them, but we should get agreement in principle before we commit to the change. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomic

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-03-14 Thread Michael K. Edwards
I believe that upstream is mistaken. It is not safe to allow other memory accesses to be speculated into the ldrex/strex region, and (at least on Cortex A9/A15) the only way to prevent that is to issue full memory barriers before and after. Arguably the compiler should be allowed to move memory a

Re: [Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-03-14 Thread Scott Kitterman
Please see https://bugs.launchpad.net/ubuntu/+source/qt4-x11/+bug/490371/comments/6 - I 'm not sure if it relevant or not, but it sounds like upstream has some concerns. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. htt

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-03-14 Thread Michael K. Edwards
Alternately, one could use the GCC intrinsics. They are more conservative about memory barriers, which I believe to be more correct in any case (it is not safe to let the compiler or the instruction scheduler move memory accesses into the ldrex/strex critical region). Other than memory barrier dif

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-03-10 Thread Jani Monoses
Backported memory barrier changes from Qt master branch. ** Changed in: qt4-x11 (Ubuntu Natty) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. https://bugs.launchpad.net/bugs/4903

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-03-03 Thread Jani Monoses
** Changed in: qt4-x11 (Ubuntu Natty) Assignee: Canonical ARM (canonical-arm) => Jani Monoses (jani) -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomic operations no

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-03-01 Thread Martin Pitt
** Changed in: qt4-x11 (Ubuntu Natty) Milestone: natty-alpha-3 => ubuntu-11.04-beta-1 ** Changed in: qt4-x11 (Ubuntu Natty) Assignee: (unassigned) => Canonical ARM (canonical-arm) -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-02-14 Thread Steve Langasek
** Tags added: arm-porting-queue -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomic operations not safe for ARMv7,Thumb-2 and multicore -- ubuntu-bugs mailing list ubuntu-bugs@list

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-02-04 Thread Martin Pitt
** Changed in: qt4-x11 (Ubuntu Natty) Milestone: natty-alpha-2 => natty-alpha-3 -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomic operations not safe for ARMv7,Thumb

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2011-01-03 Thread Jani Monoses
Filed in the Qt issue tracker, but since LP does not recognize it here's the link http://bugreports.qt.nokia.com/browse/QTBUG-16402 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomi

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-12-10 Thread Kate Stewart
** Changed in: qt4-x11 (Ubuntu Natty) Milestone: natty-alpha-1 => natty-alpha-2 -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomic operations not safe for ARMv7,Thumb

Re: [Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-12-09 Thread Scott Kitterman
Provide Thumb2 support on armel - See LP Bug #673085 for details Index: qt-everywhere-opensource-src-4.7.1/src/corelib/arch/qatomic_armv6.h === --- qt-everywhere-opensource-src-4.7.1.orig/src/corelib/arch/qatomic_armv6.h 2010-1

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-12-09 Thread Jammy Zhou
Scott, Could you please also post the patch here? -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomic operations not safe for ARMv7,Thumb-2 and multicore -- kubuntu-bugs

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-12-08 Thread Thiago Macieira
Please submit the patch upstream: http://bugreports.qt.nokia.com, product Qt, component Threading. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomic operations not safe

Re: [Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-12-08 Thread Scott Kitterman
On Wednesday, December 08, 2010 01:57:49 am you wrote: > It seems that "-Wa,-mimplicit-it=thumb" should be added to CXXFLAGS for > armv7 No. We've a patch to add the explicit IT instructions so this isn't needed. -- You received this bug notification because you are a member of Kubuntu Bugs, wh

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-12-07 Thread Jammy Zhou
It seems that "-Wa,-mimplicit-it=thumb" should be added to CXXFLAGS for armv7 -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomic operations not safe for ARMv7,Thumb-2 and

Re: [Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-12-07 Thread Scott Kitterman
There's a patch for that in the Ubuntu qt4-x11 package in Natty. I don't believe it's upstream yet. -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. https://bugs.launchpad.net/bugs/490371 Title: Atomic operations not sa

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-12-07 Thread Jammy Zhou
Hi Thiago, I tried to compile Qt4.8 on armv7 platform locally, but meet following new error message, do you have any suggestions? make[1]: Entering directory `/home/jammy/qt/src/corelib' g++ -c -include .pch/release-shared/QtCore -pipe -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-11-13 Thread Matthias Klose
** Changed in: qt4-x11 (Ubuntu) Milestone: None => natty-alpha-1 ** Also affects: qt4-x11 (Ubuntu Natty) Importance: Medium Status: In Progress -- Atomic operations not safe for ARMv7,Thumb-2 and multicore https://bugs.launchpad.net/bugs/490371 You received this bug notification be

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-07-12 Thread Loïc Minier
** Tags added: thumb -- Atomic operations not safe for ARMv7,Thumb-2 and multicore https://bugs.launchpad.net/bugs/490371 You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-06-20 Thread Michael Casadevall
** Changed in: qt4-x11 (Ubuntu) Assignee: Michael Casadevall (mcasadevall) => (unassigned) -- Atomic operations not safe for ARMv7,Thumb-2 and multicore https://bugs.launchpad.net/bugs/490371 You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-03-30 Thread Paul Larson
** Tags added: patch -- Atomic operations not safe for ARMv7,Thumb-2 and multicore https://bugs.launchpad.net/bugs/490371 You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to qt4-x11 in ubuntu. -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-03-30 Thread Dave Martin
This patch adds memory barriers to the existing armv6-based atomics implementation. This is a quicker interim fix than porting the code to use the GCC atomics, but that could still be addressed later. The change is conservative: a barrier is added both before and after the body of each atomic. T

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-03-04 Thread Michael Casadevall
** Changed in: qt4-x11 (Ubuntu) Status: Triaged => In Progress ** Changed in: qt4-x11 (Ubuntu) Assignee: (unassigned) => Michael Casadevall (mcasadevall) -- Atomic operations not safe for ARMv7,Thumb-2 and multicore https://bugs.launchpad.net/bugs/490371 You received this bug notific

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-02-25 Thread Alexander Sack
from what i understand we need to make build system aware of v7 to backout the armv6 workaround. -- Atomic operations not safe for ARMv7,Thumb-2 and multicore https://bugs.launchpad.net/bugs/490371 You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-02-10 Thread Dave Martin
The affected code still needs to be reviewed for SMP-safety, but this is not high priority for lucid. -- Atomic operations not safe for ARMv7,Thumb-2 and multicore https://bugs.launchpad.net/bugs/490371 You received this bug notification because you are a member of Kubuntu Bugs, which is subscrib

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2010-02-10 Thread Colin Watson
We fixed the armv6 configuration part of this bug a little while ago. Changelog: qt4-x11 (4:4.6.0-1ubuntu2) lucid; urgency=low * Make libqt4-dev depend on libx11-dev * In debian/rules Set DEB_HOST_ARCH and DEB_HOST_ARCH_OS. Configure with "-arch armv6" option on ARM -- Jonathan Riddell T

[Bug 490371] Re: Atomic operations not safe for ARMv7, Thumb-2 and multicore

2009-11-30 Thread Paul Larson
Setting this at medium for now, but this might be worth revisiting when multicore chips become available if this proves to be causing big problems. ** Changed in: qt4-x11 (Ubuntu) Importance: Undecided => Medium ** Changed in: qt4-x11 (Ubuntu) Status: New => Triaged -- Atomic operatio