Looks like the issues got all addressed now, thanks! I promoted the
package now.
** Changed in: usbmuxd (Ubuntu)
Status: Incomplete = Fix Released
** Changed in: usbmuxd (Ubuntu)
Assignee: Alexander Sack (asac) = (unassigned)
--
usbmuxd required in main for libiphone
On Sat, Jan 23, 2010 at 11:22:02PM -, Hector Martin wrote:
The new version is in Git, let me know if it's acceptable and I'll make
a release.
Thanks a lot for checking and fixing these.
Any chance to also fix the compiler warnings in
Those warnings were already fixed together with the security issue.
--
usbmuxd required in main for libiphone
https://bugs.launchpad.net/bugs/494549
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
The first memcpy() is already guarded by a check right before it.
The second memcpy is potentially exploitable, I fixed that.
The third one isn't, because the length is always USB_MRU which is the
buffer size (and the buffer is empty in this case), though I added a paranoia
check anyways in
usbmuxd runs as a separate user and has udev integration; I don't quite
know whether there is a central package to add support for devices over
udev, but the approach looks good enough.
Has .symbols file, looks overall good. Apparently no testsuite.
--
usbmuxd required in main for libiphone
There are a couple of bad warnings; looks like a missing pthread include:
/build/buildd/usbmuxd-1.0.0/libusbmuxd/libusbmuxd.c:298: warning: implicit
declaration of function 'pthread_create'
--
usbmuxd required in main for libiphone
https://bugs.launchpad.net/bugs/494549
You received this bug
Packaing:
looks good.
QA:
Please subscribe desktop team to bug reports if not needed
Upstream code:
Source code wise i checked how the input data from device is processed and
found a nit:
in device_data_input the buffer bounds are not properly/explicitly
checked in daemon.c, like
in
right. the implicit declaration warnings should be fixed too
** Changed in: usbmuxd (Ubuntu)
Status: New = Incomplete
--
usbmuxd required in main for libiphone
https://bugs.launchpad.net/bugs/494549
You received this bug notification because you are a member of Ubuntu
Bugs, which is
also maybe to consider: drop_privileges should be the default when
running as root ... feels safer.
--
usbmuxd required in main for libiphone
https://bugs.launchpad.net/bugs/494549
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
** Changed in: usbmuxd (Ubuntu)
Assignee: (unassigned) = Alexander Sack (asac)
--
usbmuxd required in main for libiphone
https://bugs.launchpad.net/bugs/494549
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing
10 matches
Mail list logo
