go to:
https://bugs.launchpad.net/firefox/+bug/612377/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
to:
https://bugs.launchpad.net/firefox/+bug/612377/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
] libjpeg-turbo
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/612377/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Security team finished fuzzing as planned, we are good here.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
FYI, the Chrome team has apparently done a security review of the library:
http://code.google.com/p/chromium/issues/detail?id=48789#c3
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
Jesse, why did you nominate this bug for tracking-firefox5?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
Because bsmedberg told me to in
http://groups.google.com/group/mozilla.dev.planning/msg/bfc2fabaecacdd97.
Also because I think it should be listed on
https://wiki.mozilla.org/Features/Release_Tracking to make sure it gets
the right security reviews, license file additions, changelog entries,
crash
NOTE: libjpeg-turbo trunk now contains a version of jchuff.c
(Huffman encoder) with the optimizations re-written and re-licensed under the
same BSD-style license as the rest of libjpeg.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
... and the bug for tracking that is bug 650899.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
That bug is for tracking the decoder. I'm talking about the encoder
now.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
NOTE: libjpeg-turbo trunk now contains a version of jdhuff.c and
jdhuff.h (Huffman decoder) with the optimizations re-written and re-
licensed under the same BSD-style license as the rest of libjpeg.
Looking into jchuff* as well, but I figured you were probably more
interested in the decoder than
I've filed bug 650899 for updating libjpeg-turbo.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
FYI: 1.1.0 version was released as stable some time ago
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
Bug on integration libjpeg-turbo in Google Chrome, already have status
verified fixed...
http://code.google.com/p/chromium/issues/detail?id=48789
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Maybe a different reviewer should be assigned to possibly get this in
for Fx5.0?
According to the draft plan for the new development process, the 5.0
branch could be cut early(3 weeks).
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
(In reply to comment #144)
Maybe a different reviewer should be assigned to possibly get this in for
Fx5.0?
Jeff, you reviewing?
/be
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
(In reply to comment #145)
(In reply to comment #144)
Maybe a different reviewer should be assigned to possibly get this in for
Fx5.0?
Jeff, you reviewing?
/be
I've completed a large chunk of the review. I haven't had time to get to
the rest of it yet. I am hoping to for 5.
-Jeff
--
I'll be starting full-time on 3/28, so I'll be able to update the patch
and whatnot then.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
Comment on attachment 471713
Patch v1.3.1
I did not review the simd code as that's more work and lower risk
because it's mostly just optimized versions of existing functions. I did
go through the rest of the stuff, hopefully I was thorough enough (there
was a lot of change).
A few of these
I strongly suggest updating libjpeg-turbo from 1.0.0 to 1.1.0 before
taking time on complete reviewing. It will be wiser because many changes
where made.
Significant changes since 1.0.0:
[1] The Huffman decoder will now handle erroneous Huffman codes (for
instance, from a corrupt JPEG image.)
Per comment 147, I intend to update to the new version before checking
in. That sound good to you, Jeff?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
(In reply to comment #150)
Per comment 147, I intend to update to the new version before checking in.
That sound good to you, Jeff?
That's fine. An interdiff would to have for a quick look over. Also, one
thing that I forgot to mention in the review comments. I'd prefer that
we only include
diff --git a/jpeg/jpeglib.h b/jpeg/jpeglib.h
-#ifdef XP_OS2
-/*
- * On OS/2, the system will have defined RGB_* so we #undef 'em to avoid
warnings
- * from jmorecfg.h.
- */
-#ifdef RGB_RED
- #undef RGB_RED
-#endif
-#ifdef RGB_GREEN
- #undef RGB_GREEN
-#endif
-#ifdef RGB_BLUE
-
(In reply to comment #148)
Comment on attachment 471713 [details]
Patch v1.3.1
[snip]
diff --git a/jpeg/jcdctmgr.c b/jpeg/jcdctmgr.c
--- a/jpeg/jcdctmgr.c
+++ b/jpeg/jcdctmgr.c
/*
+ * Find the highest bit in an integer through binary search.
+ */
+LOCAL(int)
+flss (UINT16 val)
+{
(In reply to comment #152)
Do you mean upstream of libjpeg-turbo, i.e., in libjpeg? libjpeg-turbo is a
fork of an old version of libjpeg, so there's really no upstream to speak
of.
I meant upstream in libjpeg-turbo instead of patching our local copy.
--
You received this bug notification
Oh, I see; that's a change we made, but which isn't in libjpeg-turbo.
Until it's fixed upstream, why don't we just guard the #define's in
jmorecfg.h? We already keep that file out of sync with libjpeg-turbo's
mainline.
--
You received this bug notification because you are a member of Ubuntu
(In reply to comment #155)
Oh, I see; that's a change we made, but which isn't in libjpeg-turbo.
Until it's fixed upstream, why don't we just guard the #define's in
jmorecfg.h?
We already keep that file out of sync with libjpeg-turbo's mainline.
That sounds fine.
--
You received this
Created attachment 522445
Patch v2.0. Part 1: Upgrade to libjpeg-turbo v1.1.0
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing
Created attachment 522446
Patch v2.0. Part 2: Address review comments.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
Created attachment 522449
Interdiff v1.3.1 - v2.0 part 1
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
Created attachment 522459
Interdiff v1.3.1 - v2.0 part 1 without deleted files
This interdiff is the same as attachment 522449, but it doesn't include
the files I deleted, in an attempt to make it easier to read.
--
You received this bug notification because you are a member of Ubuntu
Bugs,
DRC, what would be a good medium for handling Jeff's remaining review
comments?
I'm going to push the latest patches to try now.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
Created attachment 522544
Proposed upstream patch for addressing concern about jround_up() argument types.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging]
I'll address the review comments that are relevant to the upstream code
here:
(1) jround_up() argument types: this was the result of a bad game of
Celebrity Whack-a-Mole that I played while trying to port the code to
Win64. Jeff's idea of creating a local, power-of-2-specific round-up
function
And just FYI, another thing that I'm currently being contracted to do is
investigate rewriting the performance optimizations in j{c|d}huff*.
This will hopefully allow me to re-license those files in libjpeg-turbo
1.2.
--
You received this bug notification because you are a member of Ubuntu
Bugs,
(2) RGB_{RED|GREEN|BLUE} macro conflicts on OS/2 (OS/2? Really?): This seems
like an innocuous enough patch, although I'd rather have it in jmorecfg.h
instead of jpeglib.h.
Attachment 522446 puts the #undef's in jmorecfg.h, right above the
#defines.
--
You received this bug notification
Comment on attachment 522544
Proposed upstream patch for addressing concern about jround_up() argument types.
+#define PAD(size, align) (((size) + (align) - 1) (~((align) - 1)))
I usually prefer functions over macros for the additional type safety
and to avoid evaluating arguments twice (e.g.
(In reply to comment #163)
(2) RGB_{RED|GREEN|BLUE} macro conflicts on OS/2 (OS/2? Really?): This seems
like an innocuous enough patch, although I'd rather have it in jmorecfg.h
instead of jpeglib.h. I'd also like to know more of the back story as to why
OS/2 is defining those macros. Is
Created attachment 522583
New proposed upstream patch for addressing concern about jround_up() argument
types.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging]
(In reply to comment #165)
And just FYI, another thing that I'm currently being contracted to do is
investigate rewriting the performance optimizations in j{c|d}huff*. This will
hopefully allow me to re-license those files in libjpeg-turbo 1.2.
This sounds great.
--
You received this bug
(In reply to comment #166)
+#define PAD(size, align) (((size) + (align) - 1) (~((align) - 1)))
I usually prefer functions over macros for the additional type safety and to
avoid evaluating arguments twice (e.g. PAD(x, a++))
My experience has been that the compiler does a good job of
(In reply to comment #170)
(In reply to comment #166)
+#define PAD(size, align) (((size) + (align) - 1) (~((align) - 1)))
I usually prefer functions over macros for the additional type safety and to
avoid evaluating arguments twice (e.g. PAD(x, a++))
My experience has been that the
There are unfortunately reftest failures on Windows with this latest
patch. Looking into it.
http://tbpl.mozilla.org/?tree=MozillaTryrev=fceae635d617
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1301360568.1301363938.582.gz
--
You received this bug notification because you are a
Ah, the orange is due to unexpected success. That's not so bad. :)
I think we can just back out bug 582850.
http://hg.mozilla.org/mozilla-central/rev/4643426a1523
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Yep, and this should close bug 477728
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
Created attachment 522674
Patch v2.0 Part 3: Re-enable reftests on Windows.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
Don't we need to use the libjpeg v8 ABI in order to get this?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
Why is support for arithmetic encoding/decoding disabled?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
(In reply to comment #176)
Why is support for arithmetic encoding/decoding disabled?
We haven't decided whether to enabled this yet. This is a separate issue
and needs a separate bug as well as a lot more thought/research.
--
You received this bug notification because you are a member of
(In reply to comment #177)
Don't we need to use the libjpeg v8 ABI in order to get this?
No, it works when emulating the v6b ABI as well. It just adds two
additional functions without breaking compatibility with the rest of the
ABI.
--
You received this bug notification because you are a
http://hg.mozilla.org/mozilla-central/rev/6a8baba56a65
http://hg.mozilla.org/mozilla-central/rev/3eb5a574319f
Please file follow-ups as needed.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Apparently this causes OOM in yasm 0.8.something we may need to up the
min version
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs
More specifically, with yasm 0.8.0.2194, which is the latest available
by default with Ubuntu 10.04. yasm 1.1.0.2352 works fine.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
Fedora 13 has old yasm too
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
(Though, honestly we'd really prefer to make it buildable with nasm, or
gas. But that's another bug...)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
** Changed in: firefox
Status: In Progress = Fix Released
** Bug watch added: code.google.com/p/chromium/issues #48789
http://code.google.com/p/chromium/issues/detail?id=48789
** Bug watch added: SourceForge.net Tracker #3249446
http://sourceforge.net/support/tracker.php?aid=3249446
** Also affects: firefox via
https://bugzilla.mozilla.org/show_bug.cgi?id=573948
Importance: Unknown
Status: Unknown
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
It's also available in my ppa:tom-gall/packages.
Like Steve, I haven't been able to replicate any issues but thus far
I've been testing on armel.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
If anyone is seeing the same problem as williamts99 (who is not
subscribed to this bug), could you please provide a copy of
/proc/cpuinfo from the affected system, and a copy of an example pdf
that the problem is reproducible with?
If possible, please also try building a package from the git
did you install from source or are there any debian (source) packages
around?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
ubuntu-bugs mailing
ah sorry, found some at: http://sourceforge.net/projects/libjpeg-
turbo/files/1.0.90%20(1.1beta1)/
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/612377
Title:
[needs-packaging] libjpeg-turbo
--
This might need some more testing, I installed the latest libjpeg-turbo
and could not open pdf documents with document viewer. Reverted to
libjpeg62 and the problem went away.
--
[needs-packaging] libjpeg-turbo
https://bugs.launchpad.net/bugs/612377
You received this bug notification because
i hope it gets into debian and ubuntu soon. and i hope people don't
start to do what mozilla wants to do (bundle more software into their
huge monster of software). can't wait to run feh faster on my computers
to view pretty large photo images...
--
[needs-packaging] libjpeg-turbo
more speed, lower profile, greater productivity please.
--
[needs-packaging] libjpeg-turbo
https://bugs.launchpad.net/bugs/612377
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
** Bug watch added: Debian Bug tracker #602034
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=602034
** Also affects: debian via
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=602034
Importance: Unknown
Status: Unknown
--
[needs-packaging] libjpeg-turbo
** Changed in: debian
Status: Unknown = New
--
[needs-packaging] libjpeg-turbo
https://bugs.launchpad.net/bugs/612377
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
+1 for wishing this were used as the default libjpeg distro so the
various programs could benefit from it (zoneminder, for instance,
benefits greatly).
--
[needs-packaging] libjpeg-turbo
https://bugs.launchpad.net/bugs/612377
You received this bug notification because you are a member of Ubuntu
I concur. I know this is ancillary, but libjpeg-turbo sigificantly
improved/decreased my proc usage on my zoneminder install.
Also, It looks like Mozilla is working on bundling this in FF now:
https://bugzilla.mozilla.org/show_bug.cgi?id=573948
See that bug for their licensing considerations, as
I second the request.
I'm usually very skeptic about purported performance improvements, but I
did my tests on a couple of machines and I think that given the ubiquity
of JPEG pictures the upgrade to libjpeg-turbo could be one of the most
important user-visible speed improvements in the last few
libjpeg-turbo is a drop-in replacement for libjpeg, so +1
--
[needs-packaging] libjpeg-turbo
https://bugs.launchpad.net/bugs/612377
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
Fedora 14 will use libjpeg-turbo by default.
From http://fedoraproject.org/wiki/Features/libjpeg-turbo
libjpeg-turbo is at least twice faster in JPEG compression/decompression than
original libjpeg on platforms with MMX/SSE instruction set. It has same API/ABI
like original libjpeg and also
*** This is an automated message ***
This bug is tagged needs-packaging which identifies it as a request for
a new package in Ubuntu. As a part of the managing needs-packaging bug
reports specification,
https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-
packaging bug reports
** Tags added: needs-packaging
** Summary changed:
- Evalutate and package libjpeg-turbo
+ [needs-packaging] libjpeg-turbo
--
[needs-packaging] libjpeg-turbo
https://bugs.launchpad.net/bugs/612377
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed
Public bug reported:
libjpeg-turbo seems to greatly improve speed compared to libjpeg.
Read more here:
http://libjpeg-turbo.virtualgl.org/About/Performance
http://fedoraproject.org/wiki/Features/libjpeg-turbo
Maybe it would be good to package it, or at least offer it in a ppa.
** Affects:
74 matches
Mail list logo
