[Bug 618757] Re: [MIR] libgwibber

2010-08-23 Thread Sebastien Bacher
libgwibber has been promoted now ** Changed in: libgwibber (Ubuntu) Importance: Undecided => Wishlist ** Changed in: libgwibber (Ubuntu) Status: Fix Committed => Fix Released -- [MIR] libgwibber https://bugs.launchpad.net/bugs/618757 You received this bug notification because you are

[Bug 618757] Re: [MIR] libgwibber

2010-08-23 Thread Ken VanDine
** Changed in: libgwibber (Ubuntu) Status: Fix Released => Fix Committed -- [MIR] libgwibber https://bugs.launchpad.net/bugs/618757 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubu

[Bug 618757] Re: [MIR] libgwibber

2010-08-23 Thread Launchpad Bug Tracker
This bug was fixed in the package libgwibber - 0.0.6-0ubuntu1 --- libgwibber (0.0.6-0ubuntu1) maverick; urgency=low * New upstream release. - Cleaned up some compiler warnings (LP: #618757) - Use GLib.HashTable.full for creating hash tables that contain hash tables to

[Bug 618757] Re: [MIR] libgwibber

2010-08-23 Thread Alexander Sack
good. when that fix from comment 6 is uploaded this MIR is approved. feel free to set to fix committed on your own then - or ping me on irc ;) ** Changed in: libgwibber (Ubuntu) Status: New => Triaged ** Changed in: libgwibber (Ubuntu) Milestone: None => ubuntu-10.10-beta -- [MIR] li

[Bug 618757] Re: [MIR] libgwibber

2010-08-22 Thread Ken VanDine
Yeah, I'll upload a new release with the cleanups early this week. I would like to see if we uncover any bugs when people get the indicator- me version that uses it. -- [MIR] libgwibber https://bugs.launchpad.net/bugs/618757 You received this bug notification because you are a member of Ubuntu B

[Bug 618757] Re: [MIR] libgwibber

2010-08-22 Thread Alexander Sack
is there an upload scheduled this cycle from trunk? -- [MIR] libgwibber https://bugs.launchpad.net/bugs/618757 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu

[Bug 618757] Re: [MIR] libgwibber

2010-08-21 Thread Ken VanDine
Fix is applied to trunk and i fixed some other warnings as well. Bugs filed: https://bugs.edge.launchpad.net/ubuntu/+source/vala/+bug/621952 https://bugzilla.gnome.org/show_bug.cgi?id=627592 ** Bug watch added: GNOME Bug Tracker #627592 https://bugzilla.gnome.org/show_bug.cgi?id=627592 -- [M

[Bug 618757] Re: [MIR] libgwibber

2010-08-21 Thread Alexander Sack
after applying fix and double checking that a -Wall build does now properly return FALSE and filing bugs upstream and launchpad about the dbus vala "uninitialized usage" issues, i am fine with this MIR. -- [MIR] libgwibber https://bugs.launchpad.net/bugs/618757 You received this bug notification

[Bug 618757] Re: [MIR] libgwibber

2010-08-21 Thread Alexander Sack
looking at your configure.ac you should use --enable-maintainer-flags to develop locally. This would give you -Wall -Werror and all those goodies. -- [MIR] libgwibber https://bugs.launchpad.net/bugs/618757 You received this bug notification because you are a member of Ubuntu Bugs, which is subscr

[Bug 618757] Re: [MIR] libgwibber

2010-08-21 Thread Alexander Sack
the others "use of unassigned values" are vala bugs. please file them in ubuntu and upstream and drop bug ids here ... oh also, you probably didnt see these in your local build because you should always build using -Wall ... set that as a default CFLAGS in your configure.ac. to test locally you ca

[Bug 618757] Re: [MIR] libgwibber

2010-08-21 Thread Alexander Sack
events need a return to ensure that the event either continues to bubble (FALSE) or not (TRUE). patch fixes entry.vala ** Patch added: "618757.1.patch" https://bugs.edge.launchpad.net/ubuntu/+source/libgwibber/+bug/618757/+attachment/1508275/+files/618757.1.patch -- [MIR] libgwibber https://

[Bug 618757] Re: [MIR] libgwibber

2010-08-20 Thread Ken VanDine
1) My vala code for expose_view is a void. I tried just changing that to return a bool and it made no difference. Notice the function right below that in the generated C, it returns a bool and just wraps this function. Not sure why it creates both functions, but it is only consumed by the functi

[Bug 618757] Re: [MIR] libgwibber

2010-08-19 Thread Alexander Sack
for 2. one example is: gint _ecode; if (strstr (_dbus_error.name, "org.freedesktop.DBus.Error") == _dbus_error.name) { ... } g_set_error (error, _edomain, _ecode, "%s", _dbus_error.message); -- [MIR] libgwibber https://bugs.launchpad.net/bugs/618757 You received this bug notificatio

[Bug 618757] Re: [MIR] libgwibber

2010-08-19 Thread Alexander Sack
I am looking at i386. For 1. its: static gboolean _lambda0_ (GdkEventExpose* source, GwibberInputTextView* self) { gboolean result = FALSE; gwibber_input_text_view_expose_view (self, source); } -- [MIR] libgwibber https://bugs.launchpad.net/bugs/618757 You received this bug noti

[Bug 618757] Re: [MIR] libgwibber

2010-08-19 Thread Ken VanDine
I reviewed these, not sure what the right solution is for #1. I don't have any non-void functions that aren't returning something. The C code generated does create two functions for one lambda, one of which should return a gboolean but doesn't. The vala method is a void. I tried changing the va

[Bug 618757] Re: [MIR] libgwibber

2010-08-19 Thread Alexander Sack
Doesnt build on armel yet, but i think its a problem in base libs rather than libgwibber because previous version worked. There are a bunch of warnings in the build log that should be looked into: 1. no return in non-void func: entry.c:792: warning: no return statement in function returning non-v

[Bug 618757] Re: [MIR] libgwibber

2010-08-17 Thread Alexander Sack
** Changed in: libgwibber (Ubuntu) Assignee: (unassigned) => Alexander Sack (asac) -- [MIR] libgwibber https://bugs.launchpad.net/bugs/618757 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@l