[Bug 624632] Re: Don't panic when you can't mount

Thanks! I'm happy with this now, and will merge your branch. Sorry for the delay. -- Don't panic when you can't mount https://bugs.launchpad.net/bugs/624632 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list

[Bug 624632] Re: Don't panic when you can't mount

This bug was fixed in the package casper - 1.249 --- casper (1.249) natty; urgency=low [ arky ] * Add universal access preferences taskbar icon in all accessibility profiles (LP: #621561). [ Serge Hallyn ] * change scripts/casper-helpers:try_mount() to not panic when

[Bug 624632] Re: Don't panic when you can't mount

** Changed in: casper (Ubuntu) Status: Triaged = Fix Committed -- Don't panic when you can't mount https://bugs.launchpad.net/bugs/624632 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list

[Bug 624632] Re: Don't panic when you can't mount

Jinkeys that was one awful debdiff. I'll be posting a new, less embarassing one in awhile. -- Don't panic when you can't mount https://bugs.launchpad.net/bugs/624632 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs

[Bug 624632] Re: Don't panic when you can't mount

** Attachment added: Corrected debdiff for the proposed fix https://bugs.launchpad.net/ubuntu/+source/casper/+bug/624632/+attachment/1538646/+files/mydebdiff3 -- Don't panic when you can't mount https://bugs.launchpad.net/bugs/624632 You received this bug notification because you are a

[Bug 624632] Re: Don't panic when you can't mount

The above debdiff (tweaked to apply to the lucid version) solved my problem with booting a livecd with multipath. -- Don't panic when you can't mount https://bugs.launchpad.net/bugs/624632 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 624632] Re: Don't panic when you can't mount

I don't think the remount case is reliably detected though - it looks for the 3d argument to be ro, which for instance find_files() sends along, and which would continue to needlessly panic when using a vfat root device + multipath. -- Don't panic when you can't mount

[Bug 624632] Re: Don't panic when you can't mount

** Attachment added: Debdiff with a proposed fix https://bugs.launchpad.net/ubuntu/+source/casper/+bug/624632/+attachment/1535388/+files/mydebdiff -- Don't panic when you can't mount https://bugs.launchpad.net/bugs/624632 You received this bug notification because you are a member of Ubuntu

[Bug 624632] Re: Don't panic when you can't mount

(I'm going to test some builds with this proposed package before switching to 'fix committed' and asking for merge) -- Don't panic when you can't mount https://bugs.launchpad.net/bugs/624632 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 624632] Re: Don't panic when you can't mount

I'd suggest having try_mount call log_warning_msg and return 1. The caller can then decide whether it wants to panic or not (or indeed pass the error up the stack for something else to decide whether to panic or not). I'd recommend keeping the panic in the remount and bind cases, though. **

[Bug 624632] Re: Don't panic when you can't mount

I'm setting this to low priority because there is a known workaround. Colin, I'm assigning you to ask your opinion about my proposed fix, which is basically to replace the 'mount || panic' with a 'mount || echo'. If that is too lax, we could pass an extra ok_if_fails argument to try_mount. If