[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-09 Thread Kiwinote
software-center (2.1.17) maverick; urgency=low [ Gary Lasker ] * softwarecenter/view/purchasedialog.py: - make popup window a modal dialog so it works with metacity too (LP: #625398) * softwarecenter/view/softwarepane.py, softwarecenter/view/availablepane.py, softwarecenter

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-07 Thread Gary Lasker
** Changed in: software-center (Ubuntu) Status: In Progress => Fix Committed -- Terms of service window is stuck under the payment screen https://bugs.launchpad.net/bugs/625398 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- u

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-07 Thread Gary Lasker
So obviously this has been working fine for me. However, I am running Compiz on my machine. Once I had some time back home I found that when I switched to Metacity I could reproduce the problem mpt describes. mpt, I assume you're running Metacity then. I've attached a branch that implements a fi

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-07 Thread Launchpad Bug Tracker
** Branch linked: lp:~gary-lasker/software-center/popup-as-dialog -- Terms of service window is stuck under the payment screen https://bugs.launchpad.net/bugs/625398 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-07 Thread Gary Lasker
Reopening per mpt's report that this is still not working for him. ** Changed in: software-center (Ubuntu) Status: Fix Released => Triaged -- Terms of service window is stuck under the payment screen https://bugs.launchpad.net/bugs/625398 You received this bug notification because you are

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-07 Thread Launchpad Bug Tracker
This bug was fixed in the package software-center - 2.1.16 --- software-center (2.1.16) maverick; urgency=low [ Gary Lasker ] * softwarecenter/view/purchasedialog.py: - make the "Terms of Service" popup display correctly in front of the purchase dialog (LP: #625398)

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-07 Thread Matthew Paul Thomas
What is it that you want us to test, exactly? I'm 99% sure that staging server vs. production server is irrelevant to this bug. It's entirely about the kind of window that Ubuntu Software Center opens, not about the Web page displayed inside it. ** Changed in: software-center (Ubuntu) Statu

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-06 Thread Gary Lasker
Thanks for your report, mpt. Hmm, I just tried this again and it is working fine for me in rev 1119 (as it did when I first checked it in). The Terms of Service window appears centered and above the purchase dialog. It can be read, scrolled and closed when finished. In fact, it is set as modal a

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-06 Thread Matthew Paul Thomas
Not fixed in trunk r1116; reopening. Perhaps one simple way of fixing this would be to make the terms of service window a dialog as well, so that it's modal to the purchase dialog. ** Description changed: - Binary package hint: soft

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-02 Thread Launchpad Bug Tracker
** Branch linked: lp:software-center -- Terms of service window is stuck under the payment screen https://bugs.launchpad.net/bugs/625398 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubunt

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-02 Thread Gary Lasker
** Changed in: software-center (Ubuntu) Status: Confirmed => Fix Committed -- Terms of service window is stuck under the payment screen https://bugs.launchpad.net/bugs/625398 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubu

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-02 Thread Gary Lasker
I've implemented a simple fix that lets the "Terms of Service" window show up correctly above the Purchase Dialog. I think this is a good fix for for now and for the time being we don't need to change anything on the payments service side. The branch I linked previously makes a good start toward

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-02 Thread Launchpad Bug Tracker
** Branch linked: lp:~gary-lasker/software-center/tos-simple-fix -- Terms of service window is stuck under the payment screen https://bugs.launchpad.net/bugs/625398 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-02 Thread Gary Lasker
Thanks Ricardo, that makes good sense. From a usability perspective in Software Center it seems like a JS overlay (one of the alternate suggestions you mentioned from bug 598578) to show the "Terms of Service" would be a nice, elegant approach. How do you feel about that? -- Terms of service wi

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-02 Thread Ricardo Kirkner
The "Terms of Service" link is opened in a new window, as per bug #598578. It was reported as an usability issue to drive the user away from the form while he's not finished completing it. We could try to use one of the suggested alternative implementations if that would help this issue. -- Terms

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-01 Thread Gary Lasker
** Attachment added: "UbuntuSSOTermsOfService.png" https://bugs.edge.launchpad.net/ubuntu/+source/software-center/+bug/625398/+attachment/1536551/+files/UbuntuSSOTermsOfService.png -- Terms of service window is stuck under the payment screen https://bugs.launchpad.net/bugs/625398 You receive

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-01 Thread Gary Lasker
** Attachment added: "UbuntuSSOMainPage.png" https://bugs.edge.launchpad.net/ubuntu/+source/software-center/+bug/625398/+attachment/1536550/+files/UbuntuSSOMainPage.png -- Terms of service window is stuck under the payment screen https://bugs.launchpad.net/bugs/625398 You received this bug n

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-01 Thread Gary Lasker
The issue that causes the described focus problems with the Terms of Service popup window is that the current purchase dialog is modal. The attached branch reimplements the dialog as a gtk.Window rather than a gtk.Dialog, with signals replacing the calls to self.response() in the previous implemen

[Bug 625398] Re: Terms of service window is stuck under the payment screen

2010-09-01 Thread Gary Lasker
** Changed in: software-center (Ubuntu) Status: New => Confirmed ** Changed in: software-center (Ubuntu) Importance: Undecided => Medium ** Changed in: software-center (Ubuntu) Assignee: (unassigned) => Gary Lasker (gary-lasker) -- Terms of service window is stuck under the payme