Because the bug report (and how suggested a the fix) is not subscribed
to the bug report anymore, that usplash is about to be dropped by lucid
and that I don't have required knowledge to do more with the current
branch, I'm marking this bug as invalid and removing my branch.
** Changed in:
red_team316 : Thanks a lot for your guidance. You're right. It's works
correctly when using only values lower than 255. I updated my branch to
contains your fix.
--
palette indexes in eft-theme.c should not be prefixed with 0x
https://bugs.launchpad.net/bugs/66760
You received this bug
Colin Watson : Can you take a look at the updated branch that contains
red_team316 works?
--
palette indexes in eft-theme.c should not be prefixed with 0x
https://bugs.launchpad.net/bugs/66760
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
Well, looking at the related branches at the top of the page, it appears that
it is your branch. I cannot change it but it would appear that you can. Are you
saying it won't let you change your own branch? I would think all you would
need to do is make the fix on your computer and then do a bzr
red_team316 : Yes I can update the branch, I thought that you said that
your previous fix was still not correct and that we should keep
hexadecimal values. Do you want me to push your eft-theme.c
(http://launchpadlibrarian.net/16719295/eft-theme.c) to that branch? If
you think that this is a
Make these changes below to your branch in the 3 places they apply:
/* Palette indexes */
.background = 0,
.progressbar_background = 7,
.progressbar_foreground = 100,
.text_background= 21,
.text_foreground= 49,
red_team316 : I also think that your fix is the right one. I found that
using values higher than 255 causes display problems with some usplash
resolutions.
Concerning the multicolors problem, I found that the colors look correct
during boot until Checking root file system Then the colors are
** Attachment added: Usplash before checking root file system...
http://launchpadlibrarian.net/16860705/1.png
--
palette indexes in eft-theme.c should not be prefixed with 0x
https://bugs.launchpad.net/bugs/66760
You received this bug notification because you are a member of Ubuntu
Bugs,
** Attachment added: Usplash after checking root file system...
http://launchpadlibrarian.net/16860707/2.png
--
palette indexes in eft-theme.c should not be prefixed with 0x
https://bugs.launchpad.net/bugs/66760
You received this bug notification because you are a member of Ubuntu
Bugs,
Yep, those pics agree with what I posted above.
Thanks for the Virtualbox tip. I wouldn't say it's fast as I'd have to
rebuild an iso just for a screenie, but VERY useful. Thats thinking out
of(or in this case in the) box :)
About the progress foreground being 156, if I remember correctly, its a
red_team316 : Thanks for your guidance and help on this! My knowledge
and time to fix this is not sufficient here so I can only let the branch
here as it is and change the status to in progress rather than fix
available. If at anytime I can do something that doesn't require
developer skills, don't
Yea, I'll post it. I'll use the image and .c you posted as example. I
dont have a digital camera. I'm guessing there is no other way to take a
screenshot of a usplash...
Also, I tested the fix you submitted with the eft-theme example and I'm pretty
sure those palette indexes of 342 and 369 are
** Attachment added: usplashmagick-test1
http://launchpadlibrarian.net/16719303/usplashmagick-test1
--
palette indexes in eft-theme.c should not be prefixed with 0x
https://bugs.launchpad.net/bugs/66760
You received this bug notification because you are a member of Ubuntu
Bugs, which is
Saïvann Carignan:
I looked at your fix for the palette colors. While the original code was
misleading by using 0x156, changing it to 342 is also incorrect. An 8-bit
graphic by definition can only have a max of 256 colors. I know, the 0x156
displays red for the Failure status, but where the heck
Okay, I've tested a bit more and apparently what was throwing me off is
the fact that text background does not palette properly. Try using
input similar to what I've got posted below. Just don't set them all to
zero(black) as for some reason that actually worked. It should give you
a rectangle of
red_team316 : Thanks for your comment. You probably know this better
than I do. I only know that hexadecimal values result in weird random
colors and that converting the values to decimal fixed the random colors
problem and looked like the real colors (brown and yellow). However, I
have no proof
red_team316 : I compiled the theme with 254 as you suggested and
here's a screenshot of the result, white text on light pink
** Attachment added: IMG_8435.JPG
http://launchpadlibrarian.net/16693657/IMG_8435.JPG
--
palette indexes in eft-theme.c should not be prefixed with 0x
** Attachment added: eft-theme.c
http://launchpadlibrarian.net/16693686/eft-theme.c
--
palette indexes in eft-theme.c should not be prefixed with 0x
https://bugs.launchpad.net/bugs/66760
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to
Saïvann Carignan:
Well, I give your fix 2 thumbs up. It works perfect for me too aside from the
new bug we found.
Could you file a new bug and post the info with it. It's really noticeable
especially when using 3's or some other low palette number. Typically, the
first several palette indexes
red_team316 : I think that you would be the good person to submit the
new bug because I don't really understand where we found a new bug. If
you see a issue that should be fixed, I thank you in advance for your
work! Don't hesitate to ask me to test bugs and patches!
--
palette indexes in
Colin Watson : Thank your for these informations. I converted
hexadecimal numbers using PHP hexdec function, and verified the values
with the calculator from http://www.mrcalculator.com/hexdec.html . I
built the patched example theme and tested it, the colors seems perfect
(yellow and brown). The
I think it's worth having an example theme distributed with usplash
itself, yes.
0x means that what follows is a hexadecimal number, i.e. in base 16.
Decent calculators should be able to do base conversion for you.
--
palette indexes in eft-theme.c should not be prefixed with 0x
The attached branch is surely wrong. For example, it changes 0x156 to
156. Those are different numbers! (As such, the statement in the bug
report that they are short integers from 0 to 255 is also incorrect.)
Did you test this change? Also, please use UNRELEASED in the changelog
rather than a
Colin Watson : Thanks for your comment. In your opinion, is it worth to
keep the edgy theme in usplash sources when the ubuntu default theme is
already included? If yes, Is it possible for you to tell me how to
translate 0x* values to the right ones so I can create a correct branch
for intrepid?
** Summary changed:
- [edgy] palette indexes in eft-theme.c should not be prefixed with 0x
+ palette indexes in eft-theme.c should not be prefixed with 0x
--
palette indexes in eft-theme.c should not be prefixed with 0x
https://bugs.launchpad.net/bugs/66760
You received this bug notification
25 matches
Mail list logo
